Title: [269156] trunk/Source/ThirdParty/libwebrtc
Revision
269156
Author
[email protected]
Date
2020-10-29 11:10:27 -0700 (Thu, 29 Oct 2020)

Log Message

Add some logging to SequenceCheckerImpl::IsCurrent
https://bugs.webkit.org/show_bug.cgi?id=218328

Reviewed by Eric Carlson.

* Source/webrtc/rtc_base/synchronization/sequence_checker.cc:
This might help debugging https://bugs.webkit.org/show_bug.cgi?id=218063.

Modified Paths

Diff

Modified: trunk/Source/ThirdParty/libwebrtc/ChangeLog (269155 => 269156)


--- trunk/Source/ThirdParty/libwebrtc/ChangeLog	2020-10-29 17:53:22 UTC (rev 269155)
+++ trunk/Source/ThirdParty/libwebrtc/ChangeLog	2020-10-29 18:10:27 UTC (rev 269156)
@@ -1,5 +1,15 @@
 2020-10-29  Youenn Fablet  <[email protected]>
 
+        Add some logging to SequenceCheckerImpl::IsCurrent
+        https://bugs.webkit.org/show_bug.cgi?id=218328
+
+        Reviewed by Eric Carlson.
+
+        * Source/webrtc/rtc_base/synchronization/sequence_checker.cc:
+        This might help debugging https://bugs.webkit.org/show_bug.cgi?id=218063.
+
+2020-10-29  Youenn Fablet  <[email protected]>
+
         Disable VP9 VTB hardware decoding
         https://bugs.webkit.org/show_bug.cgi?id=218326
 

Modified: trunk/Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/synchronization/sequence_checker.cc (269155 => 269156)


--- trunk/Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/synchronization/sequence_checker.cc	2020-10-29 17:53:22 UTC (rev 269155)
+++ trunk/Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/synchronization/sequence_checker.cc	2020-10-29 18:10:27 UTC (rev 269156)
@@ -9,6 +9,8 @@
  */
 #include "rtc_base/synchronization/sequence_checker.h"
 
+#include "rtc_base/logging.h"
+
 #if defined(WEBRTC_MAC)
 #include <dispatch/dispatch.h>
 #endif
@@ -47,12 +49,19 @@
     return true;
   }
   if (valid_queue_ || current_queue) {
+    if (valid_queue_ != current_queue)
+      RTC_LOG(LS_ERROR) << "SequenceCheckerImpl queue check is failing";
     return valid_queue_ == current_queue;
   }
   if (valid_system_queue_ && valid_system_queue_ == current_system_queue) {
+    if (valid_queue_ != current_queue)
+      RTC_LOG(LS_ERROR) << "SequenceCheckerImpl system queue check is failing";
     return true;
   }
-  return rtc::IsThreadRefEqual(valid_thread_, current_thread);
+  auto result = rtc::IsThreadRefEqual(valid_thread_, current_thread);
+  if (!result)
+    RTC_LOG(LS_ERROR) << "SequenceCheckerImpl thread check is failing";
+  return result;
 }
 
 void SequenceCheckerImpl::Detach() {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to