Title: [105105] trunk/Source/WebKit2
- Revision
- 105105
- Author
- [email protected]
- Date
- 2012-01-16 16:25:44 -0800 (Mon, 16 Jan 2012)
Log Message
Crash when calling SecItemAdd with a null result pointer
https://bugs.webkit.org/show_bug.cgi?id=76407
<rdar://problem/10696087>
Reviewed by Brady Eidson.
Add null check.
* WebProcess/mac/SecItemShimMethods.mm:
(WebKit::webSecItemAdd):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (105104 => 105105)
--- trunk/Source/WebKit2/ChangeLog 2012-01-17 00:19:57 UTC (rev 105104)
+++ trunk/Source/WebKit2/ChangeLog 2012-01-17 00:25:44 UTC (rev 105105)
@@ -1,3 +1,16 @@
+2012-01-16 Anders Carlsson <[email protected]>
+
+ Crash when calling SecItemAdd with a null result pointer
+ https://bugs.webkit.org/show_bug.cgi?id=76407
+ <rdar://problem/10696087>
+
+ Reviewed by Brady Eidson.
+
+ Add null check.
+
+ * WebProcess/mac/SecItemShimMethods.mm:
+ (WebKit::webSecItemAdd):
+
2012-01-16 Jon Lee <[email protected]>
Build fix for r105086.
Modified: trunk/Source/WebKit2/WebProcess/mac/SecItemShimMethods.mm (105104 => 105105)
--- trunk/Source/WebKit2/WebProcess/mac/SecItemShimMethods.mm 2012-01-17 00:19:57 UTC (rev 105104)
+++ trunk/Source/WebKit2/WebProcess/mac/SecItemShimMethods.mm 2012-01-17 00:25:44 UTC (rev 105105)
@@ -80,8 +80,9 @@
OwnPtr<SecItemResponseData> response = sendSeqItemRequest(SecItemRequestData::Add, query);
if (!response)
return errSecInteractionNotAllowed;
-
- *result = response->resultObject().leakRef();
+
+ if (result)
+ *result = response->resultObject().leakRef();
return response->resultCode();
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
