Title: [269190] trunk/Source/WebCore
- Revision
- 269190
- Author
- [email protected]
- Date
- 2020-10-30 10:02:47 -0700 (Fri, 30 Oct 2020)
Log Message
Increase camera failing timer to 30 seconds
https://bugs.webkit.org/show_bug.cgi?id=218389
Reviewed by Eric Carlson.
>From testing, 3 seconds is not always enough if getUserMedia is quickly called multiple times.
Let's increase to 30 seconds to give room for slow systems while still being able to identify failures.
* platform/mediastream/mac/AVVideoCaptureSource.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (269189 => 269190)
--- trunk/Source/WebCore/ChangeLog 2020-10-30 16:52:47 UTC (rev 269189)
+++ trunk/Source/WebCore/ChangeLog 2020-10-30 17:02:47 UTC (rev 269190)
@@ -1,3 +1,15 @@
+2020-10-30 Youenn Fablet <[email protected]>
+
+ Increase camera failing timer to 30 seconds
+ https://bugs.webkit.org/show_bug.cgi?id=218389
+
+ Reviewed by Eric Carlson.
+
+ From testing, 3 seconds is not always enough if getUserMedia is quickly called multiple times.
+ Let's increase to 30 seconds to give room for slow systems while still being able to identify failures.
+
+ * platform/mediastream/mac/AVVideoCaptureSource.h:
+
2020-10-30 Antti Koivisto <[email protected]>
REGRESSION (r269146): ASSERTION FAILED: didNeedLayout || logicalHeight() == oldHeight in WebCore::RenderBlockFlow::ensureLineBoxes
Modified: trunk/Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.h (269189 => 269190)
--- trunk/Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.h 2020-10-30 16:52:47 UTC (rev 269189)
+++ trunk/Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.h 2020-10-30 17:02:47 UTC (rev 269190)
@@ -139,7 +139,7 @@
bool m_interrupted { false };
bool m_isRunning { false };
- static constexpr Seconds verifyCaptureInterval = 3_s;
+ static constexpr Seconds verifyCaptureInterval = 30_s;
static const uint64_t framesToDropWhenStarting = 4;
Timer m_verifyCapturingTimer;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
