Title: [269194] branches/safari-611.1.4-branch/Source/WebInspectorUI
- Revision
- 269194
- Author
- [email protected]
- Date
- 2020-10-30 10:42:28 -0700 (Fri, 30 Oct 2020)
Log Message
Cherry-pick r269071. rdar://problem/70831166
Web Inspector: REGRESSION(r266669): Uncaught Exception: TypeError: node.nodeType is not a function. (In 'node.nodeType()', 'node.nodeType' is undefined)
https://bugs.webkit.org/show_bug.cgi?id=218254
Reviewed by Joseph Pecoraro.
r266669 changed `WI.DOMBreakpoint` to use `WI.DOMNode` instead of `DOM.NodeId`, meaning that
`WI.DOMTreeContentView.prototype._updateBreakpointStatus` now expects a `WI.DOMNode`.
* UserInterface/Views/DOMTreeContentView.js:
(WI.DOMTreeContentView.prototype._domTreeElementAdded):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@269071 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
Diff
Modified: branches/safari-611.1.4-branch/Source/WebInspectorUI/ChangeLog (269193 => 269194)
--- branches/safari-611.1.4-branch/Source/WebInspectorUI/ChangeLog 2020-10-30 17:42:26 UTC (rev 269193)
+++ branches/safari-611.1.4-branch/Source/WebInspectorUI/ChangeLog 2020-10-30 17:42:28 UTC (rev 269194)
@@ -1,3 +1,34 @@
+2020-10-29 Alan Coon <[email protected]>
+
+ Cherry-pick r269071. rdar://problem/70831166
+
+ Web Inspector: REGRESSION(r266669): Uncaught Exception: TypeError: node.nodeType is not a function. (In 'node.nodeType()', 'node.nodeType' is undefined)
+ https://bugs.webkit.org/show_bug.cgi?id=218254
+
+ Reviewed by Joseph Pecoraro.
+
+ r266669 changed `WI.DOMBreakpoint` to use `WI.DOMNode` instead of `DOM.NodeId`, meaning that
+ `WI.DOMTreeContentView.prototype._updateBreakpointStatus` now expects a `WI.DOMNode`.
+
+ * UserInterface/Views/DOMTreeContentView.js:
+ (WI.DOMTreeContentView.prototype._domTreeElementAdded):
+
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@269071 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2020-10-27 Devin Rousso <[email protected]>
+
+ Web Inspector: REGRESSION(r266669): Uncaught Exception: TypeError: node.nodeType is not a function. (In 'node.nodeType()', 'node.nodeType' is undefined)
+ https://bugs.webkit.org/show_bug.cgi?id=218254
+
+ Reviewed by Joseph Pecoraro.
+
+ r266669 changed `WI.DOMBreakpoint` to use `WI.DOMNode` instead of `DOM.NodeId`, meaning that
+ `WI.DOMTreeContentView.prototype._updateBreakpointStatus` now expects a `WI.DOMNode`.
+
+ * UserInterface/Views/DOMTreeContentView.js:
+ (WI.DOMTreeContentView.prototype._domTreeElementAdded):
+
2020-10-26 Alan Coon <[email protected]>
Cherry-pick r268885. rdar://problem/70702192
Modified: branches/safari-611.1.4-branch/Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js (269193 => 269194)
--- branches/safari-611.1.4-branch/Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js 2020-10-30 17:42:26 UTC (rev 269193)
+++ branches/safari-611.1.4-branch/Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js 2020-10-30 17:42:28 UTC (rev 269194)
@@ -500,7 +500,7 @@
if (!this._pendingBreakpointNodes.delete(node))
return;
- this._updateBreakpointStatus(node.id);
+ this._updateBreakpointStatus(node);
}
_domTreeSelectionDidChange(event)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
