Title: [105111] trunk/Source/WebCore
- Revision
- 105111
- Author
- [email protected]
- Date
- 2012-01-16 17:12:51 -0800 (Mon, 16 Jan 2012)
Log Message
REGRESSION: r102553 Autocorrection bubble doesn't show up
https://bugs.webkit.org/show_bug.cgi?id=76408
<rdar://problem/10644746>
Prior to r102553 Editor::markAllMisspellingsAndBadGrammarInRanges() used to pass its
textCheckingOptions directly to markAndReplaceFor(). Now a request object is used,
but, when the object is created, the TextCheckingTypeShowCorrectionPanel flag is dropped.
Reviewed by Darin Adler.
* editing/Editor.cpp:
(WebCore::Editor::resolveTextCheckingTypeMask): Add TextCheckingTypeShowCorrectionPanel to
the returned checkingTypes when appropriate.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (105110 => 105111)
--- trunk/Source/WebCore/ChangeLog 2012-01-17 01:10:50 UTC (rev 105110)
+++ trunk/Source/WebCore/ChangeLog 2012-01-17 01:12:51 UTC (rev 105111)
@@ -1,3 +1,19 @@
+2012-01-16 Enrica Casucci <[email protected]>
+
+ REGRESSION: r102553 Autocorrection bubble doesn't show up
+ https://bugs.webkit.org/show_bug.cgi?id=76408
+ <rdar://problem/10644746>
+
+ Prior to r102553 Editor::markAllMisspellingsAndBadGrammarInRanges() used to pass its
+ textCheckingOptions directly to markAndReplaceFor(). Now a request object is used,
+ but, when the object is created, the TextCheckingTypeShowCorrectionPanel flag is dropped.
+
+ Reviewed by Darin Adler.
+
+ * editing/Editor.cpp:
+ (WebCore::Editor::resolveTextCheckingTypeMask): Add TextCheckingTypeShowCorrectionPanel to
+ the returned checkingTypes when appropriate.
+
2012-01-16 Jon Lee <[email protected]>
Build fix for r105086.
Modified: trunk/Source/WebCore/editing/Editor.cpp (105110 => 105111)
--- trunk/Source/WebCore/editing/Editor.cpp 2012-01-17 01:10:50 UTC (rev 105110)
+++ trunk/Source/WebCore/editing/Editor.cpp 2012-01-17 01:12:51 UTC (rev 105111)
@@ -3075,6 +3075,8 @@
checkingTypes |= TextCheckingTypeGrammar;
if (shouldCheckForCorrection)
checkingTypes |= TextCheckingTypeCorrection;
+ if (shouldShowCorrectionPanel)
+ checkingTypes |= TextCheckingTypeShowCorrectionPanel;
#if USE(AUTOMATIC_TEXT_REPLACEMENT)
bool shouldPerformReplacement = textCheckingOptions & TextCheckingTypeReplacement;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
