Diff
Modified: trunk/LayoutTests/ChangeLog (269223 => 269224)
--- trunk/LayoutTests/ChangeLog 2020-10-31 12:19:30 UTC (rev 269223)
+++ trunk/LayoutTests/ChangeLog 2020-10-31 12:53:05 UTC (rev 269224)
@@ -1,3 +1,16 @@
+2020-10-31 Zalan Bujtas <[email protected]>
+
+ Remove unneeded whitespace between content and <br>
+ https://bugs.webkit.org/show_bug.cgi?id=218151
+ <rdar://problem/70662471>
+
+ Reviewed by Antti Koivisto.
+
+ Missed these files in r268958.
+
+ * editing/inserting/paragraph-separator-in-table-1.html:
+ * platform/mac/editing/inserting/paragraph-separator-in-table-1-expected.txt:
+
2020-10-30 Karl Rackler <[email protected]>
REGRESSION (r269070): [ Big Sur ] editing/input/reveal-caret-of-multiline-input.html is a constant failure
Modified: trunk/LayoutTests/editing/inserting/paragraph-separator-in-table-1.html (269223 => 269224)
--- trunk/LayoutTests/editing/inserting/paragraph-separator-in-table-1.html 2020-10-31 12:19:30 UTC (rev 269223)
+++ trunk/LayoutTests/editing/inserting/paragraph-separator-in-table-1.html 2020-10-31 12:53:05 UTC (rev 269224)
@@ -4,7 +4,7 @@
</script>
<p>This tests InsertParagraphSeparator inside table cells. 'Cell' and 'Two' should be on separate lines.</p>
-<div contenteditable="true"><table border="1"><tr><td>Cell One</td><td>Cell <span id="test">Two</span></td></tr></table></div>
+<div contenteditable="true"><table border="1"><tr><td>Cell One</td><td>Cell<span id="test">Two</span></td></tr></table></div>
<script>
var e = document.getElementById("test").firstChild;
Modified: trunk/LayoutTests/platform/ios/editing/inserting/paragraph-separator-in-table-1-expected.txt (269223 => 269224)
--- trunk/LayoutTests/platform/ios/editing/inserting/paragraph-separator-in-table-1-expected.txt 2020-10-31 12:19:30 UTC (rev 269223)
+++ trunk/LayoutTests/platform/ios/editing/inserting/paragraph-separator-in-table-1-expected.txt 2020-10-31 12:53:05 UTC (rev 269224)
@@ -1,7 +1,7 @@
EDITING DELEGATE: shouldBeginEditingInDOMRange:range from 0 of DIV > BODY > HTML > #document to 1 of DIV > BODY > HTML > #document
EDITING DELEGATE: webViewDidBeginEditing:WebViewDidBeginEditingNotification
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 5 of #text > TD > TR > TBODY > TABLE > DIV > BODY > HTML > #document to 5 of #text > TD > TR > TBODY > TABLE > DIV > BODY > HTML > #document toDOMRange:range from 2 of TD > TR > TBODY > TABLE > DIV > BODY > HTML > #document to 2 of TD > TR > TBODY > TABLE > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
+EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 4 of #text > TD > TR > TBODY > TABLE > DIV > BODY > HTML > #document to 4 of #text > TD > TR > TBODY > TABLE > DIV > BODY > HTML > #document toDOMRange:range from 2 of TD > TR > TBODY > TABLE > DIV > BODY > HTML > #document to 2 of TD > TR > TBODY > TABLE > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
layer at (0,0) size 800x600
@@ -14,16 +14,16 @@
text run at (0,0) width 347: "This tests InsertParagraphSeparator inside table cells. "
text run at (346,0) width 279: "'Cell' and 'Two' should be on separate lines."
RenderBlock {DIV} at (0,36) size 784x50
- RenderTable {TABLE} at (0,0) size 104x50 [border: (1px outset #808080)]
- RenderTableSection {TBODY} at (1,1) size 102x48
- RenderTableRow {TR} at (0,2) size 102x44
+ RenderTable {TABLE} at (0,0) size 102x50 [border: (1px outset #808080)]
+ RenderTableSection {TBODY} at (1,1) size 100x48
+ RenderTableRow {TR} at (0,2) size 100x44
RenderTableCell {TD} at (2,12) size 62x24 [border: (1px inset #808080)] [r=0 c=0 rs=1 cs=1]
RenderText {#text} at (2,2) size 58x19
text run at (2,2) width 58: "Cell One"
- RenderTableCell {TD} at (65,2) size 35x44 [border: (1px inset #808080)] [r=0 c=1 rs=1 cs=1]
- RenderText {#text} at (2,2) size 31x19
- text run at (2,2) width 31: "Cell "
- RenderBR {BR} at (32,2) size 1x19
+ RenderTableCell {TD} at (65,2) size 33x44 [border: (1px inset #808080)] [r=0 c=1 rs=1 cs=1]
+ RenderText {#text} at (2,2) size 27x19
+ text run at (2,2) width 27: "Cell"
+ RenderBR {BR} at (28,2) size 1x19
RenderInline {SPAN} at (0,0) size 29x19
RenderText {#text} at (2,22) size 29x19
text run at (2,22) width 29: "Two"
Modified: trunk/LayoutTests/platform/mac/editing/inserting/paragraph-separator-in-table-1-expected.txt (269223 => 269224)
--- trunk/LayoutTests/platform/mac/editing/inserting/paragraph-separator-in-table-1-expected.txt 2020-10-31 12:19:30 UTC (rev 269223)
+++ trunk/LayoutTests/platform/mac/editing/inserting/paragraph-separator-in-table-1-expected.txt 2020-10-31 12:53:05 UTC (rev 269224)
@@ -1,7 +1,7 @@
EDITING DELEGATE: shouldBeginEditingInDOMRange:range from 0 of DIV > BODY > HTML > #document to 1 of DIV > BODY > HTML > #document
EDITING DELEGATE: webViewDidBeginEditing:WebViewDidBeginEditingNotification
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 5 of #text > TD > TR > TBODY > TABLE > DIV > BODY > HTML > #document to 5 of #text > TD > TR > TBODY > TABLE > DIV > BODY > HTML > #document toDOMRange:range from 2 of TD > TR > TBODY > TABLE > DIV > BODY > HTML > #document to 2 of TD > TR > TBODY > TABLE > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
+EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 4 of #text > TD > TR > TBODY > TABLE > DIV > BODY > HTML > #document to 4 of #text > TD > TR > TBODY > TABLE > DIV > BODY > HTML > #document toDOMRange:range from 2 of TD > TR > TBODY > TABLE > DIV > BODY > HTML > #document to 2 of TD > TR > TBODY > TABLE > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
layer at (0,0) size 800x600
@@ -14,16 +14,16 @@
text run at (0,0) width 347: "This tests InsertParagraphSeparator inside table cells. "
text run at (346,0) width 279: "'Cell' and 'Two' should be on separate lines."
RenderBlock {DIV} at (0,34) size 784x46
- RenderTable {TABLE} at (0,0) size 104x46 [border: (1px outset #808080)]
- RenderTableSection {TBODY} at (1,1) size 102x44
- RenderTableRow {TR} at (0,2) size 102x40
+ RenderTable {TABLE} at (0,0) size 102x46 [border: (1px outset #808080)]
+ RenderTableSection {TBODY} at (1,1) size 100x44
+ RenderTableRow {TR} at (0,2) size 100x40
RenderTableCell {TD} at (2,11) size 62x22 [border: (1px inset #808080)] [r=0 c=0 rs=1 cs=1]
RenderText {#text} at (2,2) size 58x18
text run at (2,2) width 58: "Cell One"
- RenderTableCell {TD} at (65,2) size 35x40 [border: (1px inset #808080)] [r=0 c=1 rs=1 cs=1]
- RenderText {#text} at (2,2) size 31x18
- text run at (2,2) width 31: "Cell "
- RenderBR {BR} at (32,2) size 1x18
+ RenderTableCell {TD} at (65,2) size 33x40 [border: (1px inset #808080)] [r=0 c=1 rs=1 cs=1]
+ RenderText {#text} at (2,2) size 27x18
+ text run at (2,2) width 27: "Cell"
+ RenderBR {BR} at (28,2) size 1x18
RenderInline {SPAN} at (0,0) size 29x18
RenderText {#text} at (2,20) size 29x18
text run at (2,20) width 29: "Two"
Modified: trunk/LayoutTests/platform/win/editing/inserting/paragraph-separator-in-table-1-expected.txt (269223 => 269224)
--- trunk/LayoutTests/platform/win/editing/inserting/paragraph-separator-in-table-1-expected.txt 2020-10-31 12:19:30 UTC (rev 269223)
+++ trunk/LayoutTests/platform/win/editing/inserting/paragraph-separator-in-table-1-expected.txt 2020-10-31 12:53:05 UTC (rev 269224)
@@ -1,7 +1,7 @@
EDITING DELEGATE: shouldBeginEditingInDOMRange:range from 0 of DIV > BODY > HTML > #document to 1 of DIV > BODY > HTML > #document
EDITING DELEGATE: webViewDidBeginEditing:WebViewDidBeginEditingNotification
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 5 of #text > TD > TR > TBODY > TABLE > DIV > BODY > HTML > #document to 5 of #text > TD > TR > TBODY > TABLE > DIV > BODY > HTML > #document toDOMRange:range from 2 of TD > TR > TBODY > TABLE > DIV > BODY > HTML > #document to 2 of TD > TR > TBODY > TABLE > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
+EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 4 of #text > TD > TR > TBODY > TABLE > DIV > BODY > HTML > #document to 4 of #text > TD > TR > TBODY > TABLE > DIV > BODY > HTML > #document toDOMRange:range from 2 of TD > TR > TBODY > TABLE > DIV > BODY > HTML > #document to 2 of TD > TR > TBODY > TABLE > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
layer at (0,0) size 800x600
@@ -21,9 +21,9 @@
RenderText {#text} at (2,2) size 57x18
text run at (2,2) width 57: "Cell One"
RenderTableCell {TD} at (65,2) size 34x40 [border: (1px inset #808080)] [r=0 c=1 rs=1 cs=1]
- RenderText {#text} at (2,2) size 30x18
- text run at (2,2) width 30: "Cell "
- RenderBR {BR} at (32,2) size 0x18
+ RenderText {#text} at (2,2) size 26x18
+ text run at (2,2) width 26: "Cell"
+ RenderBR {BR} at (28,2) size 0x18
RenderInline {SPAN} at (0,0) size 30x18
RenderText {#text} at (2,20) size 30x18
text run at (2,20) width 30: "Two"