Title: [269245] trunk/Source/WebCore
- Revision
- 269245
- Author
- [email protected]
- Date
- 2020-11-02 06:12:11 -0800 (Mon, 02 Nov 2020)
Log Message
[LFC][IFC] Empty lines stay empty even when the imaginary strut is present
https://bugs.webkit.org/show_bug.cgi?id=218420
Reviewed by Antti Koivisto.
Use the more correct runs.isEmpty() check to decide whether the root inline box should stay empty.
* layout/inlineformatting/InlineFormattingContextGeometry.cpp:
(WebCore::Layout::LineBoxBuilder::constructInlineLevelBoxes):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (269244 => 269245)
--- trunk/Source/WebCore/ChangeLog 2020-11-02 08:35:36 UTC (rev 269244)
+++ trunk/Source/WebCore/ChangeLog 2020-11-02 14:12:11 UTC (rev 269245)
@@ -1,3 +1,15 @@
+2020-11-02 Zalan Bujtas <[email protected]>
+
+ [LFC][IFC] Empty lines stay empty even when the imaginary strut is present
+ https://bugs.webkit.org/show_bug.cgi?id=218420
+
+ Reviewed by Antti Koivisto.
+
+ Use the more correct runs.isEmpty() check to decide whether the root inline box should stay empty.
+
+ * layout/inlineformatting/InlineFormattingContextGeometry.cpp:
+ (WebCore::Layout::LineBoxBuilder::constructInlineLevelBoxes):
+
2020-11-02 Youenn Fablet <[email protected]>
Stop sending origins from WebProcess to UIProcess for getUserMedia requests
Modified: trunk/Source/WebCore/layout/inlineformatting/InlineFormattingContextGeometry.cpp (269244 => 269245)
--- trunk/Source/WebCore/layout/inlineformatting/InlineFormattingContextGeometry.cpp 2020-11-02 08:35:36 UTC (rev 269244)
+++ trunk/Source/WebCore/layout/inlineformatting/InlineFormattingContextGeometry.cpp 2020-11-02 14:12:11 UTC (rev 269245)
@@ -208,7 +208,7 @@
auto rootInlineBox = LineBox::InlineLevelBox::createRootInlineBox(rootBox(), horizontalAligmentOffset, lineBox.logicalWidth());
auto lineHasImaginaryStrut = layoutState().inNoQuirksMode();
- auto isInitiallyConsideredNonEmpty = !lineBox.isLineVisuallyEmpty() && lineHasImaginaryStrut;
+ auto isInitiallyConsideredNonEmpty = lineHasImaginaryStrut && !runs.isEmpty();
if (isInitiallyConsideredNonEmpty)
rootInlineBox->setIsNonEmpty();
setVerticalGeometryForInlineBox(*rootInlineBox);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
