[webkit-changes] [105126] trunk/Source/WebCore

[commit-queue]

Title: [105126] trunk/Source/WebCore

Revision

105126

Author

commit-qu...@webkit.org

Date

2012-01-16 22:44:52 -0800 (Mon, 16 Jan 2012)

Log Message

[Internals] member varaibles should follow naming convention.
https://bugs.webkit.org/show_bug.cgi?id=76426

Patch by Hajime Morrita <morr...@chromium.org> on 2012-01-16
Reviewed by Kent Tamura.

No new tests. Just a rename.

* testing/Internals.cpp:
(WebCore::Internals::Internals):
(WebCore::Internals::setPasswordEchoEnabled):
(WebCore::Internals::setPasswordEchoDurationInSeconds):
(WebCore::Internals::reset):
* testing/Internals.h:

Modified Paths

• trunk/Source/WebCore/ChangeLog
• trunk/Source/WebCore/testing/Internals.cpp
• trunk/Source/WebCore/testing/Internals.h

Diff

Modified: trunk/Source/WebCore/ChangeLog (105125 => 105126)

--- trunk/Source/WebCore/ChangeLog	2012-01-17 06:02:29 UTC (rev 105125)
+++ trunk/Source/WebCore/ChangeLog	2012-01-17 06:44:52 UTC (rev 105126)
@@ -1,3 +1,19 @@
+2012-01-16  Hajime Morrita  <morr...@chromium.org>
+
+        [Internals] member varaibles should follow naming convention.
+        https://bugs.webkit.org/show_bug.cgi?id=76426
+
+        Reviewed by Kent Tamura.
+
+        No new tests. Just a rename.
+
+        * testing/Internals.cpp:
+        (WebCore::Internals::Internals):
+        (WebCore::Internals::setPasswordEchoEnabled):
+        (WebCore::Internals::setPasswordEchoDurationInSeconds):
+        (WebCore::Internals::reset):
+        * testing/Internals.h:
+
 2012-01-16  Hayato Ito  <hay...@chromium.org>
 
         Implement multiple AT_TARGET event dispatching in regard to shadow tree.

Modified: trunk/Source/WebCore/testing/Internals.cpp (105125 => 105126)

--- trunk/Source/WebCore/testing/Internals.cpp	2012-01-17 06:02:29 UTC (rev 105125)
+++ trunk/Source/WebCore/testing/Internals.cpp	2012-01-17 06:44:52 UTC (rev 105126)
@@ -113,8 +113,9 @@
 }
 
 Internals::Internals()
-    : passwordEchoDurationInSecondsBackedUp(false)
-    , passwordEchoEnabledBackedUp(false)
+    : m_passwordEchoDurationInSecondsBackup(0)
+    , m_passwordEchoDurationInSecondsBackedUp(false)
+    , m_passwordEchoEnabledBackedUp(false)
 {
 }
 
@@ -397,9 +398,9 @@
         return;
     }
 
-    if (!passwordEchoEnabledBackedUp) {
-        passwordEchoEnabledBackup = document->settings()->passwordEchoEnabled();
-        passwordEchoEnabledBackedUp = true;
+    if (!m_passwordEchoEnabledBackedUp) {
+        m_passwordEchoEnabledBackup = document->settings()->passwordEchoEnabled();
+        m_passwordEchoEnabledBackedUp = true;
     }
     document->settings()->setPasswordEchoEnabled(enabled);
 }
@@ -411,9 +412,9 @@
         return;
     }
 
-    if (!passwordEchoDurationInSecondsBackedUp) {
-        passwordEchoDurationInSecondsBackup = document->settings()->passwordEchoDurationInSeconds();
-        passwordEchoDurationInSecondsBackedUp = true;
+    if (!m_passwordEchoDurationInSecondsBackedUp) {
+        m_passwordEchoDurationInSecondsBackup = document->settings()->passwordEchoDurationInSeconds();
+        m_passwordEchoDurationInSecondsBackedUp = true;
     }
     document->settings()->setPasswordEchoDurationInSeconds(durationInSeconds);
 }
@@ -465,14 +466,14 @@
     if (!document || !document->settings())
         return;
 
-    if (passwordEchoDurationInSecondsBackedUp) {
-        document->settings()->setPasswordEchoDurationInSeconds(passwordEchoDurationInSecondsBackup);
-        passwordEchoDurationInSecondsBackedUp = false;
+    if (m_passwordEchoDurationInSecondsBackedUp) {
+        document->settings()->setPasswordEchoDurationInSeconds(m_passwordEchoDurationInSecondsBackup);
+        m_passwordEchoDurationInSecondsBackedUp = false;
     }
 
-    if (passwordEchoEnabledBackedUp) {
-        document->settings()->setPasswordEchoEnabled(passwordEchoEnabledBackup);
-        passwordEchoEnabledBackedUp = false;
+    if (m_passwordEchoEnabledBackedUp) {
+        document->settings()->setPasswordEchoEnabled(m_passwordEchoEnabledBackup);
+        m_passwordEchoEnabledBackedUp = false;
     }
 
     if (Page* page = document->page())

Modified: trunk/Source/WebCore/testing/Internals.h (105125 => 105126)

--- trunk/Source/WebCore/testing/Internals.h	2012-01-17 06:02:29 UTC (rev 105125)
+++ trunk/Source/WebCore/testing/Internals.h	2012-01-17 06:44:52 UTC (rev 105126)
@@ -122,10 +122,10 @@
 private:
     Internals();
 
-    double passwordEchoDurationInSecondsBackup;
-    bool passwordEchoEnabledBackup : 1;
-    bool passwordEchoDurationInSecondsBackedUp : 1;
-    bool passwordEchoEnabledBackedUp : 1;
+    double m_passwordEchoDurationInSecondsBackup;
+    bool m_passwordEchoEnabledBackup : 1;
+    bool m_passwordEchoDurationInSecondsBackedUp : 1;
+    bool m_passwordEchoEnabledBackedUp : 1;
 };
 
 } // namespace WebCore

_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes