Title: [269438] trunk/Source/WebInspectorUI
- Revision
- 269438
- Author
- [email protected]
- Date
- 2020-11-05 09:01:10 -0800 (Thu, 05 Nov 2020)
Log Message
Web Inspector: REGRESSION(?): Sources: override banner is squished for large images
https://bugs.webkit.org/show_bug.cgi?id=218196
Reviewed by Devin Rousso.
Progressions made in https://trac.webkit.org/changeset/266695/webkit caused the image container to occupy the
maximum amount of space possible, which caused the override banner to be squished and a scrollbar to appear.
This is resolved by making sure the minimum dimensions of the image containers are 0, so that the container can
be `flex-shrink`ed.
* UserInterface/Views/ImageResourceContentView.css:
(.content-view.resource.image > .img-container):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (269437 => 269438)
--- trunk/Source/WebInspectorUI/ChangeLog 2020-11-05 16:58:46 UTC (rev 269437)
+++ trunk/Source/WebInspectorUI/ChangeLog 2020-11-05 17:01:10 UTC (rev 269438)
@@ -1,3 +1,18 @@
+2020-11-05 Patrick Angle <[email protected]>
+
+ Web Inspector: REGRESSION(?): Sources: override banner is squished for large images
+ https://bugs.webkit.org/show_bug.cgi?id=218196
+
+ Reviewed by Devin Rousso.
+
+ Progressions made in https://trac.webkit.org/changeset/266695/webkit caused the image container to occupy the
+ maximum amount of space possible, which caused the override banner to be squished and a scrollbar to appear.
+ This is resolved by making sure the minimum dimensions of the image containers are 0, so that the container can
+ be `flex-shrink`ed.
+
+ * UserInterface/Views/ImageResourceContentView.css:
+ (.content-view.resource.image > .img-container):
+
2020-11-04 David Kilzer <[email protected]>
WebKit should remove unused debug variant support
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ImageResourceContentView.css (269437 => 269438)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ImageResourceContentView.css 2020-11-05 16:58:46 UTC (rev 269437)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ImageResourceContentView.css 2020-11-05 17:01:10 UTC (rev 269438)
@@ -43,6 +43,8 @@
align-items: center;
width: 100%;
height: 100%;
+ min-width: 0;
+ min-height: 0;
padding: 15px;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
