Title: [269429] trunk/Tools
- Revision
- 269429
- Author
- [email protected]
- Date
- 2020-11-05 06:44:28 -0800 (Thu, 05 Nov 2020)
Log Message
Test that skip_validation is effective
https://bugs.webkit.org/show_bug.cgi?id=218611
Patch by Angelos Oikonomopoulos <[email protected]> on 2020-11-05
Reviewed by Aakash Jain.
* CISupport/ews-build/steps_unittest.py:
Modified Paths
Diff
Modified: trunk/Tools/CISupport/ews-build/steps_unittest.py (269428 => 269429)
--- trunk/Tools/CISupport/ews-build/steps_unittest.py 2020-11-05 14:23:13 UTC (rev 269428)
+++ trunk/Tools/CISupport/ews-build/steps_unittest.py 2020-11-05 14:44:28 UTC (rev 269429)
@@ -3589,6 +3589,22 @@
return rc
+class TestValidatePatch(BuildStepMixinAdditions, unittest.TestCase):
+ def setUp(self):
+ return self.setUpBuildStep()
+
+ def tearDown(self):
+ return self.tearDownBuildStep()
+
+ def test_skipped(self):
+ self.setupStep(ValidatePatch())
+ self.setProperty('patch_id', '1234')
+ self.setProperty('bug_id', '5678')
+ self.setProperty('skip_validation', True)
+ self.expectOutcome(result=SKIPPED, state_string='Validated patch (skipped)')
+ return self.runStep()
+
+
class TestValidateCommiterAndReviewer(BuildStepMixinAdditions, unittest.TestCase):
def setUp(self):
self.longMessage = True
Modified: trunk/Tools/ChangeLog (269428 => 269429)
--- trunk/Tools/ChangeLog 2020-11-05 14:23:13 UTC (rev 269428)
+++ trunk/Tools/ChangeLog 2020-11-05 14:44:28 UTC (rev 269429)
@@ -1,5 +1,14 @@
2020-11-05 Angelos Oikonomopoulos <[email protected]>
+ Test that skip_validation is effective
+ https://bugs.webkit.org/show_bug.cgi?id=218611
+
+ Reviewed by Aakash Jain.
+
+ * CISupport/ews-build/steps_unittest.py:
+
+2020-11-05 Angelos Oikonomopoulos <[email protected]>
+
Test that TransferToS3 is skipped properly
https://bugs.webkit.org/show_bug.cgi?id=218610
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
