- Revision
- 269476
- Author
- [email protected]
- Date
- 2020-11-05 14:39:40 -0800 (Thu, 05 Nov 2020)
Log Message
DOMStringList, TextMetrics & ImageBitmapRenderingContext should be exposed to workers
https://bugs.webkit.org/show_bug.cgi?id=218631
Reviewed by Geoffrey Garen.
LayoutTests/imported/w3c:
Rebaseline WPT test now that more checks are passing.
* web-platform-tests/html/dom/idlharness.worker-expected.txt:
Source/WebCore:
DOMStringList, TextMetrics & ImageBitmapRenderingContext should be exposed to workers:
- https://html.spec.whatwg.org/multipage/common-dom-interfaces.html#domstringlist
- https://html.spec.whatwg.org/multipage/canvas.html#textmetrics
- https://html.spec.whatwg.org/multipage/canvas.html#imagebitmaprenderingcontext
No new tests, rebaselined existing test.
* dom/DOMStringList.idl:
* html/TextMetrics.idl:
* html/canvas/ImageBitmapRenderingContext.idl:
Modified Paths
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (269475 => 269476)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2020-11-05 22:22:01 UTC (rev 269475)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2020-11-05 22:39:40 UTC (rev 269476)
@@ -1,3 +1,14 @@
+2020-11-05 Chris Dumez <[email protected]>
+
+ DOMStringList, TextMetrics & ImageBitmapRenderingContext should be exposed to workers
+ https://bugs.webkit.org/show_bug.cgi?id=218631
+
+ Reviewed by Geoffrey Garen.
+
+ Rebaseline WPT test now that more checks are passing.
+
+ * web-platform-tests/html/dom/idlharness.worker-expected.txt:
+
2020-11-05 Youenn Fablet <[email protected]>
WebSocket constructor should not throw in case port is blocked
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/idlharness.worker-expected.txt (269475 => 269476)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/idlharness.worker-expected.txt 2020-11-05 22:22:01 UTC (rev 269475)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/idlharness.worker-expected.txt 2020-11-05 22:39:40 UTC (rev 269476)
@@ -160,15 +160,15 @@
PASS HTMLFormControlsCollection interface: existence and properties of interface object
PASS RadioNodeList interface: existence and properties of interface object
PASS HTMLOptionsCollection interface: existence and properties of interface object
-FAIL DOMStringList interface: existence and properties of interface object assert_own_property: self does not have own property "DOMStringList" expected property "DOMStringList" missing
-FAIL DOMStringList interface object length assert_own_property: self does not have own property "DOMStringList" expected property "DOMStringList" missing
-FAIL DOMStringList interface object name assert_own_property: self does not have own property "DOMStringList" expected property "DOMStringList" missing
-FAIL DOMStringList interface: existence and properties of interface prototype object assert_own_property: self does not have own property "DOMStringList" expected property "DOMStringList" missing
-FAIL DOMStringList interface: existence and properties of interface prototype object's "constructor" property assert_own_property: self does not have own property "DOMStringList" expected property "DOMStringList" missing
-FAIL DOMStringList interface: existence and properties of interface prototype object's @@unscopables property assert_own_property: self does not have own property "DOMStringList" expected property "DOMStringList" missing
-FAIL DOMStringList interface: attribute length assert_own_property: self does not have own property "DOMStringList" expected property "DOMStringList" missing
-FAIL DOMStringList interface: operation item(unsigned long) assert_own_property: self does not have own property "DOMStringList" expected property "DOMStringList" missing
-FAIL DOMStringList interface: operation contains(DOMString) assert_own_property: self does not have own property "DOMStringList" expected property "DOMStringList" missing
+PASS DOMStringList interface: existence and properties of interface object
+PASS DOMStringList interface object length
+PASS DOMStringList interface object name
+PASS DOMStringList interface: existence and properties of interface prototype object
+PASS DOMStringList interface: existence and properties of interface prototype object's "constructor" property
+PASS DOMStringList interface: existence and properties of interface prototype object's @@unscopables property
+PASS DOMStringList interface: attribute length
+PASS DOMStringList interface: operation item(unsigned long)
+PASS DOMStringList interface: operation contains(DOMString)
PASS HTMLElement interface: existence and properties of interface object
PASS HTMLUnknownElement interface: existence and properties of interface object
PASS DOMStringMap interface: existence and properties of interface object
@@ -265,24 +265,24 @@
PASS CanvasPattern interface: existence and properties of interface prototype object's "constructor" property
PASS CanvasPattern interface: existence and properties of interface prototype object's @@unscopables property
PASS CanvasPattern interface: operation setTransform(optional DOMMatrix2DInit)
-FAIL TextMetrics interface: existence and properties of interface object assert_own_property: self does not have own property "TextMetrics" expected property "TextMetrics" missing
-FAIL TextMetrics interface object length assert_own_property: self does not have own property "TextMetrics" expected property "TextMetrics" missing
-FAIL TextMetrics interface object name assert_own_property: self does not have own property "TextMetrics" expected property "TextMetrics" missing
-FAIL TextMetrics interface: existence and properties of interface prototype object assert_own_property: self does not have own property "TextMetrics" expected property "TextMetrics" missing
-FAIL TextMetrics interface: existence and properties of interface prototype object's "constructor" property assert_own_property: self does not have own property "TextMetrics" expected property "TextMetrics" missing
-FAIL TextMetrics interface: existence and properties of interface prototype object's @@unscopables property assert_own_property: self does not have own property "TextMetrics" expected property "TextMetrics" missing
-FAIL TextMetrics interface: attribute width assert_own_property: self does not have own property "TextMetrics" expected property "TextMetrics" missing
-FAIL TextMetrics interface: attribute actualBoundingBoxLeft assert_own_property: self does not have own property "TextMetrics" expected property "TextMetrics" missing
-FAIL TextMetrics interface: attribute actualBoundingBoxRight assert_own_property: self does not have own property "TextMetrics" expected property "TextMetrics" missing
-FAIL TextMetrics interface: attribute fontBoundingBoxAscent assert_own_property: self does not have own property "TextMetrics" expected property "TextMetrics" missing
-FAIL TextMetrics interface: attribute fontBoundingBoxDescent assert_own_property: self does not have own property "TextMetrics" expected property "TextMetrics" missing
-FAIL TextMetrics interface: attribute actualBoundingBoxAscent assert_own_property: self does not have own property "TextMetrics" expected property "TextMetrics" missing
-FAIL TextMetrics interface: attribute actualBoundingBoxDescent assert_own_property: self does not have own property "TextMetrics" expected property "TextMetrics" missing
-FAIL TextMetrics interface: attribute emHeightAscent assert_own_property: self does not have own property "TextMetrics" expected property "TextMetrics" missing
-FAIL TextMetrics interface: attribute emHeightDescent assert_own_property: self does not have own property "TextMetrics" expected property "TextMetrics" missing
-FAIL TextMetrics interface: attribute hangingBaseline assert_own_property: self does not have own property "TextMetrics" expected property "TextMetrics" missing
-FAIL TextMetrics interface: attribute alphabeticBaseline assert_own_property: self does not have own property "TextMetrics" expected property "TextMetrics" missing
-FAIL TextMetrics interface: attribute ideographicBaseline assert_own_property: self does not have own property "TextMetrics" expected property "TextMetrics" missing
+PASS TextMetrics interface: existence and properties of interface object
+PASS TextMetrics interface object length
+PASS TextMetrics interface object name
+PASS TextMetrics interface: existence and properties of interface prototype object
+PASS TextMetrics interface: existence and properties of interface prototype object's "constructor" property
+PASS TextMetrics interface: existence and properties of interface prototype object's @@unscopables property
+PASS TextMetrics interface: attribute width
+PASS TextMetrics interface: attribute actualBoundingBoxLeft
+PASS TextMetrics interface: attribute actualBoundingBoxRight
+PASS TextMetrics interface: attribute fontBoundingBoxAscent
+PASS TextMetrics interface: attribute fontBoundingBoxDescent
+PASS TextMetrics interface: attribute actualBoundingBoxAscent
+PASS TextMetrics interface: attribute actualBoundingBoxDescent
+PASS TextMetrics interface: attribute emHeightAscent
+PASS TextMetrics interface: attribute emHeightDescent
+PASS TextMetrics interface: attribute hangingBaseline
+PASS TextMetrics interface: attribute alphabeticBaseline
+PASS TextMetrics interface: attribute ideographicBaseline
PASS ImageData interface: existence and properties of interface object
PASS ImageData interface object length
PASS ImageData interface object name
@@ -308,14 +308,14 @@
PASS Path2D interface: operation rect(unrestricted double, unrestricted double, unrestricted double, unrestricted double)
PASS Path2D interface: operation arc(unrestricted double, unrestricted double, unrestricted double, unrestricted double, unrestricted double, optional boolean)
PASS Path2D interface: operation ellipse(unrestricted double, unrestricted double, unrestricted double, unrestricted double, unrestricted double, unrestricted double, unrestricted double, optional boolean)
-FAIL ImageBitmapRenderingContext interface: existence and properties of interface object assert_own_property: self does not have own property "ImageBitmapRenderingContext" expected property "ImageBitmapRenderingContext" missing
-FAIL ImageBitmapRenderingContext interface object length assert_own_property: self does not have own property "ImageBitmapRenderingContext" expected property "ImageBitmapRenderingContext" missing
-FAIL ImageBitmapRenderingContext interface object name assert_own_property: self does not have own property "ImageBitmapRenderingContext" expected property "ImageBitmapRenderingContext" missing
-FAIL ImageBitmapRenderingContext interface: existence and properties of interface prototype object assert_own_property: self does not have own property "ImageBitmapRenderingContext" expected property "ImageBitmapRenderingContext" missing
-FAIL ImageBitmapRenderingContext interface: existence and properties of interface prototype object's "constructor" property assert_own_property: self does not have own property "ImageBitmapRenderingContext" expected property "ImageBitmapRenderingContext" missing
-FAIL ImageBitmapRenderingContext interface: existence and properties of interface prototype object's @@unscopables property assert_own_property: self does not have own property "ImageBitmapRenderingContext" expected property "ImageBitmapRenderingContext" missing
-FAIL ImageBitmapRenderingContext interface: attribute canvas assert_own_property: self does not have own property "ImageBitmapRenderingContext" expected property "ImageBitmapRenderingContext" missing
-FAIL ImageBitmapRenderingContext interface: operation transferFromImageBitmap(ImageBitmap?) assert_own_property: self does not have own property "ImageBitmapRenderingContext" expected property "ImageBitmapRenderingContext" missing
+PASS ImageBitmapRenderingContext interface: existence and properties of interface object
+PASS ImageBitmapRenderingContext interface object length
+PASS ImageBitmapRenderingContext interface object name
+PASS ImageBitmapRenderingContext interface: existence and properties of interface prototype object
+PASS ImageBitmapRenderingContext interface: existence and properties of interface prototype object's "constructor" property
+PASS ImageBitmapRenderingContext interface: existence and properties of interface prototype object's @@unscopables property
+PASS ImageBitmapRenderingContext interface: attribute canvas
+PASS ImageBitmapRenderingContext interface: operation transferFromImageBitmap(ImageBitmap?)
FAIL OffscreenCanvas interface: existence and properties of interface object assert_own_property: self does not have own property "OffscreenCanvas" expected property "OffscreenCanvas" missing
FAIL OffscreenCanvas interface object length assert_own_property: self does not have own property "OffscreenCanvas" expected property "OffscreenCanvas" missing
FAIL OffscreenCanvas interface object name assert_own_property: self does not have own property "OffscreenCanvas" expected property "OffscreenCanvas" missing
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/workers/semantics/interface-objects/001.worker-expected.txt (269475 => 269476)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/workers/semantics/interface-objects/001.worker-expected.txt 2020-11-05 22:22:01 UTC (rev 269475)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/workers/semantics/interface-objects/001.worker-expected.txt 2020-11-05 22:39:40 UTC (rev 269476)
@@ -13,7 +13,7 @@
PASS The CanvasGradient interface object should be exposed.
PASS The CanvasPattern interface object should be exposed.
FAIL The CanvasPath interface object should be exposed. assert_own_property: expected property "CanvasPath" missing
-FAIL The TextMetrics interface object should be exposed. assert_own_property: expected property "TextMetrics" missing
+PASS The TextMetrics interface object should be exposed.
PASS The Path2D interface object should be exposed.
PASS The PromiseRejectionEvent interface object should be exposed.
PASS The EventSource interface object should be exposed.
Modified: trunk/Source/WebCore/ChangeLog (269475 => 269476)
--- trunk/Source/WebCore/ChangeLog 2020-11-05 22:22:01 UTC (rev 269475)
+++ trunk/Source/WebCore/ChangeLog 2020-11-05 22:39:40 UTC (rev 269476)
@@ -1,5 +1,23 @@
2020-11-05 Chris Dumez <[email protected]>
+ DOMStringList, TextMetrics & ImageBitmapRenderingContext should be exposed to workers
+ https://bugs.webkit.org/show_bug.cgi?id=218631
+
+ Reviewed by Geoffrey Garen.
+
+ DOMStringList, TextMetrics & ImageBitmapRenderingContext should be exposed to workers:
+ - https://html.spec.whatwg.org/multipage/common-dom-interfaces.html#domstringlist
+ - https://html.spec.whatwg.org/multipage/canvas.html#textmetrics
+ - https://html.spec.whatwg.org/multipage/canvas.html#imagebitmaprenderingcontext
+
+ No new tests, rebaselined existing test.
+
+ * dom/DOMStringList.idl:
+ * html/TextMetrics.idl:
+ * html/canvas/ImageBitmapRenderingContext.idl:
+
+2020-11-05 Chris Dumez <[email protected]>
+
Crash in AudioBuffer::sampleRate()
https://bugs.webkit.org/show_bug.cgi?id=218603
Modified: trunk/Source/WebCore/dom/DOMStringList.idl (269475 => 269476)
--- trunk/Source/WebCore/dom/DOMStringList.idl 2020-11-05 22:22:01 UTC (rev 269475)
+++ trunk/Source/WebCore/dom/DOMStringList.idl 2020-11-05 22:39:40 UTC (rev 269476)
@@ -25,7 +25,7 @@
[
ImplementationLacksVTable,
- Exposed=Window
+ Exposed=(Window,Worker)
] interface DOMStringList {
readonly attribute unsigned long length;
getter DOMString? item(unsigned long index);
Modified: trunk/Source/WebCore/html/TextMetrics.idl (269475 => 269476)
--- trunk/Source/WebCore/html/TextMetrics.idl 2020-11-05 22:22:01 UTC (rev 269475)
+++ trunk/Source/WebCore/html/TextMetrics.idl 2020-11-05 22:39:40 UTC (rev 269476)
@@ -24,7 +24,7 @@
*/
[
- Exposed=Window,
+ Exposed=(Window,Worker),
ImplementationLacksVTable,
] interface TextMetrics {
// FIXME: All the unrestricted float attributes below should be doubles.
Modified: trunk/Source/WebCore/html/canvas/ImageBitmapRenderingContext.idl (269475 => 269476)
--- trunk/Source/WebCore/html/canvas/ImageBitmapRenderingContext.idl 2020-11-05 22:22:01 UTC (rev 269475)
+++ trunk/Source/WebCore/html/canvas/ImageBitmapRenderingContext.idl 2020-11-05 22:39:40 UTC (rev 269476)
@@ -25,7 +25,7 @@
[
EnabledAtRuntime=ImageBitmap,
- Exposed=Window,
+ Exposed=(Window,Worker),
CallTracingCallback=recordCanvasAction,
] interface ImageBitmapRenderingContext {
readonly attribute HTMLCanvasElement canvas;
