Title: [269527] trunk/Source/WebCore
- Revision
- 269527
- Author
- [email protected]
- Date
- 2020-11-06 11:37:33 -0800 (Fri, 06 Nov 2020)
Log Message
Accelerated animations of individual transform properties should apply rotate before scale
https://bugs.webkit.org/show_bug.cgi?id=218659
Reviewed by Simon Fraser.
Not that applying scale before rotate makes any difference, but applying the operations in
the order specified in the CSS Transforms spec will make the code easier to understand between
this and RenderStyle::applyTransform().
No test since there is no change of behavior.
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::updateAnimations):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (269526 => 269527)
--- trunk/Source/WebCore/ChangeLog 2020-11-06 19:29:32 UTC (rev 269526)
+++ trunk/Source/WebCore/ChangeLog 2020-11-06 19:37:33 UTC (rev 269527)
@@ -1,3 +1,19 @@
+2020-11-06 Antoine Quint <[email protected]>
+
+ Accelerated animations of individual transform properties should apply rotate before scale
+ https://bugs.webkit.org/show_bug.cgi?id=218659
+
+ Reviewed by Simon Fraser.
+
+ Not that applying scale before rotate makes any difference, but applying the operations in
+ the order specified in the CSS Transforms spec will make the code easier to understand between
+ this and RenderStyle::applyTransform().
+
+ No test since there is no change of behavior.
+
+ * platform/graphics/ca/GraphicsLayerCA.cpp:
+ (WebCore::GraphicsLayerCA::updateAnimations):
+
2020-11-06 Wenson Hsieh <[email protected]>
[Concurrent display lists] Encode display list items directly into shared memory
Modified: trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp (269526 => 269527)
--- trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp 2020-11-06 19:29:32 UTC (rev 269526)
+++ trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp 2020-11-06 19:37:33 UTC (rev 269527)
@@ -3001,16 +3001,16 @@
else
addBaseValueTransformAnimation(AnimatedPropertyTranslate);
+ if (rotateAnimation)
+ addAnimation(*rotateAnimation);
+ else
+ addBaseValueTransformAnimation(AnimatedPropertyRotate);
+
if (scaleAnimation)
addAnimation(*scaleAnimation);
else
addBaseValueTransformAnimation(AnimatedPropertyScale);
- if (rotateAnimation)
- addAnimation(*rotateAnimation);
- else
- addBaseValueTransformAnimation(AnimatedPropertyRotate);
-
for (auto* animation : transformAnimations)
addAnimation(*animation);
if (transformAnimations.isEmpty())
@@ -3021,16 +3021,16 @@
if (transformAnimations.isEmpty())
addBaseValueTransformAnimation(AnimatedPropertyTransform);
+ if (scaleAnimation)
+ addAnimation(*scaleAnimation);
+ else
+ addBaseValueTransformAnimation(AnimatedPropertyScale);
+
if (rotateAnimation)
addAnimation(*rotateAnimation);
else
addBaseValueTransformAnimation(AnimatedPropertyRotate);
- if (scaleAnimation)
- addAnimation(*scaleAnimation);
- else
- addBaseValueTransformAnimation(AnimatedPropertyScale);
-
if (translateAnimation)
addAnimation(*translateAnimation);
else
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
