Title: [269532] trunk/LayoutTests
- Revision
- 269532
- Author
- [email protected]
- Date
- 2020-11-06 12:29:19 -0800 (Fri, 06 Nov 2020)
Log Message
Web Inspector: use weak collections for holding event listeners
https://bugs.webkit.org/show_bug.cgi?id=196956
Patch by Devin Rousso <[email protected]> on 2020-11-06
Reviewed by Joseph Pecoraro.
* inspector/unit-tests/heap-snapshot-collection-event.html:
Followup from r269359 which replaced the string literal `"HeapSnapshot.CollectionEvent"`
with a defined `WI.HeapSnapshotWorkerProxy.Event.Collection` value.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (269531 => 269532)
--- trunk/LayoutTests/ChangeLog 2020-11-06 20:23:25 UTC (rev 269531)
+++ trunk/LayoutTests/ChangeLog 2020-11-06 20:29:19 UTC (rev 269532)
@@ -1,3 +1,14 @@
+2020-11-06 Devin Rousso <[email protected]>
+
+ Web Inspector: use weak collections for holding event listeners
+ https://bugs.webkit.org/show_bug.cgi?id=196956
+
+ Reviewed by Joseph Pecoraro.
+
+ * inspector/unit-tests/heap-snapshot-collection-event.html:
+ Followup from r269359 which replaced the string literal `"HeapSnapshot.CollectionEvent"`
+ with a defined `WI.HeapSnapshotWorkerProxy.Event.Collection` value.
+
2020-11-06 Yusuke Suzuki <[email protected]>
Re-enable SharedArrayBuffer for JSC shell and Testers
Modified: trunk/LayoutTests/inspector/unit-tests/heap-snapshot-collection-event.html (269531 => 269532)
--- trunk/LayoutTests/inspector/unit-tests/heap-snapshot-collection-event.html 2020-11-06 20:23:25 UTC (rev 269531)
+++ trunk/LayoutTests/inspector/unit-tests/heap-snapshot-collection-event.html 2020-11-06 20:29:19 UTC (rev 269532)
@@ -48,7 +48,7 @@
});
});
- workerProxy.addEventListener("HeapSnapshot.CollectionEvent", (event) => {
+ workerProxy.addEventListener(WI.HeapSnapshotWorkerProxy.Event.Collection, (event) => {
InspectorTest.pass("Received HeapSnapshot.CollectionEvent.");
InspectorTest.expectThat(Object.keys(event.data.collectedNodes).length >= 200, "Collection should include at least 200 nodes (100 objects and 100 strings).");
InspectorTest.expectThat(event.data.affectedSnapshots.includes(snapshot.identifier), "Collection should affect the first snapshot.");
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
