Title: [105154] trunk/Source/WebCore
- Revision
- 105154
- Author
- [email protected]
- Date
- 2012-01-17 07:29:37 -0800 (Tue, 17 Jan 2012)
Log Message
Web Inspector: ConsoleMessage.cpp and InspectorResourceAgent.cpp doesn't conform to Inspector.json
https://bugs.webkit.org/show_bug.cgi?id=76403
A couple of protocol fixes.
Reviewed by Pavel Feldman.
* inspector/ConsoleMessage.cpp: return 'log' in case some unsupported value is passed.
We cannot omit that return statement as GCC would complain on missing return statement
despite all enum values are listed.
(WebCore::messageTypeValue):
* inspector/Inspector-0.1.json: fixed v0.1 protocol definition.
* inspector/Inspector.json: made CachedResource.response field optional.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (105153 => 105154)
--- trunk/Source/WebCore/ChangeLog 2012-01-17 15:03:35 UTC (rev 105153)
+++ trunk/Source/WebCore/ChangeLog 2012-01-17 15:29:37 UTC (rev 105154)
@@ -1,3 +1,19 @@
+2012-01-17 Yury Semikhatsky <[email protected]>
+
+ Web Inspector: ConsoleMessage.cpp and InspectorResourceAgent.cpp doesn't conform to Inspector.json
+ https://bugs.webkit.org/show_bug.cgi?id=76403
+
+ A couple of protocol fixes.
+
+ Reviewed by Pavel Feldman.
+
+ * inspector/ConsoleMessage.cpp: return 'log' in case some unsupported value is passed.
+ We cannot omit that return statement as GCC would complain on missing return statement
+ despite all enum values are listed.
+ (WebCore::messageTypeValue):
+ * inspector/Inspector-0.1.json: fixed v0.1 protocol definition.
+ * inspector/Inspector.json: made CachedResource.response field optional.
+
2012-01-17 Ilya Tikhonovsky <[email protected]>
[Chromium] Web Inspector: remove "Document DOM tree" class and "Detached DOM tree" from the Summary view.
Modified: trunk/Source/WebCore/inspector/ConsoleMessage.cpp (105153 => 105154)
--- trunk/Source/WebCore/inspector/ConsoleMessage.cpp 2012-01-17 15:03:35 UTC (rev 105153)
+++ trunk/Source/WebCore/inspector/ConsoleMessage.cpp 2012-01-17 15:29:37 UTC (rev 105154)
@@ -118,7 +118,7 @@
case EndGroupMessageType: return "endGroup";
case AssertMessageType: return "assert";
}
- return "other";
+ return "log";
}
static String messageLevelValue(MessageLevel level)
Modified: trunk/Source/WebCore/inspector/Inspector-0.1.json (105153 => 105154)
--- trunk/Source/WebCore/inspector/Inspector-0.1.json 2012-01-17 15:03:35 UTC (rev 105153)
+++ trunk/Source/WebCore/inspector/Inspector-0.1.json 2012-01-17 15:29:37 UTC (rev 105154)
@@ -514,7 +514,7 @@
"properties": [
{ "name": "url", "type": "string", "description": "Resource URL." },
{ "name": "type", "$ref": "Page.ResourceType", "description": "Type of this resource." },
- { "name": "response", "$ref": "Response", "description": "Cached response data." },
+ { "name": "response", "$ref": "Response", "optional": true, "description": "Cached response data." },
{ "name": "bodySize", "type": "number", "description": "Cached response body size." }
]
},
Modified: trunk/Source/WebCore/inspector/Inspector.json (105153 => 105154)
--- trunk/Source/WebCore/inspector/Inspector.json 2012-01-17 15:03:35 UTC (rev 105153)
+++ trunk/Source/WebCore/inspector/Inspector.json 2012-01-17 15:29:37 UTC (rev 105154)
@@ -629,7 +629,7 @@
"properties": [
{ "name": "url", "type": "string", "description": "Resource URL." },
{ "name": "type", "$ref": "Page.ResourceType", "description": "Type of this resource." },
- { "name": "response", "$ref": "Response", "description": "Cached response data." },
+ { "name": "response", "$ref": "Response", "optional": true, "description": "Cached response data." },
{ "name": "bodySize", "type": "number", "description": "Cached response body size." }
]
},
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
