Title: [105162] trunk/Tools
- Revision
- 105162
- Author
- [email protected]
- Date
- 2012-01-17 08:11:50 -0800 (Tue, 17 Jan 2012)
Log Message
REGRESSION(r81225): ORWT should ignore reftests
https://bugs.webkit.org/show_bug.cgi?id=67936
Patch by Balazs Ankes <[email protected]> on 2012-01-17
Reviewed by Csaba Osztrogonác.
* Scripts/old-run-webkit-tests:
(isUsedInReftest): $filename should be the first parameter
(findTestsToRun): run test if it isn't reftest
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (105161 => 105162)
--- trunk/Tools/ChangeLog 2012-01-17 16:03:12 UTC (rev 105161)
+++ trunk/Tools/ChangeLog 2012-01-17 16:11:50 UTC (rev 105162)
@@ -1,3 +1,14 @@
+2012-01-17 Balazs Ankes <[email protected]>
+
+ REGRESSION(r81225): ORWT should ignore reftests
+ https://bugs.webkit.org/show_bug.cgi?id=67936
+
+ Reviewed by Csaba Osztrogonác.
+
+ * Scripts/old-run-webkit-tests:
+ (isUsedInReftest): $filename should be the first parameter
+ (findTestsToRun): run test if it isn't reftest
+
2012-01-17 Gustavo Noronha Silva <[email protected]>
Unreviewed. Fix python unit test I broke with r105142
Modified: trunk/Tools/Scripts/old-run-webkit-tests (105161 => 105162)
--- trunk/Tools/Scripts/old-run-webkit-tests 2012-01-17 16:03:12 UTC (rev 105161)
+++ trunk/Tools/Scripts/old-run-webkit-tests 2012-01-17 16:11:50 UTC (rev 105162)
@@ -2577,9 +2577,9 @@
my @testsFound;
-sub isUsedInReftest
+sub isUsedInReftest($)
{
- my $filename = $_;
+ my $filename = $_[0];
if ($filename =~ /-$expectedTag(-$mismatchTag)?\.html$/) {
return 1;
}
@@ -2615,7 +2615,7 @@
my $fullPath = catfile($testDirectory, $test);
if (file_name_is_absolute($test)) {
print "can't run test $test outside $testDirectory\n";
- } elsif (-f $fullPath) {
+ } elsif (-f $fullPath && !isUsedInReftest($fullPath)) {
my ($filename, $pathname, $fileExtension) = fileparse($test, qr{\.[^.]+$});
if (!exists $supportedFileExtensions{substr($fileExtension, 1)}) {
print "test $test does not have a supported extension\n";
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
