Title: [269758] trunk/Source/WebKit
Revision
269758
Author
[email protected]
Date
2020-11-12 15:45:06 -0800 (Thu, 12 Nov 2020)

Log Message

canvas-createPattern-video-modify-crash-log.txt asserts on debug GPUProcess bots
https://bugs.webkit.org/show_bug.cgi?id=218872

Reviewed by Simon Fraser.

* WebProcess/GPU/graphics/ImageBufferShareableBitmapBackend.cpp:
(WebKit::ImageBufferShareableBitmapBackend::create):
This assertion is wrong; make it the same as the one in ImageBufferCGBitmapBackend.

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (269757 => 269758)


--- trunk/Source/WebKit/ChangeLog	2020-11-12 22:54:19 UTC (rev 269757)
+++ trunk/Source/WebKit/ChangeLog	2020-11-12 23:45:06 UTC (rev 269758)
@@ -1,3 +1,14 @@
+2020-11-12  Tim Horton  <[email protected]>
+
+        canvas-createPattern-video-modify-crash-log.txt asserts on debug GPUProcess bots
+        https://bugs.webkit.org/show_bug.cgi?id=218872
+
+        Reviewed by Simon Fraser.
+
+        * WebProcess/GPU/graphics/ImageBufferShareableBitmapBackend.cpp:
+        (WebKit::ImageBufferShareableBitmapBackend::create):
+        This assertion is wrong; make it the same as the one in ImageBufferCGBitmapBackend.
+
 2020-11-12  Said Abou-Hallawa  <[email protected]>
 
         [GPU Process] GraphicsContext::drawPattern() should take a NativeImage argument

Modified: trunk/Source/WebKit/WebProcess/GPU/graphics/ImageBufferShareableBitmapBackend.cpp (269757 => 269758)


--- trunk/Source/WebKit/WebProcess/GPU/graphics/ImageBufferShareableBitmapBackend.cpp	2020-11-12 22:54:19 UTC (rev 269757)
+++ trunk/Source/WebKit/WebProcess/GPU/graphics/ImageBufferShareableBitmapBackend.cpp	2020-11-12 23:45:06 UTC (rev 269758)
@@ -45,7 +45,7 @@
 
 std::unique_ptr<ImageBufferShareableBitmapBackend> ImageBufferShareableBitmapBackend::create(const FloatSize& size, float resolutionScale, ColorSpace colorSpace, PixelFormat pixelFormat, const HostWindow*)
 {
-    ASSERT(pixelFormat == PixelFormat::RGBA8);
+    ASSERT(pixelFormat == PixelFormat::BGRA8);
 
     IntSize backendSize = calculateBackendSize(size, resolutionScale);
     if (backendSize.isEmpty())
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to