Title: [269782] trunk/Source/ThirdParty/libwebrtc
- Revision
- 269782
- Author
- [email protected]
- Date
- 2020-11-13 09:22:37 -0800 (Fri, 13 Nov 2020)
Log Message
Remote encoder should set its encoder frame callback to nullptr when being released
https://bugs.webkit.org/show_bug.cgi?id=218906
Reviewed by Eric Carlson.
* Source/webrtc/sdk/WebKit/WebKitEncoder.mm:
(webrtc::RemoteVideoEncoder::Release):
We need to reset the callback at Release call time so that WebKit will take a lock to set it back to null.
That way, we ensure to not call this callback while libwebrtc expects not to be called.
Modified Paths
Diff
Modified: trunk/Source/ThirdParty/libwebrtc/ChangeLog (269781 => 269782)
--- trunk/Source/ThirdParty/libwebrtc/ChangeLog 2020-11-13 17:21:17 UTC (rev 269781)
+++ trunk/Source/ThirdParty/libwebrtc/ChangeLog 2020-11-13 17:22:37 UTC (rev 269782)
@@ -1,3 +1,15 @@
+2020-11-13 Youenn Fablet <[email protected]>
+
+ Remote encoder should set its encoder frame callback to nullptr when being released
+ https://bugs.webkit.org/show_bug.cgi?id=218906
+
+ Reviewed by Eric Carlson.
+
+ * Source/webrtc/sdk/WebKit/WebKitEncoder.mm:
+ (webrtc::RemoteVideoEncoder::Release):
+ We need to reset the callback at Release call time so that WebKit will take a lock to set it back to null.
+ That way, we ensure to not call this callback while libwebrtc expects not to be called.
+
2020-11-12 Youenn Fablet <[email protected]>
Add infrastructure for WebRTC transforms
Modified: trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitEncoder.mm (269781 => 269782)
--- trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitEncoder.mm 2020-11-13 17:21:17 UTC (rev 269781)
+++ trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitEncoder.mm 2020-11-13 17:22:37 UTC (rev 269782)
@@ -248,6 +248,7 @@
int32_t RemoteVideoEncoder::Release()
{
+ RegisterEncodeCompleteCallback(nullptr);
return 0;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
