Title: [269803] trunk
- Revision
- 269803
- Author
- [email protected]
- Date
- 2020-11-13 14:56:53 -0800 (Fri, 13 Nov 2020)
Log Message
Unreviewed, reverting r269776.
The test added with this change is asserting
Reverted changeset:
"Null check anchorNode of endingSelection start"
https://bugs.webkit.org/show_bug.cgi?id=218492
https://trac.webkit.org/changeset/269776
Modified Paths
Removed Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (269802 => 269803)
--- trunk/LayoutTests/ChangeLog 2020-11-13 22:38:53 UTC (rev 269802)
+++ trunk/LayoutTests/ChangeLog 2020-11-13 22:56:53 UTC (rev 269803)
@@ -1,3 +1,15 @@
+2020-11-13 Ryan Haddad <[email protected]>
+
+ Unreviewed, reverting r269776.
+
+ The test added with this change is asserting
+
+ Reverted changeset:
+
+ "Null check anchorNode of endingSelection start"
+ https://bugs.webkit.org/show_bug.cgi?id=218492
+ https://trac.webkit.org/changeset/269776
+
2020-11-13 Sergey Rubanov <[email protected]>
WebAssembly: opcodes for table.grow and table.size are mixed up
Deleted: trunk/LayoutTests/editing/deleting/delete-contenteditable-crash-expected.txt (269802 => 269803)
--- trunk/LayoutTests/editing/deleting/delete-contenteditable-crash-expected.txt 2020-11-13 22:38:53 UTC (rev 269802)
+++ trunk/LayoutTests/editing/deleting/delete-contenteditable-crash-expected.txt 2020-11-13 22:56:53 UTC (rev 269803)
@@ -1 +0,0 @@
-Test passes if no crashes with asan.
Deleted: trunk/LayoutTests/editing/deleting/delete-contenteditable-crash.html (269802 => 269803)
--- trunk/LayoutTests/editing/deleting/delete-contenteditable-crash.html 2020-11-13 22:38:53 UTC (rev 269802)
+++ trunk/LayoutTests/editing/deleting/delete-contenteditable-crash.html 2020-11-13 22:56:53 UTC (rev 269803)
@@ -1,26 +0,0 @@
-<!DOCTYPE html>
-<html>
-<head>
-<script>
-
-function runTest()
-{
- if (window.testRunner)
- testRunner.dumpAsText();
-
- getSelection().setBaseAndExtent(span, 0, span, 2);
- document.execCommand("delete", false);
- document.write("Test passes if no crashes with asan.")
-}
-
-</script>
-</head>
-<body _onload_="runTest()">
-<li contenteditable="">
- <basefont>
- <progress contenteditable="false">
- <span id="span">content</span>
- </progress>
-</li>
-</body>
-</html>
Modified: trunk/Source/WebCore/ChangeLog (269802 => 269803)
--- trunk/Source/WebCore/ChangeLog 2020-11-13 22:38:53 UTC (rev 269802)
+++ trunk/Source/WebCore/ChangeLog 2020-11-13 22:56:53 UTC (rev 269803)
@@ -1,3 +1,15 @@
+2020-11-13 Ryan Haddad <[email protected]>
+
+ Unreviewed, reverting r269776.
+
+ The test added with this change is asserting
+
+ Reverted changeset:
+
+ "Null check anchorNode of endingSelection start"
+ https://bugs.webkit.org/show_bug.cgi?id=218492
+ https://trac.webkit.org/changeset/269776
+
2020-11-13 Geoffrey Garen <[email protected]>
Removed DeferrableTaskTimer
Modified: trunk/Source/WebCore/editing/DeleteSelectionCommand.cpp (269802 => 269803)
--- trunk/Source/WebCore/editing/DeleteSelectionCommand.cpp 2020-11-13 22:38:53 UTC (rev 269802)
+++ trunk/Source/WebCore/editing/DeleteSelectionCommand.cpp 2020-11-13 22:56:53 UTC (rev 269803)
@@ -761,7 +761,7 @@
// The endingPosition was likely clobbered by the move, so recompute it (moveParagraph selects the moved paragraph).
// FIXME (Bug 211793): endingSelection() becomes disconnected in moveParagraph
- if (auto* anchorNode = endingSelection().start().anchorNode(); anchorNode && anchorNode->isConnected())
+ if (endingSelection().start().anchorNode()->isConnected())
m_endingPosition = endingSelection().start();
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
