Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (269813 => 269814)
--- trunk/Source/_javascript_Core/ChangeLog 2020-11-14 09:01:04 UTC (rev 269813)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-11-14 10:28:55 UTC (rev 269814)
@@ -1,3 +1,20 @@
+2020-11-14 Don Olmstead <[email protected]>
+
+ [clang-tidy] Run modernize-use-override through JSC
+ https://bugs.webkit.org/show_bug.cgi?id=218916
+
+ Reviewed by Yusuke Suzuki.
+
+ * inspector/agents/InspectorAgent.h:
+ * inspector/agents/InspectorScriptProfilerAgent.h:
+ * inspector/agents/InspectorTargetAgent.h:
+ * inspector/agents/JSGlobalObjectAuditAgent.h:
+ * inspector/agents/JSGlobalObjectDebuggerAgent.h:
+ * inspector/agents/JSGlobalObjectRuntimeAgent.h:
+ * inspector/remote/socket/RemoteInspectorConnectionClient.h:
+ * inspector/remote/socket/RemoteInspectorServer.h:
+ * runtime/JSGlobalObjectDebuggable.h:
+
2020-11-13 Xan López <[email protected]>
[JSC] Use symbols as identifiers for class fields computed names storage
Modified: trunk/Source/_javascript_Core/inspector/agents/InspectorAgent.h (269813 => 269814)
--- trunk/Source/_javascript_Core/inspector/agents/InspectorAgent.h 2020-11-14 09:01:04 UTC (rev 269813)
+++ trunk/Source/_javascript_Core/inspector/agents/InspectorAgent.h 2020-11-14 10:28:55 UTC (rev 269814)
@@ -45,16 +45,16 @@
WTF_MAKE_FAST_ALLOCATED;
public:
InspectorAgent(AgentContext&);
- ~InspectorAgent();
+ ~InspectorAgent() final;
// InspectorAgentBase
- void didCreateFrontendAndBackend(FrontendRouter*, BackendDispatcher*);
- void willDestroyFrontendAndBackend(DisconnectReason);
+ void didCreateFrontendAndBackend(FrontendRouter*, BackendDispatcher*) final;
+ void willDestroyFrontendAndBackend(DisconnectReason) final;
// InspectorBackendDispatcherHandler
- Protocol::ErrorStringOr<void> enable();
- Protocol::ErrorStringOr<void> disable();
- Protocol::ErrorStringOr<void> initialized();
+ Protocol::ErrorStringOr<void> enable() final;
+ Protocol::ErrorStringOr<void> disable() final;
+ Protocol::ErrorStringOr<void> initialized() final;
// CommandLineAPI
void inspect(Ref<Protocol::Runtime::RemoteObject>&&, Ref<JSON::Object>&& hints);
Modified: trunk/Source/_javascript_Core/inspector/agents/InspectorScriptProfilerAgent.h (269813 => 269814)
--- trunk/Source/_javascript_Core/inspector/agents/InspectorScriptProfilerAgent.h 2020-11-14 09:01:04 UTC (rev 269813)
+++ trunk/Source/_javascript_Core/inspector/agents/InspectorScriptProfilerAgent.h 2020-11-14 10:28:55 UTC (rev 269814)
@@ -42,20 +42,20 @@
WTF_MAKE_FAST_ALLOCATED;
public:
InspectorScriptProfilerAgent(AgentContext&);
- ~InspectorScriptProfilerAgent();
+ ~InspectorScriptProfilerAgent() final;
// InspectorAgentBase
- void didCreateFrontendAndBackend(FrontendRouter*, BackendDispatcher*);
- void willDestroyFrontendAndBackend(DisconnectReason);
+ void didCreateFrontendAndBackend(FrontendRouter*, BackendDispatcher*) final;
+ void willDestroyFrontendAndBackend(DisconnectReason) final;
// ScriptProfilerBackendDispatcherHandler
- Protocol::ErrorStringOr<void> startTracking(Optional<bool>&& includeSamples);
- Protocol::ErrorStringOr<void> stopTracking();
+ Protocol::ErrorStringOr<void> startTracking(Optional<bool>&& includeSamples) final;
+ Protocol::ErrorStringOr<void> stopTracking() final;
// JSC::Debugger::ProfilingClient
- bool isAlreadyProfiling() const;
- Seconds willEvaluateScript();
- void didEvaluateScript(Seconds, JSC::ProfilingReason);
+ bool isAlreadyProfiling() const final;
+ Seconds willEvaluateScript() final;
+ void didEvaluateScript(Seconds, JSC::ProfilingReason) final;
private:
void addEvent(Seconds startTime, Seconds endTime, JSC::ProfilingReason);
Modified: trunk/Source/_javascript_Core/inspector/agents/InspectorTargetAgent.h (269813 => 269814)
--- trunk/Source/_javascript_Core/inspector/agents/InspectorTargetAgent.h 2020-11-14 09:01:04 UTC (rev 269813)
+++ trunk/Source/_javascript_Core/inspector/agents/InspectorTargetAgent.h 2020-11-14 10:28:55 UTC (rev 269814)
@@ -40,16 +40,16 @@
WTF_MAKE_FAST_ALLOCATED;
public:
InspectorTargetAgent(FrontendRouter&, BackendDispatcher&);
- ~InspectorTargetAgent();
+ ~InspectorTargetAgent() final;
// InspectorAgentBase
- void didCreateFrontendAndBackend(FrontendRouter*, BackendDispatcher*);
- void willDestroyFrontendAndBackend(DisconnectReason);
+ void didCreateFrontendAndBackend(FrontendRouter*, BackendDispatcher*) final;
+ void willDestroyFrontendAndBackend(DisconnectReason) final;
// TargetBackendDispatcherHandler
- Protocol::ErrorStringOr<void> setPauseOnStart(bool);
- Protocol::ErrorStringOr<void> resume(const String& targetId);
- Protocol::ErrorStringOr<void> sendMessageToTarget(const String& targetId, const String& message);
+ Protocol::ErrorStringOr<void> setPauseOnStart(bool) final;
+ Protocol::ErrorStringOr<void> resume(const String& targetId) final;
+ Protocol::ErrorStringOr<void> sendMessageToTarget(const String& targetId, const String& message) final;
// Target lifecycle.
void targetCreated(InspectorTarget&);
Modified: trunk/Source/_javascript_Core/inspector/agents/JSGlobalObjectAuditAgent.h (269813 => 269814)
--- trunk/Source/_javascript_Core/inspector/agents/JSGlobalObjectAuditAgent.h 2020-11-14 09:01:04 UTC (rev 269813)
+++ trunk/Source/_javascript_Core/inspector/agents/JSGlobalObjectAuditAgent.h 2020-11-14 10:28:55 UTC (rev 269814)
@@ -38,10 +38,10 @@
WTF_MAKE_FAST_ALLOCATED;
public:
JSGlobalObjectAuditAgent(JSAgentContext&);
- ~JSGlobalObjectAuditAgent();
+ ~JSGlobalObjectAuditAgent() final;
private:
- InjectedScript injectedScriptForEval(Protocol::ErrorString&, Optional<Protocol::Runtime::ExecutionContextId>&&);
+ InjectedScript injectedScriptForEval(Protocol::ErrorString&, Optional<Protocol::Runtime::ExecutionContextId>&&) final;
JSC::JSGlobalObject& m_globalObject;
};
Modified: trunk/Source/_javascript_Core/inspector/agents/JSGlobalObjectDebuggerAgent.h (269813 => 269814)
--- trunk/Source/_javascript_Core/inspector/agents/JSGlobalObjectDebuggerAgent.h 2020-11-14 09:01:04 UTC (rev 269813)
+++ trunk/Source/_javascript_Core/inspector/agents/JSGlobalObjectDebuggerAgent.h 2020-11-14 10:28:55 UTC (rev 269814)
@@ -36,18 +36,18 @@
WTF_MAKE_FAST_ALLOCATED;
public:
JSGlobalObjectDebuggerAgent(JSAgentContext&, InspectorConsoleAgent*);
- ~JSGlobalObjectDebuggerAgent();
+ ~JSGlobalObjectDebuggerAgent() final;
// JSC::Debugger::Observer
- void breakpointActionLog(JSC::JSGlobalObject*, const String& data);
+ void breakpointActionLog(JSC::JSGlobalObject*, const String& data) final;
private:
- InjectedScript injectedScriptForEval(Protocol::ErrorString&, Optional<Protocol::Runtime::ExecutionContextId>&&);
+ InjectedScript injectedScriptForEval(Protocol::ErrorString&, Optional<Protocol::Runtime::ExecutionContextId>&&) final;
// NOTE: _javascript_ inspector does not yet need to mute a console because no messages
// are sent to the console outside of the API boundary or console object.
- void muteConsole() { }
- void unmuteConsole() { }
+ void muteConsole() final { }
+ void unmuteConsole() final { }
InspectorConsoleAgent* m_consoleAgent { nullptr };
};
Modified: trunk/Source/_javascript_Core/inspector/agents/JSGlobalObjectRuntimeAgent.h (269813 => 269814)
--- trunk/Source/_javascript_Core/inspector/agents/JSGlobalObjectRuntimeAgent.h 2020-11-14 09:01:04 UTC (rev 269813)
+++ trunk/Source/_javascript_Core/inspector/agents/JSGlobalObjectRuntimeAgent.h 2020-11-14 10:28:55 UTC (rev 269814)
@@ -39,15 +39,15 @@
WTF_MAKE_FAST_ALLOCATED;
public:
JSGlobalObjectRuntimeAgent(JSAgentContext&);
- ~JSGlobalObjectRuntimeAgent();
+ ~JSGlobalObjectRuntimeAgent() final;
private:
- InjectedScript injectedScriptForEval(Protocol::ErrorString&, Optional<Protocol::Runtime::ExecutionContextId>&&);
+ InjectedScript injectedScriptForEval(Protocol::ErrorString&, Optional<Protocol::Runtime::ExecutionContextId>&&) final;
// NOTE: _javascript_ inspector does not yet need to mute a console because no messages
// are sent to the console outside of the API boundary or console object.
- void muteConsole() { }
- void unmuteConsole() { }
+ void muteConsole() final { }
+ void unmuteConsole() final { }
std::unique_ptr<RuntimeFrontendDispatcher> m_frontendDispatcher;
RefPtr<RuntimeBackendDispatcher> m_backendDispatcher;
Modified: trunk/Source/_javascript_Core/inspector/remote/socket/RemoteInspectorConnectionClient.h (269813 => 269814)
--- trunk/Source/_javascript_Core/inspector/remote/socket/RemoteInspectorConnectionClient.h 2020-11-14 09:01:04 UTC (rev 269813)
+++ trunk/Source/_javascript_Core/inspector/remote/socket/RemoteInspectorConnectionClient.h 2020-11-14 10:28:55 UTC (rev 269814)
@@ -41,7 +41,7 @@
class JS_EXPORT_PRIVATE RemoteInspectorConnectionClient : public RemoteInspectorSocketEndpoint::Client {
public:
- virtual ~RemoteInspectorConnectionClient();
+ ~RemoteInspectorConnectionClient() override;
Optional<ConnectionID> connectInet(const char* serverAddr, uint16_t serverPort);
Optional<ConnectionID> createClient(PlatformSocketType);
Modified: trunk/Source/_javascript_Core/inspector/remote/socket/RemoteInspectorServer.h (269813 => 269814)
--- trunk/Source/_javascript_Core/inspector/remote/socket/RemoteInspectorServer.h 2020-11-14 09:01:04 UTC (rev 269813)
+++ trunk/Source/_javascript_Core/inspector/remote/socket/RemoteInspectorServer.h 2020-11-14 10:28:55 UTC (rev 269814)
@@ -34,7 +34,7 @@
class RemoteInspectorServer final : public RemoteInspectorSocketEndpoint::Listener {
public:
- ~RemoteInspectorServer();
+ ~RemoteInspectorServer() final;
JS_EXPORT_PRIVATE static RemoteInspectorServer& singleton();
Modified: trunk/Source/_javascript_Core/runtime/JSGlobalObjectDebuggable.h (269813 => 269814)
--- trunk/Source/_javascript_Core/runtime/JSGlobalObjectDebuggable.h 2020-11-14 09:01:04 UTC (rev 269813)
+++ trunk/Source/_javascript_Core/runtime/JSGlobalObjectDebuggable.h 2020-11-14 10:28:55 UTC (rev 269814)
@@ -44,7 +44,7 @@
WTF_MAKE_NONCOPYABLE(JSGlobalObjectDebuggable);
public:
JSGlobalObjectDebuggable(JSGlobalObject&);
- ~JSGlobalObjectDebuggable() { }
+ ~JSGlobalObjectDebuggable() final { }
Inspector::RemoteControllableTarget::Type type() const final { return m_type; }
void setIsITML() { m_type = Inspector::RemoteControllableTarget::Type::ITML; }
Modified: trunk/Source/WTF/ChangeLog (269813 => 269814)
--- trunk/Source/WTF/ChangeLog 2020-11-14 09:01:04 UTC (rev 269813)
+++ trunk/Source/WTF/ChangeLog 2020-11-14 10:28:55 UTC (rev 269814)
@@ -1,3 +1,12 @@
+2020-11-14 Don Olmstead <[email protected]>
+
+ [clang-tidy] Run modernize-use-override through JSC
+ https://bugs.webkit.org/show_bug.cgi?id=218916
+
+ Reviewed by Yusuke Suzuki.
+
+ * wtf/RunLoop.h:
+
2020-11-13 Sihui Liu <[email protected]>
Implement basic permission check for SpeechRecognition
Modified: trunk/Source/WTF/wtf/RunLoop.h (269813 => 269814)
--- trunk/Source/WTF/wtf/RunLoop.h 2020-11-14 09:01:04 UTC (rev 269813)
+++ trunk/Source/WTF/wtf/RunLoop.h 2020-11-14 10:28:55 UTC (rev 269814)
@@ -82,7 +82,7 @@
WTF_EXPORT_PRIVATE static bool isMain();
~RunLoop() final;
- WTF_EXPORT_PRIVATE void dispatch(Function<void()>&&);
+ WTF_EXPORT_PRIVATE void dispatch(Function<void()>&&) final;
WTF_EXPORT_PRIVATE void dispatchAfter(Seconds, Function<void()>&&);
#if USE(COCOA_EVENT_LOOP)
WTF_EXPORT_PRIVATE static void dispatch(const SchedulePairHashSet&, Function<void()>&&);
