Title: [269836] trunk/Source/WebCore
- Revision
- 269836
- Author
- [email protected]
- Date
- 2020-11-15 20:53:16 -0800 (Sun, 15 Nov 2020)
Log Message
[LFC][Integration] Disable modern line layout for fieldset children.
https://bugs.webkit.org/show_bug.cgi?id=218963
Reviewed by Sam Weinig.
Fieldsets don't follow the standard CSS box model. They require special handling.
* layout/integration/LayoutIntegrationCoverage.cpp:
(WebCore::LayoutIntegration::canUseForChild):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (269835 => 269836)
--- trunk/Source/WebCore/ChangeLog 2020-11-16 01:15:09 UTC (rev 269835)
+++ trunk/Source/WebCore/ChangeLog 2020-11-16 04:53:16 UTC (rev 269836)
@@ -1,3 +1,15 @@
+2020-11-15 Zalan Bujtas <[email protected]>
+
+ [LFC][Integration] Disable modern line layout for fieldset children.
+ https://bugs.webkit.org/show_bug.cgi?id=218963
+
+ Reviewed by Sam Weinig.
+
+ Fieldsets don't follow the standard CSS box model. They require special handling.
+
+ * layout/integration/LayoutIntegrationCoverage.cpp:
+ (WebCore::LayoutIntegration::canUseForChild):
+
2020-11-15 Simon Fraser <[email protected]>
Minor RenderStyle boxShadow cleanup
Modified: trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp (269835 => 269836)
--- trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp 2020-11-16 01:15:09 UTC (rev 269835)
+++ trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp 2020-11-16 04:53:16 UTC (rev 269836)
@@ -574,6 +574,11 @@
if (is<RenderLineBreak>(child))
return reasons;
+ if (child.isFieldset()) {
+ // Fieldsets don't follow the standard CSS box model. They require special handling.
+ SET_REASON_AND_RETURN_IF_NEEDED(FlowHasNonSupportedChild, reasons, includeReasons)
+ }
+
#if ALLOW_IMAGES || ALLOW_ALL_REPLACED
if (is<RenderReplaced>(child)) {
auto& replaced = downcast<RenderReplaced>(child);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
