Title: [269845] releases/WebKitGTK/webkit-2.30/Source
Revision
269845
Author
[email protected]
Date
2020-11-16 03:16:31 -0800 (Mon, 16 Nov 2020)

Log Message

[GTK][WPE] Build broken in stable 2.30.x releases with ENABLE_VIDEO=OFF
https://bugs.webkit.org/show_bug.cgi?id=218921

Reviewed by Carlos Garcia Campos.

Source/WebCore:

No new tests needed.

* Modules/webaudio/AudioContext.cpp: Add missing Document.h include.

Source/WebKit:

* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner): Use ENABLE(VIDEO)
guard to prevent usage of function which does not get compiled in when video support
disabled

Modified Paths

Diff

Modified: releases/WebKitGTK/webkit-2.30/Source/WebCore/ChangeLog (269844 => 269845)


--- releases/WebKitGTK/webkit-2.30/Source/WebCore/ChangeLog	2020-11-16 10:35:08 UTC (rev 269844)
+++ releases/WebKitGTK/webkit-2.30/Source/WebCore/ChangeLog	2020-11-16 11:16:31 UTC (rev 269845)
@@ -1,3 +1,14 @@
+2020-11-13  Adrian Perez de Castro  <[email protected]>
+
+        [GTK][WPE] Build broken in stable 2.30.x releases with ENABLE_VIDEO=OFF
+        https://bugs.webkit.org/show_bug.cgi?id=218921
+
+        Reviewed by Carlos Garcia Campos.
+
+        No new tests needed.
+
+        * Modules/webaudio/AudioContext.cpp: Add missing Document.h include.
+
 2020-10-27  Philippe Normand  <[email protected]>
 
         [GStreamer] Bad handling of audio files in the ImageDecoder

Modified: releases/WebKitGTK/webkit-2.30/Source/WebCore/Modules/webaudio/AudioContext.cpp (269844 => 269845)


--- releases/WebKitGTK/webkit-2.30/Source/WebCore/Modules/webaudio/AudioContext.cpp	2020-11-16 10:35:08 UTC (rev 269844)
+++ releases/WebKitGTK/webkit-2.30/Source/WebCore/Modules/webaudio/AudioContext.cpp	2020-11-16 11:16:31 UTC (rev 269845)
@@ -29,6 +29,7 @@
 
 #include "AudioContext.h"
 #include "DefaultAudioDestinationNode.h"
+#include "Document.h"
 #include "JSDOMPromiseDeferred.h"
 #include <wtf/IsoMallocInlines.h>
 

Modified: releases/WebKitGTK/webkit-2.30/Source/WebKit/ChangeLog (269844 => 269845)


--- releases/WebKitGTK/webkit-2.30/Source/WebKit/ChangeLog	2020-11-16 10:35:08 UTC (rev 269844)
+++ releases/WebKitGTK/webkit-2.30/Source/WebKit/ChangeLog	2020-11-16 11:16:31 UTC (rev 269845)
@@ -1,3 +1,15 @@
+2020-11-13  Adrian Perez de Castro  <[email protected]>
+
+        [GTK][WPE] Build broken in stable 2.30.x releases with ENABLE_VIDEO=OFF
+        https://bugs.webkit.org/show_bug.cgi?id=218921
+
+        Reviewed by Carlos Garcia Campos.
+
+        * WebProcess/InjectedBundle/InjectedBundle.cpp:
+        (WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner): Use ENABLE(VIDEO)
+        guard to prevent usage of function which does not get compiled in when video support
+        disabled
+
 2020-10-23  Adrian Perez de Castro  <[email protected]>
 
         Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.30.2 release

Modified: releases/WebKitGTK/webkit-2.30/Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.cpp (269844 => 269845)


--- releases/WebKitGTK/webkit-2.30/Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.cpp	2020-11-16 10:35:08 UTC (rev 269844)
+++ releases/WebKitGTK/webkit-2.30/Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.cpp	2020-11-16 11:16:31 UTC (rev 269845)
@@ -236,6 +236,7 @@
         RuntimeEnabledFeatures::sharedFeatures().setWebRTCMDNSICECandidatesEnabled(enabled);
 #endif
 
+#if ENABLE(VIDEO)
     if (preference == "WebKitGenericCueAPIEnabled") {
         WebPreferencesStore::overrideBoolValueForKey(WebPreferencesKey::genericCueAPIEnabledKey(), enabled);
         for (auto* page : pages)
@@ -242,6 +243,7 @@
             page->settings().setGenericCueAPIEnabled(enabled);
         return;
     }
+#endif
 
 #if ENABLE(GPU_PROCESS)
     if (preference == "WebKitUseGPUProcessForMedia" || preference == "WebKitCaptureAudioInGPUProcessEnabledKey") {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to