Title: [269885] trunk/Source/WebKit
- Revision
- 269885
- Author
- [email protected]
- Date
- 2020-11-16 15:51:48 -0800 (Mon, 16 Nov 2020)
Log Message
NetworkDataTaskCocoa::applyCookiePolicyForThirdPartyCNAMECloaking() redacts the cookie name in log output on customer builds
https://bugs.webkit.org/show_bug.cgi?id=218997
<rdar://problem/71460604>
Unreviewed minor change to logging.
NetworkDataTaskCocoa::applyCookiePolicyForThirdPartyCNAMECloaking() redacts the
cookie name in log output on customer builds. This patch changes the format
specifier from %s to %{public}s.
Note that this logging is just for ITP Debug Mode which is off by default, logs
in-memory only, and is disabled again on browser quit.
No new tests. This just changes log output on customer builds.
* NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
(WebKit::NetworkDataTaskCocoa::applyCookiePolicyForThirdPartyCNAMECloaking):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (269884 => 269885)
--- trunk/Source/WebKit/ChangeLog 2020-11-16 23:49:30 UTC (rev 269884)
+++ trunk/Source/WebKit/ChangeLog 2020-11-16 23:51:48 UTC (rev 269885)
@@ -1,3 +1,23 @@
+2020-11-16 John Wilander <[email protected]>
+
+ NetworkDataTaskCocoa::applyCookiePolicyForThirdPartyCNAMECloaking() redacts the cookie name in log output on customer builds
+ https://bugs.webkit.org/show_bug.cgi?id=218997
+ <rdar://problem/71460604>
+
+ Unreviewed minor change to logging.
+
+ NetworkDataTaskCocoa::applyCookiePolicyForThirdPartyCNAMECloaking() redacts the
+ cookie name in log output on customer builds. This patch changes the format
+ specifier from %s to %{public}s.
+
+ Note that this logging is just for ITP Debug Mode which is off by default, logs
+ in-memory only, and is disabled again on browser quit.
+
+ No new tests. This just changes log output on customer builds.
+
+ * NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
+ (WebKit::NetworkDataTaskCocoa::applyCookiePolicyForThirdPartyCNAMECloaking):
+
2020-11-16 Chris Dumez <[email protected]>
[GPUProcess] Update GPUProcess process assertion based on active WebProcesses
Modified: trunk/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm (269884 => 269885)
--- trunk/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm 2020-11-16 23:49:30 UTC (rev 269884)
+++ trunk/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm 2020-11-16 23:51:48 UTC (rev 269885)
@@ -205,7 +205,7 @@
cookie = WebCore::NetworkStorageSession::capExpiryOfPersistentCookie(cookie, ageCapForCNAMECloakedCookies);
[cappedCookies addObject:cookie];
if (debugLoggingEnabled)
- RELEASE_LOG_INFO(ITPDebug, "Capped the expiry of third-party CNAME cloaked cookie named %s.", [[cookie name] UTF8String]);
+ RELEASE_LOG_INFO(ITPDebug, "Capped the expiry of third-party CNAME cloaked cookie named %{public}s.", [[cookie name] UTF8String]);
}
return cappedCookies;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
