Title: [269935] trunk/Source/WebKit
- Revision
- 269935
- Author
- [email protected]
- Date
- 2020-11-17 16:42:10 -0800 (Tue, 17 Nov 2020)
Log Message
[iOS] ASSERTION FAILED: Completion handler should always be called under WebKit::GPUProcess::didReceiveMessage
https://bugs.webkit.org/show_bug.cgi?id=219055
<rdar://problem/71508223>
Reviewed by Alex Christensen.
Make sure GPUProcess::prepareToSuspend() calls its completion handler to avoid delaying suspension
and avoid assertion hits in debug.
* GPUProcess/GPUProcess.cpp:
(WebKit::GPUProcess::prepareToSuspend):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (269934 => 269935)
--- trunk/Source/WebKit/ChangeLog 2020-11-18 00:36:12 UTC (rev 269934)
+++ trunk/Source/WebKit/ChangeLog 2020-11-18 00:42:10 UTC (rev 269935)
@@ -1,5 +1,19 @@
2020-11-17 Chris Dumez <[email protected]>
+ [iOS] ASSERTION FAILED: Completion handler should always be called under WebKit::GPUProcess::didReceiveMessage
+ https://bugs.webkit.org/show_bug.cgi?id=219055
+ <rdar://problem/71508223>
+
+ Reviewed by Alex Christensen.
+
+ Make sure GPUProcess::prepareToSuspend() calls its completion handler to avoid delaying suspension
+ and avoid assertion hits in debug.
+
+ * GPUProcess/GPUProcess.cpp:
+ (WebKit::GPUProcess::prepareToSuspend):
+
+2020-11-17 Chris Dumez <[email protected]>
+
Make sure ProcessThrottler is always holding a ProcessAssertion for its child process
https://bugs.webkit.org/show_bug.cgi?id=219053
Modified: trunk/Source/WebKit/GPUProcess/GPUProcess.cpp (269934 => 269935)
--- trunk/Source/WebKit/GPUProcess/GPUProcess.cpp 2020-11-18 00:36:12 UTC (rev 269934)
+++ trunk/Source/WebKit/GPUProcess/GPUProcess.cpp 2020-11-18 00:42:10 UTC (rev 269935)
@@ -163,6 +163,7 @@
RELEASE_LOG(ProcessSuspension, "%p - GPUProcess::prepareToSuspend(), isSuspensionImminent: %d", this, isSuspensionImminent);
lowMemoryHandler(Critical::Yes);
+ completionHandler();
}
void GPUProcess::processDidResume()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
