Title: [269938] trunk/Source/WebCore
- Revision
- 269938
- Author
- [email protected]
- Date
- 2020-11-17 17:31:05 -0800 (Tue, 17 Nov 2020)
Log Message
REGRESSION (r269744): ASSERTION FAILED: m_hasValidContentHeight in WebCore::Layout::BoxGeometry::contentBoxHeight()
https://bugs.webkit.org/show_bug.cgi?id=219004
<rdar://problem/71459284>
Reviewed by Antti Koivisto.
Unfortunately we have to disable all percentage height/width content until after the integration codepath is fixed.
(in this case, the layout code assumes that percentage height values can always be resolved by climbing up on the
ancestor chain -worst case scenario we find the ICB which always has fixed height value.
However the integration codepath does not set the height on the fake ICB (RenderBlockFlow) even when the flow's height
is fixed and the IFC code can't climb farther up on the tree)
* layout/integration/LayoutIntegrationCoverage.cpp:
(WebCore::LayoutIntegration::canUseForChild):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (269937 => 269938)
--- trunk/Source/WebCore/ChangeLog 2020-11-18 01:24:56 UTC (rev 269937)
+++ trunk/Source/WebCore/ChangeLog 2020-11-18 01:31:05 UTC (rev 269938)
@@ -1,3 +1,20 @@
+2020-11-17 Zalan Bujtas <[email protected]>
+
+ REGRESSION (r269744): ASSERTION FAILED: m_hasValidContentHeight in WebCore::Layout::BoxGeometry::contentBoxHeight()
+ https://bugs.webkit.org/show_bug.cgi?id=219004
+ <rdar://problem/71459284>
+
+ Reviewed by Antti Koivisto.
+
+ Unfortunately we have to disable all percentage height/width content until after the integration codepath is fixed.
+ (in this case, the layout code assumes that percentage height values can always be resolved by climbing up on the
+ ancestor chain -worst case scenario we find the ICB which always has fixed height value.
+ However the integration codepath does not set the height on the fake ICB (RenderBlockFlow) even when the flow's height
+ is fixed and the IFC code can't climb farther up on the tree)
+
+ * layout/integration/LayoutIntegrationCoverage.cpp:
+ (WebCore::LayoutIntegration::canUseForChild):
+
2020-11-17 Megan Gardner <[email protected]>
Fix for localizableStrings.string in WebCore
Modified: trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp (269937 => 269938)
--- trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp 2020-11-18 01:24:56 UTC (rev 269937)
+++ trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp 2020-11-18 01:31:05 UTC (rev 269938)
@@ -583,13 +583,11 @@
auto isSupportedStyle = [] (const auto& style) {
if (style.verticalAlign() == VerticalAlign::Sub || style.verticalAlign() == VerticalAlign::Super)
return false;
- auto& width = style.width();
- auto& height = style.height();
- if (width.isPercent() || height.isPercent())
+ if (style.width().isPercent() || style.height().isPercent())
return false;
- if (width.isAuto() && (style.minWidth().isPercent() || style.maxWidth().isPercent()))
+ if (style.minWidth().isPercent() || style.maxWidth().isPercent())
return false;
- if (height.isAuto() && (style.minHeight().isPercent() || style.maxHeight().isPercent()))
+ if (style.minHeight().isPercent() || style.maxHeight().isPercent())
return false;
return true;
};
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
