Title: [269944] trunk/Source/WebCore
- Revision
- 269944
- Author
- [email protected]
- Date
- 2020-11-17 22:27:30 -0800 (Tue, 17 Nov 2020)
Log Message
REGRESSION(r269614): [iOS] WebContent crashes when entering Full Screen video with text captions
https://bugs.webkit.org/show_bug.cgi?id=219065
Reviewed by Tim Horton.
Pass a CGImageRef of the video caption to CALayer instead of passing a
NativeImage which is now a WebCore class.
* platform/graphics/cocoa/TextTrackRepresentationCocoa.mm:
(WebCore::TextTrackRepresentationCocoa::update):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (269943 => 269944)
--- trunk/Source/WebCore/ChangeLog 2020-11-18 06:15:45 UTC (rev 269943)
+++ trunk/Source/WebCore/ChangeLog 2020-11-18 06:27:30 UTC (rev 269944)
@@ -1,3 +1,16 @@
+2020-11-17 Said Abou-Hallawa <[email protected]>
+
+ REGRESSION(r269614): [iOS] WebContent crashes when entering Full Screen video with text captions
+ https://bugs.webkit.org/show_bug.cgi?id=219065
+
+ Reviewed by Tim Horton.
+
+ Pass a CGImageRef of the video caption to CALayer instead of passing a
+ NativeImage which is now a WebCore class.
+
+ * platform/graphics/cocoa/TextTrackRepresentationCocoa.mm:
+ (WebCore::TextTrackRepresentationCocoa::update):
+
2020-11-16 Yusuke Suzuki <[email protected]>
[JSC] Implement WebAssembly.Memory with shared
Modified: trunk/Source/WebCore/platform/graphics/cocoa/TextTrackRepresentationCocoa.mm (269943 => 269944)
--- trunk/Source/WebCore/platform/graphics/cocoa/TextTrackRepresentationCocoa.mm 2020-11-18 06:15:45 UTC (rev 269943)
+++ trunk/Source/WebCore/platform/graphics/cocoa/TextTrackRepresentationCocoa.mm 2020-11-18 06:27:30 UTC (rev 269944)
@@ -130,7 +130,7 @@
void TextTrackRepresentationCocoa::update()
{
if (auto representation = m_client.createTextTrackRepresentationImage())
- [m_layer.get() setContents:(__bridge id)representation->nativeImage().get()];
+ [m_layer.get() setContents:(__bridge id)representation->nativeImage()->platformImage().get()];
}
void TextTrackRepresentationCocoa::setContentScale(float scale)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
