Title: [269959] trunk/Tools
Revision
269959
Author
[email protected]
Date
2020-11-18 08:13:21 -0800 (Wed, 18 Nov 2020)

Log Message

[build.webkit.org] Update RunPerlTests step for new buildbot
https://bugs.webkit.org/show_bug.cgi?id=219083

Reviewed by Jonathan Bedard.

* CISupport/build-webkit-org/steps.py:
(RunPerlTests):
(RunPerlTests.start): Initialized log observer.
(RunPerlTests.parseOutputLine): Parse each log line as they come.
(RunPerlTests.countFailures): Updated to return failedTestCount.

Modified Paths

Diff

Modified: trunk/Tools/CISupport/build-webkit-org/steps.py (269958 => 269959)


--- trunk/Tools/CISupport/build-webkit-org/steps.py	2020-11-18 16:05:17 UTC (rev 269958)
+++ trunk/Tools/CISupport/build-webkit-org/steps.py	2020-11-18 16:13:21 UTC (rev 269959)
@@ -820,8 +820,24 @@
     descriptionDone = ["perl-tests"]
     command = ["perl", "./Tools/Scripts/test-webkitperl"]
     failedTestsFormatString = "%d perl test%s failed"
+    test_summary_re = re.compile(r'^Failed \d+/\d+ test programs\. (?P<count>\d+)/\d+ subtests failed\.')  # e.g.: Failed 2/19 test programs. 5/363 subtests failed.
 
+    def start(self):
+        if USE_BUILDBOT_VERSION2:
+            self.log_observer = ParseByLineLogObserver(self.parseOutputLine)
+            self.addLogObserver('stdio', self.log_observer)
+            self.failedTestCount = 0
+        return shell.Test.start(self)
+
+    def parseOutputLine(self, line):
+        match = self.test_summary_re.match(line)
+        if match:
+            self.failedTestCount = int(match.group('count'))
+
     def countFailures(self, cmd):
+        if USE_BUILDBOT_VERSION2:
+            return self.failedTestCount
+
         logText = cmd.logs['stdio'].getText()
         # We're looking for the line that looks like this: Failed 2/19 test programs. 5/363 subtests failed.
         regex = re.compile(r'^Failed \d+/\d+ test programs\. (?P<count>\d+)/\d+ subtests failed\.')

Modified: trunk/Tools/ChangeLog (269958 => 269959)


--- trunk/Tools/ChangeLog	2020-11-18 16:05:17 UTC (rev 269958)
+++ trunk/Tools/ChangeLog	2020-11-18 16:13:21 UTC (rev 269959)
@@ -1,5 +1,18 @@
 2020-11-18  Aakash Jain  <[email protected]>
 
+        [build.webkit.org] Update RunPerlTests step for new buildbot
+        https://bugs.webkit.org/show_bug.cgi?id=219083
+
+        Reviewed by Jonathan Bedard.
+
+        * CISupport/build-webkit-org/steps.py:
+        (RunPerlTests):
+        (RunPerlTests.start): Initialized log observer.
+        (RunPerlTests.parseOutputLine): Parse each log line as they come.
+        (RunPerlTests.countFailures): Updated to return failedTestCount.
+
+2020-11-18  Aakash Jain  <[email protected]>
+
         [build.webkit.org] Update RunPythonTests step for new buildbot
         https://bugs.webkit.org/show_bug.cgi?id=219082
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to