Title: [270110] trunk/Source/WebCore
- Revision
- 270110
- Author
- [email protected]
- Date
- 2020-11-20 06:47:29 -0800 (Fri, 20 Nov 2020)
Log Message
[LFC][Integration] Take alignment offset into account when computing line iterator logicalLeft
https://bugs.webkit.org/show_bug.cgi?id=219197
Reviewed by Zalan Bujtas.
This fixes editing/style/text-indent.html with LFC editing enabled.
* layout/integration/LayoutIntegrationLineIteratorModernPath.h:
(WebCore::LayoutIntegration::LineIteratorModernPath::logicalLeft const):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (270109 => 270110)
--- trunk/Source/WebCore/ChangeLog 2020-11-20 13:32:42 UTC (rev 270109)
+++ trunk/Source/WebCore/ChangeLog 2020-11-20 14:47:29 UTC (rev 270110)
@@ -1,3 +1,15 @@
+2020-11-20 Antti Koivisto <[email protected]>
+
+ [LFC][Integration] Take alignment offset into account when computing line iterator logicalLeft
+ https://bugs.webkit.org/show_bug.cgi?id=219197
+
+ Reviewed by Zalan Bujtas.
+
+ This fixes editing/style/text-indent.html with LFC editing enabled.
+
+ * layout/integration/LayoutIntegrationLineIteratorModernPath.h:
+ (WebCore::LayoutIntegration::LineIteratorModernPath::logicalLeft const):
+
2020-11-20 Zalan Bujtas <[email protected]>
[LFC] BoxGeometry only tracks the reserved horizontal/vertical space for the scrollbars
Modified: trunk/Source/WebCore/layout/integration/LayoutIntegrationLineIteratorModernPath.h (270109 => 270110)
--- trunk/Source/WebCore/layout/integration/LayoutIntegrationLineIteratorModernPath.h 2020-11-20 13:32:42 UTC (rev 270109)
+++ trunk/Source/WebCore/layout/integration/LayoutIntegrationLineIteratorModernPath.h 2020-11-20 14:47:29 UTC (rev 270110)
@@ -59,7 +59,7 @@
LayoutUnit selectionTopForHitTesting() const { return top(); }
LayoutUnit selectionBottom() const { return bottom(); }
- float logicalLeft() const { return line().rect().x(); }
+ float logicalLeft() const { return line().rect().x() + line().horizontalAlignmentOffset(); }
float logicalRight() const { return logicalLeft() + line().lineBoxWidth(); }
float y() const { return lineBoxTop(); }
float logicalHeight() const { return line().rect().height(); }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes