[webkit-changes] [270139] trunk/LayoutTests

Fri, 20 Nov 2020 17:12:03 -0800

Title: [270139] trunk/LayoutTests
Revision
270139
Author
[email protected]
Date
2020-11-20 17:11:20 -0800 (Fri, 20 Nov 2020)

Log Message

(r267253) [ Mac ] webaudio/AudioParam/audioparam-processing.html is flaky failing
https://bugs.webkit.org/show_bug.cgi?id=219228
<rdar://problem/71643007>

Reviewed by Geoffrey Garen.

The test was running subtests in parallel using Promise.all(), causing the output
lines to sometimes be out of order. We now enforce the ordering of the subtests
to make sure that the output is consistent.

* webaudio/AudioParam/audioparam-processing.html:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (270138 => 270139)


--- trunk/LayoutTests/ChangeLog	2020-11-21 00:51:51 UTC (rev 270138)
+++ trunk/LayoutTests/ChangeLog	2020-11-21 01:11:20 UTC (rev 270139)
@@ -1,3 +1,17 @@
+2020-11-20  Chris Dumez  <[email protected]>
+
+        (r267253) [ Mac ] webaudio/AudioParam/audioparam-processing.html is flaky failing
+        https://bugs.webkit.org/show_bug.cgi?id=219228
+        <rdar://problem/71643007>
+
+        Reviewed by Geoffrey Garen.
+
+        The test was running subtests in parallel using Promise.all(), causing the output
+        lines to sometimes be out of order. We now enforce the ordering of the subtests
+        to make sure that the output is consistent.
+
+        * webaudio/AudioParam/audioparam-processing.html:
+
 2020-11-20  Alex Christensen  <[email protected]>
 
         Silence ApplicationCache related errors when running http/tests/inspector/network/x-frame-options.html

Modified: trunk/LayoutTests/webaudio/AudioParam/audioparam-processing.html (270138 => 270139)


--- trunk/LayoutTests/webaudio/AudioParam/audioparam-processing.html	2020-11-21 00:51:51 UTC (rev 270138)
+++ trunk/LayoutTests/webaudio/AudioParam/audioparam-processing.html	2020-11-21 01:11:20 UTC (rev 270139)
@@ -27,36 +27,33 @@
       // Source nodes are not included in this because the AudioParams for the
       // source nodes only process when the node has been started.
 
-      audit.define('BiquadFilterNode', (task, should) => {
+      audit.define('BiquadFilterNode', async (task, should) => {
         let nodeName = 'BiquadFilterNode'
-        Promise
-            .all([
-              testParamAutomation(should, {
-                nodeName: nodeName,
-                paramName: 'Q',
-                initialValue: 2,
-                rampFinalValue: 5
-              }),
-              testParamAutomation(should, {
-                nodeName: nodeName,
-                paramName: 'detune',
-                initialValue: 1,
-                rampFinalValue: 0.5
-              }),
-              testParamAutomation(should, {
-                nodeName: nodeName,
-                paramName: 'frequency',
-                initialValue: 1000,
-                rampFinalValue: 100
-              }),
-              testParamAutomation(should, {
-                nodeName: nodeName,
-                paramName: 'gain',
-                initialValue: -3,
-                rampFinalValue: 3
-              }),
-            ])
-            .then(() => task.done());
+        await testParamAutomation(should, {
+          nodeName: nodeName,
+          paramName: 'Q',
+          initialValue: 2,
+          rampFinalValue: 5
+        });
+        await testParamAutomation(should, {
+          nodeName: nodeName,
+          paramName: 'detune',
+          initialValue: 1,
+          rampFinalValue: 0.5
+        });
+        await testParamAutomation(should, {
+          nodeName: nodeName,
+          paramName: 'frequency',
+          initialValue: 1000,
+          rampFinalValue: 100
+        });
+        await testParamAutomation(should, {
+          nodeName: nodeName,
+          paramName: 'gain',
+          initialValue: -3,
+          rampFinalValue: 3
+        });
+        task.done();
       });
 
       audit.define('DelayNode', (task, should) => {
@@ -68,42 +65,39 @@
         }).then(() => task.done());
       });
 
-      audit.define('DynamicsCompressorNode', (task, should) => {
+      audit.define('DynamicsCompressorNode', async (task, should) => {
         let nodeName = 'DynamicsCompressorNode';
-        Promise
-            .all([
-              testParamAutomation(should, {
-                nodeName: nodeName,
-                paramName: 'attack',
-                initialValue: 0.1,
-                rampFinalValue: 0.5
-              }),
-              testParamAutomation(should, {
-                nodeName: nodeName,
-                paramName: 'knee',
-                initialValue: 0,
-                rampFinalValue: 25
-              }),
-              testParamAutomation(should, {
-                nodeName: nodeName,
-                paramName: 'ratio',
-                initialValue: 1,
-                rampFinalValue: 15
-              }),
-              testParamAutomation(should, {
-                nodeName: nodeName,
-                paramName: 'release',
-                initialValue: 0,
-                rampFinalValue: 0.75
-              }),
-              testParamAutomation(should, {
-                nodeName: nodeName,
-                paramName: 'threshold',
-                initialValue: -50,
-                rampFinalValue: -10
-              })
-            ])
-            .then(() => task.done());
+        await testParamAutomation(should, {
+          nodeName: nodeName,
+          paramName: 'attack',
+          initialValue: 0.1,
+          rampFinalValue: 0.5
+        });
+        await testParamAutomation(should, {
+          nodeName: nodeName,
+          paramName: 'knee',
+          initialValue: 0,
+          rampFinalValue: 25
+        });
+        await testParamAutomation(should, {
+          nodeName: nodeName,
+          paramName: 'ratio',
+          initialValue: 1,
+          rampFinalValue: 15
+        });
+        await testParamAutomation(should, {
+          nodeName: nodeName,
+          paramName: 'release',
+          initialValue: 0,
+          rampFinalValue: 0.75
+        });
+        await testParamAutomation(should, {
+          nodeName: nodeName,
+          paramName: 'threshold',
+          initialValue: -50,
+          rampFinalValue: -10
+        });
+        task.done();
       });
 
       audit.define('GainNode', (task, should) => {
@@ -115,48 +109,45 @@
         }).then(() => task.done());
       });
 
-      audit.define('PannerNode', (task, should) => {
+      audit.define('PannerNode', async (task, should) => {
         let nodeName = 'PannerNode';
-        Promise
-            .all([
-              testParamAutomation(should, {
-                nodeName: nodeName,
-                paramName: 'positionX',
-                initialValue: 0.1,
-                rampFinalValue: 0.5
-              }),
-              testParamAutomation(should, {
-                nodeName: nodeName,
-                paramName: 'positionY',
-                initialValue: 2,
-                rampFinalValue: 30
-              }),
-              testParamAutomation(should, {
-                nodeName: nodeName,
-                paramName: 'positionZ',
-                initialValue: 1,
-                rampFinalValue: 15
-              }),
-              testParamAutomation(should, {
-                nodeName: nodeName,
-                paramName: 'orientationX',
-                initialValue: 0.1,
-                rampFinalValue: 0.5
-              }),
-              testParamAutomation(should, {
-                nodeName: nodeName,
-                paramName: 'orientationY',
-                initialValue: 2,
-                rampFinalValue: 30
-              }),
-              testParamAutomation(should, {
-                nodeName: nodeName,
-                paramName: 'orientationZ',
-                initialValue: 1,
-                rampFinalValue: 15
-              }),
-            ])
-            .then(() => task.done());
+        await testParamAutomation(should, {
+          nodeName: nodeName,
+          paramName: 'positionX',
+          initialValue: 0.1,
+          rampFinalValue: 0.5
+        });
+        await testParamAutomation(should, {
+          nodeName: nodeName,
+          paramName: 'positionY',
+          initialValue: 2,
+          rampFinalValue: 30
+        });
+        await testParamAutomation(should, {
+          nodeName: nodeName,
+          paramName: 'positionZ',
+          initialValue: 1,
+          rampFinalValue: 15
+        });
+        await testParamAutomation(should, {
+          nodeName: nodeName,
+          paramName: 'orientationX',
+          initialValue: 0.1,
+          rampFinalValue: 0.5
+        });
+        await testParamAutomation(should, {
+          nodeName: nodeName,
+          paramName: 'orientationY',
+          initialValue: 2,
+          rampFinalValue: 30
+        });
+        await testParamAutomation(should, {
+          nodeName: nodeName,
+          paramName: 'orientationZ',
+          initialValue: 1,
+          rampFinalValue: 15
+        });
+        task.done();
       });
 
       audit.define('StereoPannerNode', (task, should) => {
@@ -168,50 +159,53 @@
         }).then(() => task.done());
       });
 
-      audit.define('AudioListener', (task, should) => {
-        Promise
-            .all([
-              testAudioListener(should, {
-                paramName: 'positionX',
-                initialValue: 1,
-                rampFinalValue: 100
-              }),
-              testAudioListener(should, {
-                paramName: 'positionY',
-                initialValue: 1,
-                rampFinalValue: 200
-              }),
-              testAudioListener(should, {
-                paramName: 'positionZ',
-                initialValue: 1,
-                rampFinalValue: 300
-              }),
-              testAudioListener(should, {
-                paramName: 'forwardX',
-                initialValue: 1,
-                rampFinalValue: -100
-              }),
-              testAudioListener(should, {
-                paramName: 'forwardY',
-                initialValue: 1,
-                rampFinalValue: -200
-              }),
-              testAudioListener(should, {
-                paramName: 'forwardZ',
-                initialValue: 1,
-                rampFinalValue: -300
-              }),
-              testAudioListener(
-                  should,
-                  {paramName: 'upX', initialValue: 1, rampFinalValue: 99}),
-              testAudioListener(
-                  should,
-                  {paramName: 'upY', initialValue: 1, rampFinalValue: 42}),
-              testAudioListener(
-                  should,
-                  {paramName: 'upZ', initialValue: 1, rampFinalValue: 137}),
-            ])
-            .then(() => task.done());
+      audit.define('AudioListener', async (task, should) => {
+        await testAudioListener(should, {
+          paramName: 'positionX',
+          initialValue: 1,
+          rampFinalValue: 100
+        });
+        await testAudioListener(should, {
+          paramName: 'positionY',
+          initialValue: 1,
+          rampFinalValue: 200
+        });
+        await testAudioListener(should, {
+          paramName: 'positionZ',
+          initialValue: 1,
+          rampFinalValue: 300
+        });
+        await testAudioListener(should, {
+          paramName: 'forwardX',
+          initialValue: 1,
+          rampFinalValue: -100
+        });
+        await testAudioListener(should, {
+          paramName: 'forwardY',
+          initialValue: 1,
+          rampFinalValue: -200
+        });
+        await testAudioListener(should, {
+          paramName: 'forwardZ',
+          initialValue: 1,
+          rampFinalValue: -300
+        });
+        await testAudioListener(should, {
+          paramName: 'upX',
+          initialValue: 1,
+          rampFinalValue: 99
+        });
+        await testAudioListener(should, {
+          paramName: 'upY',
+          initialValue: 1,
+          rampFinalValue: 42
+        });
+        await testAudioListener(should, {
+          paramName: 'upZ',
+          initialValue: 1,
+          rampFinalValue: 137
+        });
+        task.done();
       });
 
       // Run test of automation processing. |options| is a dictionary that

_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to