- Revision
- 270152
- Author
- [email protected]
- Date
- 2020-11-21 12:12:10 -0800 (Sat, 21 Nov 2020)
Log Message
Add an Experimental Features for wheel event gestures becoming non-blocking
https://bugs.webkit.org/show_bug.cgi?id=219236
Reviewed by Sam Weinig.
Source/WebCore:
Add a feature flag for the behavior that is being added via webkit.org/b/218764,
which is that only the first wheel event in a gesture is cancelable.
* platform/cocoa/VersionChecks.h:
Source/WebKit:
Add a feature flag for the behavior that is being added via webkit.org/b/218764,
which is that only the first wheel event in a gesture is cancelable.
* Shared/WebPreferencesDefaultValues.cpp:
(WebKit::defaultWheelEventGesturesBecomeNonBlocking):
* Shared/WebPreferencesDefaultValues.h:
Source/WebKitLegacy/mac:
Add a feature flag for the behavior that is being added via webkit.org/b/218764,
which is that only the first wheel event in a gesture is cancelable.
* WebView/WebPreferencesDefaultValues.h:
* WebView/WebPreferencesDefaultValues.mm:
(WebKit::defaultWheelEventGesturesBecomeNonBlocking):
Source/WTF:
Add a feature flag for the behavior that is being added via webkit.org/b/218764,
which is that only the first wheel event in a gesture is cancelable.
* Scripts/Preferences/WebPreferencesExperimental.yaml:
Modified Paths
Diff
Modified: trunk/Source/WTF/ChangeLog (270151 => 270152)
--- trunk/Source/WTF/ChangeLog 2020-11-21 20:04:56 UTC (rev 270151)
+++ trunk/Source/WTF/ChangeLog 2020-11-21 20:12:10 UTC (rev 270152)
@@ -1,3 +1,15 @@
+2020-11-21 Simon Fraser <[email protected]>
+
+ Add an Experimental Features for wheel event gestures becoming non-blocking
+ https://bugs.webkit.org/show_bug.cgi?id=219236
+
+ Reviewed by Sam Weinig.
+
+ Add a feature flag for the behavior that is being added via webkit.org/b/218764,
+ which is that only the first wheel event in a gesture is cancelable.
+
+ * Scripts/Preferences/WebPreferencesExperimental.yaml:
+
2020-11-20 Geoffrey Garen <[email protected]>
Use a Version 1 CFRunLoopSource for faster task dispatch
Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml (270151 => 270152)
--- trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml 2020-11-21 20:04:56 UTC (rev 270151)
+++ trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml 2020-11-21 20:12:10 UTC (rev 270152)
@@ -1096,6 +1096,20 @@
WebKit:
default: WebKit::defaultWebXREnabled()
+WheelEventGesturesBecomeNonBlocking:
+ type: bool
+ humanReadableName: "Wheel Event gestures become non-blocking"
+ humanReadableDescription: "preventDefault() is only allowed on the first wheel event in a gesture"
+ defaultValue:
+ WebKitLegacy:
+ "PLATFORM(MAC)": WebKit::defaultWheelEventGesturesBecomeNonBlocking()
+ default: true
+ WebKit:
+ "PLATFORM(MAC)": WebKit::defaultWheelEventGesturesBecomeNonBlocking()
+ default: true
+ WebCore:
+ default: true
+
WritableStreamAPIEnabled:
type: bool
humanReadableName: "WritableStream API"
Modified: trunk/Source/WebCore/ChangeLog (270151 => 270152)
--- trunk/Source/WebCore/ChangeLog 2020-11-21 20:04:56 UTC (rev 270151)
+++ trunk/Source/WebCore/ChangeLog 2020-11-21 20:12:10 UTC (rev 270152)
@@ -1,3 +1,15 @@
+2020-11-21 Simon Fraser <[email protected]>
+
+ Add an Experimental Features for wheel event gestures becoming non-blocking
+ https://bugs.webkit.org/show_bug.cgi?id=219236
+
+ Reviewed by Sam Weinig.
+
+ Add a feature flag for the behavior that is being added via webkit.org/b/218764,
+ which is that only the first wheel event in a gesture is cancelable.
+
+ * platform/cocoa/VersionChecks.h:
+
2020-11-21 Zalan Bujtas <[email protected]>
[LFC][IFC] Treat floats as soft wrap opportunities
Modified: trunk/Source/WebCore/platform/cocoa/VersionChecks.h (270151 => 270152)
--- trunk/Source/WebCore/platform/cocoa/VersionChecks.h 2020-11-21 20:04:56 UTC (rev 270151)
+++ trunk/Source/WebCore/platform/cocoa/VersionChecks.h 2020-11-21 20:12:10 UTC (rev 270152)
@@ -72,6 +72,7 @@
FirstWithDropToNavigateDisallowedByDefault = DYLD_MACOSX_VERSION_10_13,
FirstWithExpiredOnlyReloadBehavior = DYLD_MACOSX_VERSION_10_13,
FirstThatDefaultsToPassiveWheelListenersOnDocument = DYLD_MACOSX_VERSION_11_3,
+ FirstThatAllowsWheelEventGesturesToBecomeNonBlocking = DYLD_MACOSX_VERSION_11_3,
FirstWithWebIconDatabaseWarning = DYLD_MACOSX_VERSION_10_13,
FirstWithMainThreadReleaseAssertionInWebPageProxy = DYLD_MACOSX_VERSION_10_14,
FirstWithoutUnconditionalUniversalSandboxExtension = DYLD_MACOSX_VERSION_10_15,
Modified: trunk/Source/WebKit/ChangeLog (270151 => 270152)
--- trunk/Source/WebKit/ChangeLog 2020-11-21 20:04:56 UTC (rev 270151)
+++ trunk/Source/WebKit/ChangeLog 2020-11-21 20:12:10 UTC (rev 270152)
@@ -1,3 +1,17 @@
+2020-11-21 Simon Fraser <[email protected]>
+
+ Add an Experimental Features for wheel event gestures becoming non-blocking
+ https://bugs.webkit.org/show_bug.cgi?id=219236
+
+ Reviewed by Sam Weinig.
+
+ Add a feature flag for the behavior that is being added via webkit.org/b/218764,
+ which is that only the first wheel event in a gesture is cancelable.
+
+ * Shared/WebPreferencesDefaultValues.cpp:
+ (WebKit::defaultWheelEventGesturesBecomeNonBlocking):
+ * Shared/WebPreferencesDefaultValues.h:
+
2020-11-21 Jiewen Tan <[email protected]>
[WebAuthn] Implement SPI for AuthenticationServices.Framework
Modified: trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp (270151 => 270152)
--- trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp 2020-11-21 20:04:56 UTC (rev 270151)
+++ trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp 2020-11-21 20:12:10 UTC (rev 270152)
@@ -60,6 +60,12 @@
return result;
}
+bool defaultWheelEventGesturesBecomeNonBlocking()
+{
+ static bool result = linkedOnOrAfter(WebCore::SDKVersion::FirstThatAllowsWheelEventGesturesToBecomeNonBlocking);
+ return result;
+}
+
#endif
#if PLATFORM(MAC) || PLATFORM(IOS_FAMILY)
Modified: trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h (270151 => 270152)
--- trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h 2020-11-21 20:04:56 UTC (rev 270151)
+++ trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h 2020-11-21 20:12:10 UTC (rev 270152)
@@ -49,6 +49,7 @@
#if PLATFORM(MAC)
bool defaultPassiveWheelListenersAsDefaultOnDocument();
+bool defaultWheelEventGesturesBecomeNonBlocking();
#endif
#if PLATFORM(MAC) || PLATFORM(IOS_FAMILY)
Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (270151 => 270152)
--- trunk/Source/WebKitLegacy/mac/ChangeLog 2020-11-21 20:04:56 UTC (rev 270151)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog 2020-11-21 20:12:10 UTC (rev 270152)
@@ -1,3 +1,17 @@
+2020-11-21 Simon Fraser <[email protected]>
+
+ Add an Experimental Features for wheel event gestures becoming non-blocking
+ https://bugs.webkit.org/show_bug.cgi?id=219236
+
+ Reviewed by Sam Weinig.
+
+ Add a feature flag for the behavior that is being added via webkit.org/b/218764,
+ which is that only the first wheel event in a gesture is cancelable.
+
+ * WebView/WebPreferencesDefaultValues.h:
+ * WebView/WebPreferencesDefaultValues.mm:
+ (WebKit::defaultWheelEventGesturesBecomeNonBlocking):
+
2020-11-19 Hoa Dinh <[email protected]>
Code formatting: change instances of "@synthesize a=b" to "@synthesize a = b".
Modified: trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.h (270151 => 270152)
--- trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.h 2020-11-21 20:04:56 UTC (rev 270151)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.h 2020-11-21 20:12:10 UTC (rev 270152)
@@ -84,6 +84,7 @@
#if PLATFORM(MAC)
bool defaultPassiveWheelListenersAsDefaultOnDocument();
+bool defaultWheelEventGesturesBecomeNonBlocking();
#endif
} // namespace WebKit
Modified: trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.mm (270151 => 270152)
--- trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.mm 2020-11-21 20:04:56 UTC (rev 270151)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.mm 2020-11-21 20:12:10 UTC (rev 270152)
@@ -291,6 +291,12 @@
return result;
}
+bool defaultWheelEventGesturesBecomeNonBlocking()
+{
+ static bool result = linkedOnOrAfter(WebCore::SDKVersion::FirstThatAllowsWheelEventGesturesToBecomeNonBlocking);
+ return result;
+}
+
#endif
} // namespace WebKit
