Title: [270223] trunk/Source/_javascript_Core
Revision
270223
Author
[email protected]
Date
2020-11-28 20:20:53 -0800 (Sat, 28 Nov 2020)

Log Message

Unreviewed, follow-up after r270214
https://bugs.webkit.org/show_bug.cgi?id=219281

ARM64 does not support unary Not32 / Not64.

* wasm/WasmAirIRGenerator.cpp:
(JSC::Wasm::AirIRGenerator::emitAtomicBinaryRMWOp):

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (270222 => 270223)


--- trunk/Source/_javascript_Core/ChangeLog	2020-11-29 04:05:09 UTC (rev 270222)
+++ trunk/Source/_javascript_Core/ChangeLog	2020-11-29 04:20:53 UTC (rev 270223)
@@ -1,3 +1,13 @@
+2020-11-28  Yusuke Suzuki  <[email protected]>
+
+        Unreviewed, follow-up after r270214
+        https://bugs.webkit.org/show_bug.cgi?id=219281
+
+        ARM64 does not support unary Not32 / Not64.
+
+        * wasm/WasmAirIRGenerator.cpp:
+        (JSC::Wasm::AirIRGenerator::emitAtomicBinaryRMWOp):
+
 2020-11-27  Yusuke Suzuki  <[email protected]>
 
         [JSC] Use ARM atomic ops in wasm

Modified: trunk/Source/_javascript_Core/wasm/WasmAirIRGenerator.cpp (270222 => 270223)


--- trunk/Source/_javascript_Core/wasm/WasmAirIRGenerator.cpp	2020-11-29 04:05:09 UTC (rev 270222)
+++ trunk/Source/_javascript_Core/wasm/WasmAirIRGenerator.cpp	2020-11-29 04:20:53 UTC (rev 270223)
@@ -2187,13 +2187,12 @@
             TypedTmp newValue;
             if (valueType == Type::I64) {
                 newValue = g64();
-                append(Move, value, newValue);
-                append(Not64, newValue);
+                append(Not64, value, newValue);
             } else {
                 newValue = g32();
-                append(Move, value, newValue);
-                append(Not32, newValue);
+                append(Not32, value, newValue);
             }
+            value = newValue;
             opcode = OPCODE_FOR_WIDTH(AtomicXchgClear, accessWidth(op));
         }
         nonAtomicOpcode = OPCODE_FOR_CANONICAL_WIDTH(And, accessWidth(op));
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to