Title: [270279] trunk/Source/WebKit
- Revision
- 270279
- Author
- [email protected]
- Date
- 2020-11-30 18:09:57 -0800 (Mon, 30 Nov 2020)
Log Message
[WinCairo?] GPU process remains alive even after UI process exited
https://bugs.webkit.org/show_bug.cgi?id=219321
Reviewed by Don Olmstead.
GPUConnectionToWebProcess::didClose is called when web process
exits, and GPUProcess::didClose is called when UI process exits in
GPU process. GPUProcess::didClose should terminate the GPU
process.
AuxiliaryProcess is the base class of GPUProcess.
AuxiliaryProcess::didClose is calling _exit. However, GPUProcess
overrode AuxiliaryProcess::didClose but it did nothing. GPUProcess
doesn't need to override it.
* GPUProcess/GPUProcess.cpp:
(WebKit::GPUProcess::didClose): Deleted.
* GPUProcess/GPUProcess.h:
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (270278 => 270279)
--- trunk/Source/WebKit/ChangeLog 2020-12-01 01:29:36 UTC (rev 270278)
+++ trunk/Source/WebKit/ChangeLog 2020-12-01 02:09:57 UTC (rev 270279)
@@ -1,3 +1,24 @@
+2020-11-30 Fujii Hironori <[email protected]>
+
+ [WinCairo?] GPU process remains alive even after UI process exited
+ https://bugs.webkit.org/show_bug.cgi?id=219321
+
+ Reviewed by Don Olmstead.
+
+ GPUConnectionToWebProcess::didClose is called when web process
+ exits, and GPUProcess::didClose is called when UI process exits in
+ GPU process. GPUProcess::didClose should terminate the GPU
+ process.
+
+ AuxiliaryProcess is the base class of GPUProcess.
+ AuxiliaryProcess::didClose is calling _exit. However, GPUProcess
+ overrode AuxiliaryProcess::didClose but it did nothing. GPUProcess
+ doesn't need to override it.
+
+ * GPUProcess/GPUProcess.cpp:
+ (WebKit::GPUProcess::didClose): Deleted.
+ * GPUProcess/GPUProcess.h:
+
2020-11-30 Simon Fraser <[email protected]>
Pass OptionSet<EventHandling> to various wheel event handler functions
Modified: trunk/Source/WebKit/GPUProcess/GPUProcess.cpp (270278 => 270279)
--- trunk/Source/WebKit/GPUProcess/GPUProcess.cpp 2020-12-01 01:29:36 UTC (rev 270278)
+++ trunk/Source/WebKit/GPUProcess/GPUProcess.cpp 2020-12-01 02:09:57 UTC (rev 270279)
@@ -114,11 +114,6 @@
return m_webProcessConnections.isEmpty();
}
-void GPUProcess::didClose(IPC::Connection&)
-{
- ASSERT(RunLoop::isMain());
-}
-
void GPUProcess::lowMemoryHandler(Critical critical)
{
WTF::releaseFastMallocFreeMemory();
Modified: trunk/Source/WebKit/GPUProcess/GPUProcess.h (270278 => 270279)
--- trunk/Source/WebKit/GPUProcess/GPUProcess.h 2020-12-01 01:29:36 UTC (rev 270278)
+++ trunk/Source/WebKit/GPUProcess/GPUProcess.h 2020-12-01 02:09:57 UTC (rev 270279)
@@ -98,7 +98,6 @@
// IPC::Connection::Client
void didReceiveMessage(IPC::Connection&, IPC::Decoder&) override;
- void didClose(IPC::Connection&) override;
// Message Handlers
void initializeGPUProcess(GPUProcessCreationParameters&&);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
