Title: [270301] trunk/Source/WebCore
- Revision
- 270301
- Author
- [email protected]
- Date
- 2020-12-01 09:23:04 -0800 (Tue, 01 Dec 2020)
Log Message
[GStreamer] Common module should use a dedicated logging category
https://bugs.webkit.org/show_bug.cgi?id=219348
Patch by Philippe Normand <[email protected]> on 2020-12-01
Reviewed by Xabier Rodriguez-Calvar.
Because this module can be used outside of the MediaPlayer scope, we cannot assume the
MediaPlayer debug category will be initialized in time when GST_DEBUG logs need to be
emitted from GStreamerCommon. So it is safer to introduce a new, standalone, logging
category for this module.
* platform/graphics/gstreamer/GStreamerCommon.cpp:
(WebCore::initializeGStreamer):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (270300 => 270301)
--- trunk/Source/WebCore/ChangeLog 2020-12-01 17:14:28 UTC (rev 270300)
+++ trunk/Source/WebCore/ChangeLog 2020-12-01 17:23:04 UTC (rev 270301)
@@ -1,3 +1,18 @@
+2020-12-01 Philippe Normand <[email protected]>
+
+ [GStreamer] Common module should use a dedicated logging category
+ https://bugs.webkit.org/show_bug.cgi?id=219348
+
+ Reviewed by Xabier Rodriguez-Calvar.
+
+ Because this module can be used outside of the MediaPlayer scope, we cannot assume the
+ MediaPlayer debug category will be initialized in time when GST_DEBUG logs need to be
+ emitted from GStreamerCommon. So it is safer to introduce a new, standalone, logging
+ category for this module.
+
+ * platform/graphics/gstreamer/GStreamerCommon.cpp:
+ (WebCore::initializeGStreamer):
+
2020-12-01 Rob Buis <[email protected]>
Lazy loaded iframe should not lazy load when scripting is disabled
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp (270300 => 270301)
--- trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp 2020-12-01 17:14:28 UTC (rev 270300)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp 2020-12-01 17:23:04 UTC (rev 270301)
@@ -65,8 +65,8 @@
#include "WebKitWebSourceGStreamer.h"
#endif
-GST_DEBUG_CATEGORY_EXTERN(webkit_media_player_debug);
-#define GST_CAT_DEFAULT webkit_media_player_debug
+GST_DEBUG_CATEGORY(webkit_gst_common_debug);
+#define GST_CAT_DEFAULT webkit_gst_common_debug
namespace WebCore {
@@ -255,6 +255,7 @@
isGStreamerInitialized = gst_init_check(&argc, &argv, &error.outPtr());
ASSERT_WITH_MESSAGE(isGStreamerInitialized, "GStreamer initialization failed: %s", error ? error->message : "unknown error occurred");
g_strfreev(argv);
+ GST_DEBUG_CATEGORY_INIT(webkit_gst_common_debug, "webkitcommon", 0, "WebKit Common utilities");
if (isFastMallocEnabled()) {
const char* disableFastMalloc = getenv("WEBKIT_GST_DISABLE_FAST_MALLOC");
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
