Title: [270328] trunk/Tools
- Revision
- 270328
- Author
- [email protected]
- Date
- 2020-12-01 14:23:09 -0800 (Tue, 01 Dec 2020)
Log Message
[iOS] GPUProcess.CrashWhilePlayingVideo is flaky
https://bugs.webkit.org/show_bug.cgi?id=219377
<rdar://problem/71859117>
Reviewed by Darin Adler.
Disable the flaky check on iOS while this is investigated so that the bots are happy.
In the iOS simulator, I see the audio track getting disabled shortly after the GPU
process is relaunched for some reason. I have spent a lot of time investigating the
issue but have been unable to identify the root cause yet.
* TestWebKitAPI/Tests/WebKitCocoa/GPUProcess.mm:
(TEST):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (270327 => 270328)
--- trunk/Tools/ChangeLog 2020-12-01 21:39:26 UTC (rev 270327)
+++ trunk/Tools/ChangeLog 2020-12-01 22:23:09 UTC (rev 270328)
@@ -1,3 +1,20 @@
+2020-12-01 Chris Dumez <[email protected]>
+
+ [iOS] GPUProcess.CrashWhilePlayingVideo is flaky
+ https://bugs.webkit.org/show_bug.cgi?id=219377
+ <rdar://problem/71859117>
+
+ Reviewed by Darin Adler.
+
+ Disable the flaky check on iOS while this is investigated so that the bots are happy.
+
+ In the iOS simulator, I see the audio track getting disabled shortly after the GPU
+ process is relaunched for some reason. I have spent a lot of time investigating the
+ issue but have been unable to identify the root cause yet.
+
+ * TestWebKitAPI/Tests/WebKitCocoa/GPUProcess.mm:
+ (TEST):
+
2020-12-01 Sergey Rubanov <[email protected]>
Add Sergey Rubanov to contributors.json
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/GPUProcess.mm (270327 => 270328)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/GPUProcess.mm 2020-12-01 21:39:26 UTC (rev 270327)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/GPUProcess.mm 2020-12-01 22:23:09 UTC (rev 270328)
@@ -275,11 +275,14 @@
// Make sure the WebProcess did not crash.
EXPECT_EQ(webViewPID, [webView _webProcessIdentifier]);
+ // FIXME: In the iOS simulator, video resumes after the GPU process crash but audio does not.
+#if !PLATFORM(IOS)
// Audio should resume playing.
timeout = 0;
while (![webView _isPlayingAudio] && timeout++ < 100)
TestWebKitAPI::Util::sleep(0.1);
EXPECT_TRUE([webView _isPlayingAudio]);
+#endif
EXPECT_EQ(gpuProcessPID, [processPool _gpuProcessIdentifier]);
EXPECT_EQ(webViewPID, [webView _webProcessIdentifier]);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
