Log Message
Switch EWS workers for JSC-ARMv7-32bits build and test queues to a new machine. https://bugs.webkit.org/show_bug.cgi?id=219189
Reviewed by Aakash Jain. This switches the workers for the JSC-ARMv7-32bits-Build-EWS and JSC-ARMv7-32bits-Test-EWS queues to a new ARM server that will run things faster than the previous combination of cross-builder + RPis Since now the tets run natively there is no need for passing the "--remote-config-file" switch to the run-_javascript_core-tests script. However "--memory-limited" is still needed because the issues with failures on memory intensive tests happen on all Linux machines. So the check to pass this flag is generalized like we do for all Linux ports on the build.webkit.org buildbot config. * CISupport/ews-build/config.json: * CISupport/ews-build/steps.py: (RunJavaScriptCoreTests.start): * CISupport/ews-build/steps_unittest.py: (TestRunJavaScriptCoreTests.test_remote_success): (TestRunJavaScriptCoreTests.test_dfg_air_and_stress_test_failure): (TestReRunJavaScriptCoreTests.test_remote_success):
Modified Paths
Diff
Modified: trunk/Tools/CISupport/ews-build/config.json (270347 => 270348)
--- trunk/Tools/CISupport/ews-build/config.json 2020-12-02 16:05:56 UTC (rev 270347)
+++ trunk/Tools/CISupport/ews-build/config.json 2020-12-02 16:39:03 UTC (rev 270348)
@@ -586,8 +586,7 @@
"platform": "jsc-only",
"configuration": "release",
"architectures": ["armv7"],
- "workernames": ["igalia-jsc32-armv7-ews"],
- "remotes": "../../EWS-test-devices.json"
+ "workernames": ["igalia-jsc32-armv7-ews-02"]
},
{
"name": "JSC-i386-32bits-EWS",
Modified: trunk/Tools/CISupport/ews-build/steps.py (270347 => 270348)
--- trunk/Tools/CISupport/ews-build/steps.py 2020-12-02 16:05:56 UTC (rev 270347)
+++ trunk/Tools/CISupport/ews-build/steps.py 2020-12-02 16:39:03 UTC (rev 270348)
@@ -1613,7 +1613,14 @@
platform = self.getProperty('platform')
if platform == 'jsc-only' and remotesfile:
- self.command.extend(['--no-testmasm', '--no-testair', '--no-testb3', '--no-testdfg', '--no-testapi', '--memory-limited'])
+ # FIXME: the bundle copied to the remote should include the testair, testb3, testapi, etc.. binaries
+ self.command.extend(['--no-testmasm', '--no-testair', '--no-testb3', '--no-testdfg', '--no-testapi'])
+
+ # Linux bots have currently problems with JSC tests that try to use large amounts of memory.
+ # Check: https://bugs.webkit.org/show_bug.cgi?id=175140
+ if platform in ('gtk', 'wpe', 'jsc-only'):
+ self.command.extend(['--memory-limited', '--verbose'])
+
appendCustomBuildFlags(self, self.getProperty('platform'), self.getProperty('fullPlatform'))
return shell.Test.start(self)
Modified: trunk/Tools/CISupport/ews-build/steps_unittest.py (270347 => 270348)
--- trunk/Tools/CISupport/ews-build/steps_unittest.py 2020-12-02 16:05:56 UTC (rev 270347)
+++ trunk/Tools/CISupport/ews-build/steps_unittest.py 2020-12-02 16:39:03 UTC (rev 270348)
@@ -1279,7 +1279,7 @@
self.expectRemoteCommands(
ExpectShell(workdir='wkdir',
logEnviron=False,
- command=['perl', 'Tools/Scripts/run-_javascript_core-tests', '--no-build', '--no-fail-fast', '--json-output={0}'.format(self.jsonFileName), '--release', '--remote-config-file=remote-machines.json', '--no-testmasm', '--no-testair', '--no-testb3', '--no-testdfg', '--no-testapi', '--memory-limited', '--jsc-only'],
+ command=['perl', 'Tools/Scripts/run-_javascript_core-tests', '--no-build', '--no-fail-fast', '--json-output={0}'.format(self.jsonFileName), '--release', '--remote-config-file=remote-machines.json', '--no-testmasm', '--no-testair', '--no-testb3', '--no-testdfg', '--no-testapi', '--memory-limited', '--verbose', '--jsc-only'],
logfiles={'json': self.jsonFileName},
)
+ 0,
@@ -1375,7 +1375,7 @@
ExpectShell(workdir='wkdir',
logEnviron=False,
logfiles={'json': self.jsonFileName},
- command=['perl', 'Tools/Scripts/run-_javascript_core-tests', '--no-build', '--no-fail-fast', '--json-output={0}'.format(self.jsonFileName), '--release', '--jsc-only'],
+ command=['perl', 'Tools/Scripts/run-_javascript_core-tests', '--no-build', '--no-fail-fast', '--json-output={0}'.format(self.jsonFileName), '--release', '--memory-limited', '--verbose', '--jsc-only'],
)
+ 2
+ ExpectShell.log('json', stdout=self.jsc_dfg_air_and_stress_test_failure),
@@ -1419,7 +1419,7 @@
self.expectRemoteCommands(
ExpectShell(workdir='wkdir',
logEnviron=False,
- command=['perl', 'Tools/Scripts/run-_javascript_core-tests', '--no-build', '--no-fail-fast', '--json-output={0}'.format(self.jsonFileName), '--release', '--remote-config-file=remote-machines.json', '--no-testmasm', '--no-testair', '--no-testb3', '--no-testdfg', '--no-testapi', '--memory-limited', '--jsc-only'],
+ command=['perl', 'Tools/Scripts/run-_javascript_core-tests', '--no-build', '--no-fail-fast', '--json-output={0}'.format(self.jsonFileName), '--release', '--remote-config-file=remote-machines.json', '--no-testmasm', '--no-testair', '--no-testb3', '--no-testdfg', '--no-testapi', '--memory-limited', '--verbose', '--jsc-only'],
logfiles={'json': self.jsonFileName},
) +
0,
Modified: trunk/Tools/ChangeLog (270347 => 270348)
--- trunk/Tools/ChangeLog 2020-12-02 16:05:56 UTC (rev 270347)
+++ trunk/Tools/ChangeLog 2020-12-02 16:39:03 UTC (rev 270348)
@@ -1,3 +1,30 @@
+2020-12-02 Carlos Alberto Lopez Perez <[email protected]>
+
+ Switch EWS workers for JSC-ARMv7-32bits build and test queues to a new machine.
+ https://bugs.webkit.org/show_bug.cgi?id=219189
+
+ Reviewed by Aakash Jain.
+
+ This switches the workers for the JSC-ARMv7-32bits-Build-EWS and
+ JSC-ARMv7-32bits-Test-EWS queues to a new ARM server that will run
+ things faster than the previous combination of cross-builder + RPis
+
+ Since now the tets run natively there is no need for passing the
+ "--remote-config-file" switch to the run-_javascript_core-tests script.
+
+ However "--memory-limited" is still needed because the issues with
+ failures on memory intensive tests happen on all Linux machines.
+ So the check to pass this flag is generalized like we do for all
+ Linux ports on the build.webkit.org buildbot config.
+
+ * CISupport/ews-build/config.json:
+ * CISupport/ews-build/steps.py:
+ (RunJavaScriptCoreTests.start):
+ * CISupport/ews-build/steps_unittest.py:
+ (TestRunJavaScriptCoreTests.test_remote_success):
+ (TestRunJavaScriptCoreTests.test_dfg_air_and_stress_test_failure):
+ (TestReRunJavaScriptCoreTests.test_remote_success):
+
2020-12-02 Tetsuharu Ohzeki <[email protected]>
Add Tetsuharu Ohzeki to contributors.json
_______________________________________________ webkit-changes mailing list [email protected] https://lists.webkit.org/mailman/listinfo/webkit-changes
