Title: [270416] trunk/Source/WebCore
Revision
270416
Author
[email protected]
Date
2020-12-03 16:07:04 -0800 (Thu, 03 Dec 2020)

Log Message

Use red color for sync wheel event handler debug overlay text
https://bugs.webkit.org/show_bug.cgi?id=219514

Reviewed by Tim Horton.

Use red for the "sync" wheel event handler debug overlay text.

* rendering/RenderLayerBacking.cpp:
(WebCore::patternForEventListenerRegionType):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (270415 => 270416)


--- trunk/Source/WebCore/ChangeLog	2020-12-04 00:02:09 UTC (rev 270415)
+++ trunk/Source/WebCore/ChangeLog	2020-12-04 00:07:04 UTC (rev 270416)
@@ -1,3 +1,15 @@
+2020-12-03  Simon Fraser  <[email protected]>
+
+        Use red color for sync wheel event handler debug overlay text
+        https://bugs.webkit.org/show_bug.cgi?id=219514
+
+        Reviewed by Tim Horton.
+
+        Use red for the "sync" wheel event handler debug overlay text.
+
+        * rendering/RenderLayerBacking.cpp:
+        (WebCore::patternForEventListenerRegionType):
+
 2020-12-03  Alex Christensen  <[email protected]>
 
         Serialize NFA to disk before converting it to a DFA when compiling a WKContentRuleList

Modified: trunk/Source/WebCore/rendering/RenderLayerBacking.cpp (270415 => 270416)


--- trunk/Source/WebCore/rendering/RenderLayerBacking.cpp	2020-12-04 00:02:09 UTC (rev 270415)
+++ trunk/Source/WebCore/rendering/RenderLayerBacking.cpp	2020-12-04 00:07:04 UTC (rev 270416)
@@ -3291,17 +3291,15 @@
 #if ENABLE(WHEEL_EVENT_REGIONS)
 static RefPtr<Pattern> patternForEventListenerRegionType(EventListenerRegionType type, FloatSize contentOffset, GraphicsContext& destContext)
 {
-    constexpr auto fillColor = Color::darkGreen.colorWithAlphaByte(128);
-
     auto patternAndPhase = [&]() -> PatternDescription {
         switch (type) {
         case EventListenerRegionType::Wheel:
-            return { "wheel"_s, { }, fillColor };
+            return { "wheel"_s, { }, Color::darkGreen.colorWithAlphaByte(128) };
         case EventListenerRegionType::NonPassiveWheel:
-            return { "sync"_s, { 0, 9 }, fillColor };
+            return { "sync"_s, { 0, 9 }, SRGBA<uint8_t> { 200, 0, 0, 128 } };
         }
         ASSERT_NOT_REACHED();
-        return { ""_s, { }, fillColor };
+        return { ""_s, { }, Color::black };
     }();
 
     return patternForDescription(patternAndPhase, contentOffset, destContext);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to