[webkit-changes] [105238] trunk/Source/WebCore

Tue, 17 Jan 2012 20:13:27 -0800

Title: [105238] trunk/Source/WebCore
Revision
105238
Author
le...@chromium.org
Date
2012-01-17 20:13:17 -0800 (Tue, 17 Jan 2012)

Log Message

Need to figure out which assert is firing when worker-read-blob-async.html fails.
https://bugs.webkit.org/show_bug.cgi?id=76503

Reviewed by Adam Barth.

No new functionality exposed so no new tests.

This is just a quick and dirty way to make these asserts unique
to expose which one of them is firing on a machine that doesn't have a
good stack trace.

* dom/ActiveDOMObject.cpp:
(WebCore::ContextDestructionObserver::ContextDestructionObserver):
(WebCore::ContextDestructionObserver::~ContextDestructionObserver):
(WebCore::ActiveDOMObject::ActiveDOMObject):
(WebCore::ActiveDOMObject::~ActiveDOMObject):
* storage/DatabaseSync.cpp:
(WebCore::DatabaseSync::openDatabaseSync):
(WebCore::DatabaseSync::~DatabaseSync):
(WebCore::DatabaseSync::changeVersion):
(WebCore::DatabaseSync::runTransaction):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (105237 => 105238)


--- trunk/Source/WebCore/ChangeLog	2012-01-18 04:02:07 UTC (rev 105237)
+++ trunk/Source/WebCore/ChangeLog	2012-01-18 04:13:17 UTC (rev 105238)
@@ -1,3 +1,27 @@
+2012-01-17  David Levin  <le...@chromium.org>
+
+        Need to figure out which assert is firing when worker-read-blob-async.html fails.
+        https://bugs.webkit.org/show_bug.cgi?id=76503
+
+        Reviewed by Adam Barth.
+
+        No new functionality exposed so no new tests.
+
+        This is just a quick and dirty way to make these asserts unique
+        to expose which one of them is firing on a machine that doesn't have a
+        good stack trace.
+
+        * dom/ActiveDOMObject.cpp:
+        (WebCore::ContextDestructionObserver::ContextDestructionObserver):
+        (WebCore::ContextDestructionObserver::~ContextDestructionObserver):
+        (WebCore::ActiveDOMObject::ActiveDOMObject):
+        (WebCore::ActiveDOMObject::~ActiveDOMObject):
+        * storage/DatabaseSync.cpp:
+        (WebCore::DatabaseSync::openDatabaseSync):
+        (WebCore::DatabaseSync::~DatabaseSync):
+        (WebCore::DatabaseSync::changeVersion):
+        (WebCore::DatabaseSync::runTransaction):
+
 2012-01-17  Matthew Delaney  <mdela...@apple.com>
 
         On post-Lion releases, preserve the Lion behavior where WebKit explicitly calls -setGeometryFlipped on the hosting layer for applications that were linked on Lion or earlier.

Modified: trunk/Source/WebCore/dom/ActiveDOMObject.cpp (105237 => 105238)


--- trunk/Source/WebCore/dom/ActiveDOMObject.cpp	2012-01-18 04:02:07 UTC (rev 105237)
+++ trunk/Source/WebCore/dom/ActiveDOMObject.cpp	2012-01-18 04:13:17 UTC (rev 105238)
@@ -39,7 +39,7 @@
     if (!m_scriptExecutionContext)
         return;
 
-    ASSERT(m_scriptExecutionContext->isContextThread());
+    ASSERT(m_scriptExecutionContext->isContextThread() && 1);
     m_scriptExecutionContext->didCreateDestructionObserver(this);
 }
 
@@ -48,7 +48,7 @@
     if (!m_scriptExecutionContext)
         return;
 
-    ASSERT(m_scriptExecutionContext->isContextThread());
+    ASSERT(m_scriptExecutionContext->isContextThread() && 2);
     m_scriptExecutionContext->willDestroyDestructionObserver(this);
 }
 
@@ -64,7 +64,7 @@
     if (!m_scriptExecutionContext)
         return;
 
-    ASSERT(m_scriptExecutionContext->isContextThread());
+    ASSERT(m_scriptExecutionContext->isContextThread() && 3);
     m_scriptExecutionContext->didCreateActiveDOMObject(this, upcastPointer);
 }
 
@@ -73,7 +73,7 @@
     if (!m_scriptExecutionContext)
         return;
 
-    ASSERT(m_scriptExecutionContext->isContextThread());
+    ASSERT(m_scriptExecutionContext->isContextThread() && 4);
     m_scriptExecutionContext->willDestroyActiveDOMObject(this);
 }

Modified: trunk/Source/WebCore/storage/DatabaseSync.cpp (105237 => 105238)


--- trunk/Source/WebCore/storage/DatabaseSync.cpp	2012-01-18 04:02:07 UTC (rev 105237)
+++ trunk/Source/WebCore/storage/DatabaseSync.cpp	2012-01-18 04:13:17 UTC (rev 105238)
@@ -50,7 +50,7 @@
 PassRefPtr<DatabaseSync> DatabaseSync::openDatabaseSync(ScriptExecutionContext* context, const String& name, const String& expectedVersion, const String& displayName,
                                                         unsigned long estimatedSize, PassRefPtr<DatabaseCallback> creationCallback, ExceptionCode& ec)
 {
-    ASSERT(context->isContextThread());
+    ASSERT(context->isContextThread() && 20);
 
     if (!DatabaseTracker::tracker().canEstablishDatabase(context, name, displayName, estimatedSize)) {
         LOG(StorageAPI, "Database %s for origin %s not allowed to be established", name.ascii().data(), context->securityOrigin()->toString().ascii().data());
@@ -84,7 +84,7 @@
 
 DatabaseSync::~DatabaseSync()
 {
-    ASSERT(m_scriptExecutionContext->isContextThread());
+    ASSERT(m_scriptExecutionContext->isContextThread() && 21);
 
     if (opened()) {
         DatabaseTracker::tracker().removeOpenDatabase(this);
@@ -94,7 +94,7 @@
 
 void DatabaseSync::changeVersion(const String& oldVersion, const String& newVersion, PassRefPtr<SQLTransactionSyncCallback> changeVersionCallback, ExceptionCode& ec)
 {
-    ASSERT(m_scriptExecutionContext->isContextThread());
+    ASSERT(m_scriptExecutionContext->isContextThread() && 22);
 
     if (sqliteDatabase().transactionInProgress()) {
         reportChangeVersionResult(1, SQLException::DATABASE_ERR, 0);
@@ -160,7 +160,7 @@
 
 void DatabaseSync::runTransaction(PassRefPtr<SQLTransactionSyncCallback> callback, bool readOnly, ExceptionCode& ec)
 {
-    ASSERT(m_scriptExecutionContext->isContextThread());
+    ASSERT(m_scriptExecutionContext->isContextThread() && 23);
 
     if (sqliteDatabase().transactionInProgress()) {
         setLastErrorMessage("unable to start a transaction from within a transaction");

_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to