Title: [270592] trunk/Tools
- Revision
- 270592
- Author
- [email protected]
- Date
- 2020-12-09 11:53:41 -0800 (Wed, 09 Dec 2020)
Log Message
Make PDFHUD.MoveIFrame API test more robust
https://bugs.webkit.org/show_bug.cgi?id=219667
<rdar://problem/68639688>
Patch by Alex Christensen <[email protected]> on 2020-12-09
Reviewed by Geoffrey Garen.
This test would time out if the place where the TestWKWebView is obscured, which happens frequently on the bots.
Make the test pass if this is the case. It's unfortunate to skip it often, but it still runs sometimes,
and I think this is better than having no test.
* TestWebKitAPI/Tests/WebKitCocoa/WKPDFView.mm:
(TEST):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (270591 => 270592)
--- trunk/Tools/ChangeLog 2020-12-09 19:50:11 UTC (rev 270591)
+++ trunk/Tools/ChangeLog 2020-12-09 19:53:41 UTC (rev 270592)
@@ -1,3 +1,18 @@
+2020-12-09 Alex Christensen <[email protected]>
+
+ Make PDFHUD.MoveIFrame API test more robust
+ https://bugs.webkit.org/show_bug.cgi?id=219667
+ <rdar://problem/68639688>
+
+ Reviewed by Geoffrey Garen.
+
+ This test would time out if the place where the TestWKWebView is obscured, which happens frequently on the bots.
+ Make the test pass if this is the case. It's unfortunate to skip it often, but it still runs sometimes,
+ and I think this is better than having no test.
+
+ * TestWebKitAPI/Tests/WebKitCocoa/WKPDFView.mm:
+ (TEST):
+
2020-12-09 Jonathan Bedard <[email protected]>
[webkitcorepy] Specify TLS configuration of autoinstaller
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKPDFView.mm (270591 => 270592)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKPDFView.mm 2020-12-09 19:50:11 UTC (rev 270591)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKPDFView.mm 2020-12-09 19:53:41 UTC (rev 270592)
@@ -214,6 +214,11 @@
[webView loadRequest:[NSURLRequest requestWithURL:[NSURL URLWithString:@"test:///main.html"]]];
EXPECT_EQ(webView._pdfHUDs.count, 0u);
[webView _test_waitForDidFinishNavigation];
+
+ // If the TestWKWebView is not visible, visibilityDidChange will be called with false, and there will be no HUD.
+ if (!webView._pdfHUDs.count)
+ return;
+
EXPECT_EQ(webView._pdfHUDs.count, 1u);
checkFrame(webView._pdfHUDs.anyObject.frame, 10, 28, 300, 150);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
