Title: [270765] trunk
- Revision
- 270765
- Author
- [email protected]
- Date
- 2020-12-14 02:35:05 -0800 (Mon, 14 Dec 2020)
Log Message
REGRESSSION(270435) [GStreamer] Many media source tests failing and timing out
https://bugs.webkit.org/show_bug.cgi?id=219565
Reviewed by Philippe Normand.
Source/WebCore:
Fix the recursing calls due to the refactoring of `SourceBufferPrivate`.
(As Philippe Normand pointed out and Peng Liu added in the first
version of the patch).
Also fix the didReceiveInitializationSegment signature after r270612.
Covered by existing tests.
* platform/graphics/gstreamer/mse/AppendPipeline.cpp:
(WebCore::AppendPipeline::didReceiveInitializationSegment):
* platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp:
(WebCore::SourceBufferPrivateGStreamer::didReceiveInitializationSegment):
(WebCore::SourceBufferPrivateGStreamer::didReceiveSample):
* platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.h:
LayoutTests:
Revert the gardened expectations and garden remaining failures.
* platform/glib/TestExpectations:
* platform/gtk/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (270764 => 270765)
--- trunk/LayoutTests/ChangeLog 2020-12-14 10:32:10 UTC (rev 270764)
+++ trunk/LayoutTests/ChangeLog 2020-12-14 10:35:05 UTC (rev 270765)
@@ -1,3 +1,15 @@
+2020-12-14 Lauro Moura <[email protected]>
+
+ REGRESSSION(270435) [GStreamer] Many media source tests failing and timing out
+ https://bugs.webkit.org/show_bug.cgi?id=219565
+
+ Reviewed by Philippe Normand.
+
+ Revert the gardened expectations and garden remaining failures.
+
+ * platform/glib/TestExpectations:
+ * platform/gtk/TestExpectations:
+
2020-12-13 Andy Estes <[email protected]>
[Mac] Create a MediaToolbox format reader plug-in for WebM
Modified: trunk/LayoutTests/platform/glib/TestExpectations (270764 => 270765)
--- trunk/LayoutTests/platform/glib/TestExpectations 2020-12-14 10:32:10 UTC (rev 270764)
+++ trunk/LayoutTests/platform/glib/TestExpectations 2020-12-14 10:35:05 UTC (rev 270765)
@@ -435,7 +435,7 @@
webkit.org/b/203078 media/media-source/media-source-remove-unload-crash.html [ Crash Timeout Pass ]
webkit.org/b/210528 media/media-source/media-source-seek-back.html [ Crash Pass ]
webkit.org/b/214636 media/media-source/media-source-webm.html [ Timeout Crash ]
-webkit.org/b/218317 webkit.org/b/219565 media/media-source/media-source-trackid-change.html [ Failure Timeout ]
+webkit.org/b/218317 media/media-source/media-source-trackid-change.html [ Failure ]
webkit.org/b/210528 media/video-src-blob-replay.html [ Crash Pass ]
@@ -460,39 +460,27 @@
webkit.org/b/219245 webrtc/peer-connection-remote-audio-mute.html [ Crash ]
webkit.org/b/219245 webrtc/peer-connection-remote-audio-mute2.html [ Crash ]
-webkit.org/b/219565 media/media-source/media-source-abort-resets-parser.html [ Timeout ]
-webkit.org/b/219565 media/media-source/media-source-canplaythrough-event.html [ Timeout ]
-webkit.org/b/219565 media/media-source/media-source-error-crash.html [ Timeout ]
-webkit.org/b/219565 media/media-source/media-source-paint-to-canvas.html [ Timeout ]
-webkit.org/b/219565 media/media-source/media-source-remove-crash.html [ Timeout ]
-webkit.org/b/219565 media/media-source/media-source-resize.html [ Timeout ]
-webkit.org/b/219565 media/media-source/media-source-samples-resolution-change.html [ Timeout ]
-webkit.org/b/219565 media/media-source/media-source-seek-detach-crash.html [ Timeout ]
-webkit.org/b/219565 media/media-source/media-source-seek-redundant-append.html [ Timeout ]
-webkit.org/b/219565 media/media-source/media-source-seek-twice.html [ Timeout ]
-webkit.org/b/219565 media/media-source/media-source-stalled-holds-sleep-assertion.html [ Timeout ]
-webkit.org/b/219565 media/media-source/media-source-unnecessary-seek-seeked.html [ Timeout ]
-webkit.org/b/219565 media/media-source/media-source-webm-init-inside-segment.html [ Timeout ]
-webkit.org/b/219565 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-clear-encrypted.https.html [ Timeout ]
-webkit.org/b/219565 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-encrypted-clear-sources.https.html [ Timeout ]
-webkit.org/b/219565 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-encrypted-clear.https.html [ Timeout ]
-webkit.org/b/219565 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-events.https.html [ Timeout ]
-webkit.org/b/219565 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-multikey-sequential-readyState.https.html [ Timeout ]
-webkit.org/b/219565 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-multikey-sequential.https.html [ Timeout ]
-webkit.org/b/219565 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-multikey.https.html [ Timeout ]
-webkit.org/b/219565 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-multisession.https.html [ Timeout ]
-webkit.org/b/219565 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-setMediaKeys-after-src.https.html [ Timeout ]
-webkit.org/b/219565 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-setMediaKeys-after-update.https.html [ Timeout ]
-webkit.org/b/219565 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-setMediaKeys-onencrypted.https.html [ Timeout ]
-webkit.org/b/219565 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-two-videos.https.html [ Timeout ]
-webkit.org/b/219565 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-waitingforkey.https.html [ Timeout ]
-webkit.org/b/219565 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary.https.html [ Timeout ]
-webkit.org/b/219565 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-again-after-playback.https.html [ Timeout ]
-webkit.org/b/219565 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-again-after-resetting-src.https.html [ Timeout ]
-webkit.org/b/219565 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-waiting-for-a-key.https.html [ Timeout ]
-webkit.org/b/219565 imported/w3c/web-platform-tests/media-source/ [ Timeout ]
+# Seek failures likely related to r270612
+webkit.org/b/219822 imported/w3c/web-platform-tests/media-source/mediasource-buffered-seek.html [ Failure ]
+webkit.org/b/219822 imported/w3c/web-platform-tests/media-source/mediasource-changetype-play-negative.html [ Failure ]
+webkit.org/b/219822 imported/w3c/web-platform-tests/media-source/mediasource-config-change-webm-av-video-bitrate.html [ Pass Failure ]
+webkit.org/b/219822 imported/w3c/web-platform-tests/media-source/mediasource-h264-play-starved.html [ Failure ]
+webkit.org/b/219822 imported/w3c/web-platform-tests/media-source/mediasource-liveseekable.html [ Failure ]
+webkit.org/b/219822 imported/w3c/web-platform-tests/media-source/mediasource-play-then-seek-back.html [ Failure ]
+webkit.org/b/219822 imported/w3c/web-platform-tests/media-source/mediasource-redundant-seek.html [ Failure ]
+webkit.org/b/219822 imported/w3c/web-platform-tests/media-source/mediasource-seek-during-pending-seek.html [ Failure ]
+webkit.org/b/219822 imported/w3c/web-platform-tests/media-source/mediasource-seekable.html [ Failure ]
+webkit.org/b/219822 imported/w3c/web-platform-tests/media-source/mediasource-sequencemode-append-buffer.html [ Failure ]
+webkit.org/b/219822 media/media-source/media-source-canplaythrough-event.html [ Failure ]
+webkit.org/b/219822 media/media-source/media-source-stalled-holds-sleep-assertion.html [ Failure ]
+webkit.org/b/219822 media/media-source/media-source-unnecessary-seek-seeked.html [ Failure ]
+webkit.org/b/219822 imported/w3c/web-platform-tests/media-source/mediasource-video-is-visible.html [ Timeout ]
+webkit.org/b/219822 media/encrypted-media/clearKey/clearKey-cenc-audio-playback-mse.html [ Timeout ]
+webkit.org/b/219822 media/encrypted-media/clearKey/clearKey-cenc-video-playback-mse.html [ Timeout ]
+webkit.org/b/219822 media/media-source/media-source-paint-to-canvas.html [ Timeout ]
+webkit.org/b/219822 media/media-source/media-source-seek-redundant-append.html [ Timeout ]
+webkit.org/b/219822 media/media-source/media-source-seek-twice.html [ Timeout ]
-
#////////////////////////////////////////////////////////////////////////////////////////
# End of GStreamer-related bugs
#////////////////////////////////////////////////////////////////////////////////////////
@@ -1241,49 +1229,49 @@
webkit.org/b/211840 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-destroy-persistent-license.https.html [ Failure ]
webkit.org/b/190991 imported/w3c/web-platform-tests/encrypted-media/clearkey-check-status-for-hdcp.https.html [ Failure ]
webkit.org/b/211375 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-clear-encrypted-segmented.https.html [ Skip ]
-# Uncomment after bug219565 webkit.org/b/198830 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary.https.html [ Crash Pass ]
+webkit.org/b/198830 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary.https.html [ Crash Pass ]
webkit.org/b/210113 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-reset-src-after-setmediakeys.https.html [ Failure Pass ]
-# Ditto webkit.org/b/210390 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-again-after-resetting-src.https.html [ Crash Pass ]
-# Ditto webkit.org/b/210965 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-multikey-sequential-readyState.https.html [ Failure ]
-# Ditto webkit.org/b/210966 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-again-after-playback.https.html [ Crash Pass ]
+webkit.org/b/210390 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-again-after-resetting-src.https.html [ Crash Pass ]
+webkit.org/b/210965 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-multikey-sequential-readyState.https.html [ Failure ]
+webkit.org/b/210966 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-again-after-playback.https.html [ Crash Pass ]
webkit.org/b/178707 imported/w3c/web-platform-tests/encrypted-media/encrypted-media-default-feature-policy.https.sub.html [ Skip ]
-# Uncomment the lines below once bug219565 is fixed
-#imported/w3c/web-platform-tests/encrypted-media/clearkey-check-encryption-scheme.https.html [ Pass ]
-#imported/w3c/web-platform-tests/encrypted-media/clearkey-check-initdata-type.https.html [ Pass ]
-#imported/w3c/web-platform-tests/encrypted-media/clearkey-events.https.html [ Pass ]
-#imported/w3c/web-platform-tests/encrypted-media/clearkey-events-session-closed-event.https.html [ Pass ]
-#imported/w3c/web-platform-tests/encrypted-media/clearkey-generate-request-disallowed-input.https.html [ Pass ]
-#imported/w3c/web-platform-tests/encrypted-media/clearkey-invalid-license.https.html [ Pass ]
-#imported/w3c/web-platform-tests/encrypted-media/clearkey-keystatuses.https.html [ Pass ]
-#imported/w3c/web-platform-tests/encrypted-media/clearkey-keystatuses-multiple-sessions.https.html [ Pass ]
-#imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-clear-encrypted.https.html [ Pass ]
-#imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-encrypted-clear.https.html [ Pass ]
-#imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-encrypted-clear-sources.https.html [ Pass ]
-#imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-events.https.html [ Pass ]
-#imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-multikey.https.html [ Pass ]
-#imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-multikey-sequential.https.html [ Pass ]
-#imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-multisession.https.html [ Pass ]
-#imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-setMediaKeys-after-src.https.html [ Pass ]
-#imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-setMediaKeys-after-update.https.html [ Pass ]
-#imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-setMediaKeys-onencrypted.https.html [ Pass ]
-#imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-two-videos.https.html [ Pass ]
-#imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-waitingforkey.https.html [ Pass ]
-#imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-requestmediakeysystemaccess.https.html [ Pass ]
-#imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-at-same-time.https.html [ Pass ]
-#imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys.https.html [ Pass ]
-#imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-multiple-times-with-different-mediakeys.https.html [ Pass ]
-#imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-multiple-times-with-the-same-mediakeys.https.html [ Pass ]
-#imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-to-multiple-video-elements.https.html [ Pass ]
-#imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-syntax-mediakeysession.https.html [ Pass ]
-#imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-syntax-mediakeys.https.html [ Pass ]
-#imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-syntax-mediakeysystemaccess.https.html [ Pass ]
-#imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-unique-origin.https.html [ Pass ]
-#imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-update-disallowed-input.https.html [ Pass ]
-#imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-waiting-for-a-key.https.html [ Pass ]
-#imported/w3c/web-platform-tests/encrypted-media/clearkey-not-callable-after-createsession.https.html [ Pass ]
-#imported/w3c/web-platform-tests/encrypted-media/clearkey-update-non-ascii-input.https.html [ Pass ]
+imported/w3c/web-platform-tests/encrypted-media/clearkey-check-encryption-scheme.https.html [ Pass ]
+imported/w3c/web-platform-tests/encrypted-media/clearkey-check-initdata-type.https.html [ Pass ]
+imported/w3c/web-platform-tests/encrypted-media/clearkey-events.https.html [ Pass ]
+imported/w3c/web-platform-tests/encrypted-media/clearkey-events-session-closed-event.https.html [ Pass ]
+imported/w3c/web-platform-tests/encrypted-media/clearkey-generate-request-disallowed-input.https.html [ Pass ]
+imported/w3c/web-platform-tests/encrypted-media/clearkey-invalid-license.https.html [ Pass ]
+imported/w3c/web-platform-tests/encrypted-media/clearkey-keystatuses.https.html [ Pass ]
+imported/w3c/web-platform-tests/encrypted-media/clearkey-keystatuses-multiple-sessions.https.html [ Pass ]
+imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-clear-encrypted.https.html [ Pass ]
+imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-encrypted-clear.https.html [ Pass ]
+imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-encrypted-clear-sources.https.html [ Pass ]
+imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-events.https.html [ Pass ]
+imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-multikey.https.html [ Pass ]
+imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-multikey-sequential.https.html [ Pass ]
+imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-multisession.https.html [ Pass ]
+imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-setMediaKeys-after-src.https.html [ Pass ]
+imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-setMediaKeys-after-update.https.html [ Pass ]
+imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-setMediaKeys-onencrypted.https.html [ Pass ]
+imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-two-videos.https.html [ Pass ]
+imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-waitingforkey.https.html [ Pass ]
+imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-requestmediakeysystemaccess.https.html [ Pass ]
+imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-at-same-time.https.html [ Pass ]
+imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys.https.html [ Pass ]
+imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-multiple-times-with-different-mediakeys.https.html [ Pass ]
+imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-multiple-times-with-the-same-mediakeys.https.html [ Pass ]
+imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-to-multiple-video-elements.https.html [ Pass ]
+imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-syntax-mediakeysession.https.html [ Pass ]
+imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-syntax-mediakeys.https.html [ Pass ]
+imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-syntax-mediakeysystemaccess.https.html [ Pass ]
+imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-unique-origin.https.html [ Pass ]
+imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-update-disallowed-input.https.html [ Pass ]
+imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-waiting-for-a-key.https.html [ Pass ]
+imported/w3c/web-platform-tests/encrypted-media/clearkey-not-callable-after-createsession.https.html [ Pass ]
+imported/w3c/web-platform-tests/encrypted-media/clearkey-update-non-ascii-input.https.html [ Pass ]
+
#////////////////////////////////////////////////////////////////////////////////////////
# End of EME feature
#////////////////////////////////////////////////////////////////////////////////////////
@@ -1680,7 +1668,7 @@
webkit.org/b/169917 webgl/1.0.3/conformance/rendering/many-draw-calls.html [ Slow ]
webkit.org/b/169917 webgl/1.0.3/conformance/uniforms/gl-uniform-arrays.html [ Slow ]
webkit.org/b/169917 webgl/1.0.3/conformance/uniforms/out-of-bounds-uniform-array-access.html [ Slow ]
-webkit.org/b/219565 webkit.org/b/171726 media/media-source/media-source-init-segment-duration.html [ Failure Timeout ]
+webkit.org/b/171726 media/media-source/media-source-init-segment-duration.html [ Failure ]
webkit.org/b/172270 fast/text/web-font-load-invisible-during-loading.html [ Failure ]
webkit.org/b/172271 fast/text/emoji-overlap.html [ ImageOnlyFailure ]
webkit.org/b/172271 fast/text/system-font-fallback-emoji.html [ Failure ]
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (270764 => 270765)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2020-12-14 10:32:10 UTC (rev 270764)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2020-12-14 10:35:05 UTC (rev 270765)
@@ -401,56 +401,31 @@
# MSE failures
webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/URL-createObjectURL-revoke.html [ Failure ]
-# Timing out after r270435.
-webkit.org/b/219565 http/tests/media/media-source/mediasource-play-then-seek-back-with-remote-control.html [ Skip ]
-webkit.org/b/219565 imported/w3c/web-platform-tests/media-source/mediasource-activesourcebuffers.html [ Skip ]
-webkit.org/b/219565 imported/w3c/web-platform-tests/media-source/mediasource-append-buffer.html [ Skip ]
-webkit.org/b/219565 imported/w3c/web-platform-tests/media-source/mediasource-avtracks.html [ Skip ]
-webkit.org/b/219565 imported/w3c/web-platform-tests/media-source/mediasource-buffered.html [ Skip ]
-webkit.org/b/219565 imported/w3c/web-platform-tests/media-source/mediasource-changetype.html [ Skip ]
-webkit.org/b/219565 imported/w3c/web-platform-tests/media-source/mediasource-duration.html [ Skip ]
-webkit.org/b/219565 imported/w3c/web-platform-tests/media-source/mediasource-endofstream.html [ Skip ]
-webkit.org/b/219565 imported/w3c/web-platform-tests/media-source/mediasource-errors.html [ Skip ]
-webkit.org/b/219565 imported/w3c/web-platform-tests/media-source/mediasource-removesourcebuffer.html [ Skip ]
-webkit.org/b/219565 imported/w3c/web-platform-tests/media-source/mediasource-duration-boundaryconditions.html [ Skip ]
-webkit.org/b/219565 imported/w3c/web-platform-tests/media-source/mediasource-correct-frames.html [ Skip ]
-webkit.org/b/219565 imported/w3c/web-platform-tests/media-source/mediasource-config-change-mp4-v-framesize.html [ Skip ]
-webkit.org/b/219565 imported/w3c/web-platform-tests/media-source/mediasource-replay.html [ Skip ]
-webkit.org/b/219565 imported/w3c/web-platform-tests/media-source/mediasource-seek-beyond-duration.html [ Skip ]
-webkit.org/b/219565 imported/w3c/web-platform-tests/media-source/mediasource-changetype-play.html [ Skip ]
-webkit.org/b/219565 imported/w3c/web-platform-tests/media-source/mediasource-correct-frames-after-reappend.html [ Skip ]
-webkit.org/b/219565 media/encrypted-media/clearKey/clearKey-cenc-audio-playback-mse.html [ Skip ]
-webkit.org/b/219565 media/encrypted-media/clearKey/clearKey-cenc-video-playback-mse.html [ Skip ]
-webkit.org/b/219565 media/encrypted-media/clearKey/clearKey-message-cenc-event-mse.html [ Skip ]
-webkit.org/b/219565 media/encrypted-media/clearKey/clearKey-webm-video-playback-mse.html [ Skip ]
-# REGRESSION(r270435). Uncomment failures below after bug is fixed.
# See also bug #175578.
-# webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-activesourcebuffers.html [ Failure ]
-# webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-append-buffer.html [ Failure ]
-# webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-avtracks.html [ Failure ]
-# webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-buffered.html [ Failure ]
-# webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-changetype.html [ Failure Crash ]
+webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-activesourcebuffers.html [ Failure ]
+webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-append-buffer.html [ Failure ]
+webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-avtracks.html [ Failure ]
+webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-buffered.html [ Failure ]
+webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-changetype.html [ Failure Crash ]
# Crash is webkit.org/b/176020.
-# webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-duration.html [ Failure ]
+webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-duration.html [ Failure ]
# Crash in bug #176019.
-# webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-endofstream.html [ Failure ]
-# webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-errors.html [ Failure ]
-# webkit.org/b/210486 imported/w3c/web-platform-tests/media-source/mediasource-correct-frames-after-reappend.html [ Failure Crash Pass ]
+webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-endofstream.html [ Failure ]
+webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-errors.html [ Failure ]
+webkit.org/b/210486 imported/w3c/web-platform-tests/media-source/mediasource-correct-frames-after-reappend.html [ Failure Crash Pass ]
# Known issues that were fixed by the WebKitMediaSrc rework that is now reverted.
-# webkit.org/b/203078 imported/w3c/web-platform-tests/media-source/mediasource-seek-beyond-duration.html [ Failure ]
-# webkit.org/b/203078 imported/w3c/web-platform-tests/media-source/mediasource-replay.html [ Failure Crash ]
-# webkit.org/b/203078 imported/w3c/web-platform-tests/media-source/mediasource-config-change-mp4-v-framesize.html [ Pass Failure ]
+webkit.org/b/203078 imported/w3c/web-platform-tests/media-source/mediasource-seek-beyond-duration.html [ Failure ]
+webkit.org/b/203078 imported/w3c/web-platform-tests/media-source/mediasource-replay.html [ Failure Crash ]
+webkit.org/b/203078 imported/w3c/web-platform-tests/media-source/mediasource-config-change-mp4-v-framesize.html [ Pass Failure ]
-# webkit.org/b/176020 imported/w3c/web-platform-tests/media-source/mediasource-removesourcebuffer.html [ Crash Pass ]
-# webkit.org/b/180803 imported/w3c/web-platform-tests/media-source/mediasource-duration-boundaryconditions.html [ Failure ]
-# webkit.org/b/197711 imported/w3c/web-platform-tests/media-source/mediasource-correct-frames.html [ Pass Failure ]
-# webkit.org/b/205110 imported/w3c/web-platform-tests/media-source/mediasource-changetype-play.html [ Failure Crash Pass ]
-#
-# End of REGRESSION(r270435).
+webkit.org/b/176020 imported/w3c/web-platform-tests/media-source/mediasource-removesourcebuffer.html [ Crash Pass ]
+webkit.org/b/180803 imported/w3c/web-platform-tests/media-source/mediasource-duration-boundaryconditions.html [ Failure ]
+webkit.org/b/197711 imported/w3c/web-platform-tests/media-source/mediasource-correct-frames.html [ Pass Failure ]
+webkit.org/b/205110 imported/w3c/web-platform-tests/media-source/mediasource-changetype-play.html [ Failure Crash Pass ]
webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-preload.html [ Failure ]
webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-trackdefaultlist.html [ Failure ]
Modified: trunk/Source/WebCore/ChangeLog (270764 => 270765)
--- trunk/Source/WebCore/ChangeLog 2020-12-14 10:32:10 UTC (rev 270764)
+++ trunk/Source/WebCore/ChangeLog 2020-12-14 10:35:05 UTC (rev 270765)
@@ -1,3 +1,25 @@
+2020-12-14 Lauro Moura <[email protected]>
+
+ REGRESSSION(270435) [GStreamer] Many media source tests failing and timing out
+ https://bugs.webkit.org/show_bug.cgi?id=219565
+
+ Reviewed by Philippe Normand.
+
+ Fix the recursing calls due to the refactoring of `SourceBufferPrivate`.
+ (As Philippe Normand pointed out and Peng Liu added in the first
+ version of the patch).
+
+ Also fix the didReceiveInitializationSegment signature after r270612.
+
+ Covered by existing tests.
+
+ * platform/graphics/gstreamer/mse/AppendPipeline.cpp:
+ (WebCore::AppendPipeline::didReceiveInitializationSegment):
+ * platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp:
+ (WebCore::SourceBufferPrivateGStreamer::didReceiveInitializationSegment):
+ (WebCore::SourceBufferPrivateGStreamer::didReceiveSample):
+ * platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.h:
+
2020-12-13 Yusuke Suzuki <[email protected]>
[JSC] Introduce vmEntryCustomAccessor and vmEntryHostFunction for JITCage
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp (270764 => 270765)
--- trunk/Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp 2020-12-14 10:32:10 UTC (rev 270764)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp 2020-12-14 10:35:05 UTC (rev 270765)
@@ -528,7 +528,7 @@
break;
}
- m_sourceBufferPrivate.didReceiveInitializationSegment(initializationSegment);
+ m_sourceBufferPrivate.didReceiveInitializationSegment(WTFMove(initializationSegment), []() { });
}
AtomString AppendPipeline::trackId()
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp (270764 => 270765)
--- trunk/Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp 2020-12-14 10:32:10 UTC (rev 270764)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp 2020-12-14 10:35:05 UTC (rev 270765)
@@ -181,14 +181,14 @@
m_trackId = trackId;
}
-void SourceBufferPrivateGStreamer::didReceiveInitializationSegment(const SourceBufferPrivateClient::InitializationSegment& initializationSegment)
+void SourceBufferPrivateGStreamer::didReceiveInitializationSegment(SourceBufferPrivateClient::InitializationSegment&& initializationSegment, CompletionHandler<void()>&& completionHandler)
{
- didReceiveInitializationSegment(initializationSegment);
+ SourceBufferPrivate::didReceiveInitializationSegment(WTFMove(initializationSegment), WTFMove(completionHandler));
}
void SourceBufferPrivateGStreamer::didReceiveSample(MediaSample& sample)
{
- didReceiveSample(sample);
+ SourceBufferPrivate::didReceiveSample(sample);
}
void SourceBufferPrivateGStreamer::didReceiveAllPendingSamples()
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.h (270764 => 270765)
--- trunk/Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.h 2020-12-14 10:32:10 UTC (rev 270764)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.h 2020-12-14 10:35:05 UTC (rev 270765)
@@ -72,7 +72,7 @@
void setReadyForMoreSamples(bool);
void notifyReadyForMoreSamples();
- void didReceiveInitializationSegment(const SourceBufferPrivateClient::InitializationSegment&);
+ void didReceiveInitializationSegment(SourceBufferPrivateClient::InitializationSegment&&, CompletionHandler<void()>&&);
void didReceiveSample(MediaSample&);
void didReceiveAllPendingSamples();
void appendParsingFailed();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
