Title: [105289] trunk/Source
Revision
105289
Author
commit-qu...@webkit.org
Date
2012-01-18 10:06:55 -0800 (Wed, 18 Jan 2012)

Log Message

[GTK] Listen to GDK_SCROLL_MASK
https://bugs.webkit.org/show_bug.cgi?id=76529

Source/WebKit/gtk:

Set GDK_SCROLL_MASK explicitly, as WebKitWebView does handle
scroll events, scrolling currently works because GTK+ happens
to send such events to widgets listening to GDK_BUTTON_PRESS_MASK,
but this isn't the intended behavior, so it's subject to change.

Patch by Carlos Garnacho <carl...@gnome.org> on 2012-01-18
Reviewed by Martin Robinson.

* webkit/webkitwebview.cpp:
(webkit_web_view_realize):

Source/WebKit2:

Set GDK_SCROLL_MASK explicitly, as WebKitWebViewBase does handle
scroll events, scrolling currently works because GTK+ happens
to send such events to widgets listening to GDK_BUTTON_PRESS_MASK,
but this isn't the intended behavior, so it's subject to change.

Patch by Carlos Garnacho <carl...@gnome.org> on 2012-01-18
Reviewed by Martin Robinson.

* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseRealize):

Modified Paths

Diff

Modified: trunk/Source/WebKit/gtk/ChangeLog (105288 => 105289)


--- trunk/Source/WebKit/gtk/ChangeLog	2012-01-18 17:56:42 UTC (rev 105288)
+++ trunk/Source/WebKit/gtk/ChangeLog	2012-01-18 18:06:55 UTC (rev 105289)
@@ -1,3 +1,18 @@
+2012-01-18  Carlos Garnacho  <carl...@gnome.org>
+
+        [GTK] Listen to GDK_SCROLL_MASK
+        https://bugs.webkit.org/show_bug.cgi?id=76529
+
+        Set GDK_SCROLL_MASK explicitly, as WebKitWebView does handle
+        scroll events, scrolling currently works because GTK+ happens 
+        to send such events to widgets listening to GDK_BUTTON_PRESS_MASK,
+        but this isn't the intended behavior, so it's subject to change.
+
+        Reviewed by Martin Robinson.
+
+        * webkit/webkitwebview.cpp:
+        (webkit_web_view_realize):
+
 2012-01-17  Martin Robinson  <mrobin...@igalia.com>
 
         [Gtk] Input text field not repainted when value is changed

Modified: trunk/Source/WebKit/gtk/webkit/webkitwebview.cpp (105288 => 105289)


--- trunk/Source/WebKit/gtk/webkit/webkitwebview.cpp	2012-01-18 17:56:42 UTC (rev 105288)
+++ trunk/Source/WebKit/gtk/webkit/webkitwebview.cpp	2012-01-18 18:06:55 UTC (rev 105289)
@@ -961,6 +961,7 @@
                             | GDK_EXPOSURE_MASK
                             | GDK_BUTTON_PRESS_MASK
                             | GDK_BUTTON_RELEASE_MASK
+                            | GDK_SCROLL_MASK
                             | GDK_POINTER_MOTION_MASK
                             | GDK_KEY_PRESS_MASK
                             | GDK_KEY_RELEASE_MASK

Modified: trunk/Source/WebKit2/ChangeLog (105288 => 105289)


--- trunk/Source/WebKit2/ChangeLog	2012-01-18 17:56:42 UTC (rev 105288)
+++ trunk/Source/WebKit2/ChangeLog	2012-01-18 18:06:55 UTC (rev 105289)
@@ -1,3 +1,18 @@
+2012-01-18  Carlos Garnacho  <carl...@gnome.org>
+
+        [GTK] Listen to GDK_SCROLL_MASK
+        https://bugs.webkit.org/show_bug.cgi?id=76529
+
+        Set GDK_SCROLL_MASK explicitly, as WebKitWebViewBase does handle
+        scroll events, scrolling currently works because GTK+ happens 
+        to send such events to widgets listening to GDK_BUTTON_PRESS_MASK,
+        but this isn't the intended behavior, so it's subject to change.
+
+        Reviewed by Martin Robinson.
+
+        * UIProcess/API/gtk/WebKitWebViewBase.cpp:
+        (webkitWebViewBaseRealize):
+
 2012-01-18  Andras Becsi  <andras.be...@nokia.com>
 
         [Qt][WK2] Fix the debug build.

Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp (105288 => 105289)


--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp	2012-01-18 17:56:42 UTC (rev 105288)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp	2012-01-18 18:06:55 UTC (rev 105289)
@@ -118,6 +118,7 @@
         | GDK_EXPOSURE_MASK
         | GDK_BUTTON_PRESS_MASK
         | GDK_BUTTON_RELEASE_MASK
+        | GDK_SCROLL_MASK
         | GDK_POINTER_MOTION_MASK
         | GDK_KEY_PRESS_MASK
         | GDK_KEY_RELEASE_MASK
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to