Title: [270953] trunk/Tools
Revision
270953
Author
[email protected]
Date
2020-12-17 15:17:38 -0800 (Thu, 17 Dec 2020)

Log Message

[run-webkit-tests] Replace FailureNotTested with FailureNoOutput
https://bugs.webkit.org/show_bug.cgi?id=219994
<rdar://problem/72440201>

Reviewed by Geoffrey Garen.

* Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner._compare_text): Replace FailureNotTest with FailureNoOutput.
* Scripts/webkitpy/layout_tests/models/test_failures.py:
(determine_result_type): Replace FailureNotTest with FailureNoOutput.
(FailureNoOutput): Renamed from FailureNotTested.
(FailureNotTested): Renamed to FailureNoOutput.
* Scripts/webkitpy/layout_tests/models/test_failures_unittest.py:
(TestFailuresTest.test_all_failure_classes): Replace FailureNotTest with FailureNoOutput.

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (270952 => 270953)


--- trunk/Tools/ChangeLog	2020-12-17 23:14:47 UTC (rev 270952)
+++ trunk/Tools/ChangeLog	2020-12-17 23:17:38 UTC (rev 270953)
@@ -1,5 +1,22 @@
 2020-12-17  Jonathan Bedard  <[email protected]>
 
+        [run-webkit-tests] Replace FailureNotTested with FailureNoOutput
+        https://bugs.webkit.org/show_bug.cgi?id=219994
+        <rdar://problem/72440201>
+
+        Reviewed by Geoffrey Garen.
+
+        * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
+        (SingleTestRunner._compare_text): Replace FailureNotTest with FailureNoOutput.
+        * Scripts/webkitpy/layout_tests/models/test_failures.py:
+        (determine_result_type): Replace FailureNotTest with FailureNoOutput.
+        (FailureNoOutput): Renamed from FailureNotTested.
+        (FailureNotTested): Renamed to FailureNoOutput.
+        * Scripts/webkitpy/layout_tests/models/test_failures_unittest.py:
+        (TestFailuresTest.test_all_failure_classes): Replace FailureNotTest with FailureNoOutput.
+
+2020-12-17  Jonathan Bedard  <[email protected]>
+
         [webkitscmpy] Capture Mock process logging during tests 
         https://bugs.webkit.org/show_bug.cgi?id=219989
         <rdar://problem/72435662>

Modified: trunk/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py (270952 => 270953)


--- trunk/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py	2020-12-17 23:14:47 UTC (rev 270952)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py	2020-12-17 23:17:38 UTC (rev 270953)
@@ -243,7 +243,7 @@
         elif actual_text and not expected_text:
             failures.append(test_failures.FailureMissingResult())
         elif not actual_text and expected_text:
-            failures.append(test_failures.FailureNotTested())
+            failures.append(test_failures.FailureNoOutput())
         return failures
 
     def _compare_audio(self, expected_audio, actual_audio):

Modified: trunk/Tools/Scripts/webkitpy/layout_tests/models/test_failures.py (270952 => 270953)


--- trunk/Tools/Scripts/webkitpy/layout_tests/models/test_failures.py	2020-12-17 23:14:47 UTC (rev 270952)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/models/test_failures.py	2020-12-17 23:17:38 UTC (rev 270953)
@@ -71,7 +71,7 @@
           FailureMissingImage in failure_types or
           FailureMissingImageHash in failure_types or
           FailureMissingAudio in failure_types or
-          FailureNotTested in failure_types):
+          FailureNoOutput in failure_types):
         return test_expectations.MISSING
     else:
         is_text_failure = FailureTextMismatch in failure_types
@@ -190,9 +190,9 @@
         return "-expected.txt was missing"
 
 
-class FailureNotTested(FailureText):
+class FailureNoOutput(FailureText):
     def message(self):
-        return 'test was not run'
+        return 'no output from test'
 
 
 class FailureTextMismatch(FailureText):
@@ -296,7 +296,7 @@
 
 # Convenient collection of all failure classes for anything that might
 # need to enumerate over them all.
-ALL_FAILURE_CLASSES = (FailureTimeout, FailureCrash, FailureMissingResult, FailureNotTested,
+ALL_FAILURE_CLASSES = (FailureTimeout, FailureCrash, FailureMissingResult, FailureNoOutput,
                        FailureTextMismatch, FailureMissingImageHash,
                        FailureMissingImage, FailureImageHashMismatch,
                        FailureImageHashIncorrect, FailureReftestMismatch,

Modified: trunk/Tools/Scripts/webkitpy/layout_tests/models/test_failures_unittest.py (270952 => 270953)


--- trunk/Tools/Scripts/webkitpy/layout_tests/models/test_failures_unittest.py	2020-12-17 23:14:47 UTC (rev 270952)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/models/test_failures_unittest.py	2020-12-17 23:17:38 UTC (rev 270953)
@@ -64,7 +64,7 @@
             FailureTimeout,
             FailureCrash,
             FailureMissingResult,
-            FailureNotTested,
+            FailureNoOutput,
             FailureTextMismatch,
             FailureMissingImageHash,
             FailureMissingImage,
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to