Title: [270980] trunk/Source/WebKit
Revision
270980
Author
[email protected]
Date
2020-12-18 11:16:16 -0800 (Fri, 18 Dec 2020)

Log Message

REGRESSION (r270938): ASSERTION FAILED: !m_renderThread in WebKit::RemoteAudioDestinationProxy::startRenderingThread
https://bugs.webkit.org/show_bug.cgi?id=220017
<rdar://problem/72470176>

Reviewed by Darin Adler.

In case of a GPU process crash, we call stopRenderingThread() and then connectToGPUProcess() which
calls startRenderingThread(). We were hitting an assertion in startRenderingThread() making sure
that m_renderThread is null because stopRenderingThread() was failing to set it to null after
stopping the thread.

No new tests, covered by existing failing API test.

* WebProcess/GPU/media/RemoteAudioDestinationProxy.cpp:
(WebKit::RemoteAudioDestinationProxy::stopRenderingThread):

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (270979 => 270980)


--- trunk/Source/WebKit/ChangeLog	2020-12-18 19:11:20 UTC (rev 270979)
+++ trunk/Source/WebKit/ChangeLog	2020-12-18 19:16:16 UTC (rev 270980)
@@ -1,3 +1,21 @@
+2020-12-18  Chris Dumez  <[email protected]>
+
+        REGRESSION (r270938): ASSERTION FAILED: !m_renderThread in WebKit::RemoteAudioDestinationProxy::startRenderingThread
+        https://bugs.webkit.org/show_bug.cgi?id=220017
+        <rdar://problem/72470176>
+
+        Reviewed by Darin Adler.
+
+        In case of a GPU process crash, we call stopRenderingThread() and then connectToGPUProcess() which
+        calls startRenderingThread(). We were hitting an assertion in startRenderingThread() making sure
+        that m_renderThread is null because stopRenderingThread() was failing to set it to null after
+        stopping the thread.
+
+        No new tests, covered by existing failing API test.
+
+        * WebProcess/GPU/media/RemoteAudioDestinationProxy.cpp:
+        (WebKit::RemoteAudioDestinationProxy::stopRenderingThread):
+
 2020-12-18  Megan Gardner  <[email protected]>
 
         Gate all of the code associated with app highlights

Modified: trunk/Source/WebKit/WebProcess/GPU/media/RemoteAudioDestinationProxy.cpp (270979 => 270980)


--- trunk/Source/WebKit/WebProcess/GPU/media/RemoteAudioDestinationProxy.cpp	2020-12-18 19:11:20 UTC (rev 270979)
+++ trunk/Source/WebKit/WebProcess/GPU/media/RemoteAudioDestinationProxy.cpp	2020-12-18 19:16:16 UTC (rev 270980)
@@ -101,6 +101,7 @@
     if (m_renderSemaphore)
         m_renderSemaphore->signal();
     m_renderThread->waitForCompletion();
+    m_renderThread = nullptr;
 #endif
 }
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to