Title: [270988] trunk/Source/_javascript_Core
- Revision
- 270988
- Author
- [email protected]
- Date
- 2020-12-18 13:42:13 -0800 (Fri, 18 Dec 2020)
Log Message
Fix MacroAssemblerARM64E::validateUntaggedPtr() to account for TBI.
https://bugs.webkit.org/show_bug.cgi?id=220021
<rdar://problem/72474809>
Reviewed by Saam Barati.
* assembler/AbstractMacroAssembler.h:
* assembler/DisallowMacroScratchRegisterUsage.h:
- templatized the DisallowMacroScratchRegisterUsage class so that we can #include
it in MacroAssembler implementations.
* assembler/MacroAssemblerARM64E.h:
(JSC::MacroAssemblerARM64E::validateUntaggedPtr):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (270987 => 270988)
--- trunk/Source/_javascript_Core/ChangeLog 2020-12-18 21:10:53 UTC (rev 270987)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-12-18 21:42:13 UTC (rev 270988)
@@ -1,3 +1,18 @@
+2020-12-18 Mark Lam <[email protected]>
+
+ Fix MacroAssemblerARM64E::validateUntaggedPtr() to account for TBI.
+ https://bugs.webkit.org/show_bug.cgi?id=220021
+ <rdar://problem/72474809>
+
+ Reviewed by Saam Barati.
+
+ * assembler/AbstractMacroAssembler.h:
+ * assembler/DisallowMacroScratchRegisterUsage.h:
+ - templatized the DisallowMacroScratchRegisterUsage class so that we can #include
+ it in MacroAssembler implementations.
+ * assembler/MacroAssemblerARM64E.h:
+ (JSC::MacroAssemblerARM64E::validateUntaggedPtr):
+
2020-12-17 Mark Lam <[email protected]>
Add tagging to JIT probe's return address.
Modified: trunk/Source/_javascript_Core/assembler/AbstractMacroAssembler.h (270987 => 270988)
--- trunk/Source/_javascript_Core/assembler/AbstractMacroAssembler.h 2020-12-18 21:10:53 UTC (rev 270987)
+++ trunk/Source/_javascript_Core/assembler/AbstractMacroAssembler.h 2020-12-18 21:42:13 UTC (rev 270988)
@@ -46,9 +46,11 @@
#if ENABLE(ASSEMBLER)
class AllowMacroScratchRegisterUsage;
-class DisallowMacroScratchRegisterUsage;
class LinkBuffer;
class Watchpoint;
+
+template<typename T> class DisallowMacroScratchRegisterUsage;
+
namespace DFG {
struct OSRExit;
}
@@ -1107,7 +1109,7 @@
friend class AllowMacroScratchRegisterUsage;
friend class AllowMacroScratchRegisterUsageIf;
- friend class DisallowMacroScratchRegisterUsage;
+ template<typename T> friend class DisallowMacroScratchRegisterUsage;
unsigned m_tempRegistersValidBits;
bool m_allowScratchRegister { true };
Modified: trunk/Source/_javascript_Core/assembler/DisallowMacroScratchRegisterUsage.h (270987 => 270988)
--- trunk/Source/_javascript_Core/assembler/DisallowMacroScratchRegisterUsage.h 2020-12-18 21:10:53 UTC (rev 270987)
+++ trunk/Source/_javascript_Core/assembler/DisallowMacroScratchRegisterUsage.h 2020-12-18 21:42:13 UTC (rev 270988)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2015 Apple Inc. All rights reserved.
+ * Copyright (C) 2015-2020 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -27,10 +27,9 @@
#if ENABLE(ASSEMBLER)
-#include "MacroAssembler.h"
-
namespace JSC {
+template<typename MacroAssembler>
class DisallowMacroScratchRegisterUsage {
public:
DisallowMacroScratchRegisterUsage(MacroAssembler& masm)
Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerARM64E.h (270987 => 270988)
--- trunk/Source/_javascript_Core/assembler/MacroAssemblerARM64E.h 2020-12-18 21:10:53 UTC (rev 270987)
+++ trunk/Source/_javascript_Core/assembler/MacroAssemblerARM64E.h 2020-12-18 21:42:13 UTC (rev 270988)
@@ -27,6 +27,8 @@
#if ENABLE(ASSEMBLER) && CPU(ARM64E)
+#include "DisallowMacroScratchRegisterUsage.h"
+
// We need to include this before MacroAssemblerARM64.h because MacroAssemblerARM64
// will be defined in terms of ARM64EAssembler for ARM64E.
#include "ARM64EAssembler.h"
@@ -83,7 +85,12 @@
{
if (scratch == InvalidGPR)
scratch = getCachedDataTempRegisterIDAndInvalidate();
- load8(Address(target), scratch);
+
+ DisallowMacroScratchRegisterUsage disallowScope(*this);
+ rshift64(target, TrustedImm32(8), scratch);
+ and64(TrustedImm64(0xff000000000000), scratch, scratch);
+ or64(target, scratch, scratch);
+ load8(Address(scratch), scratch);
}
ALWAYS_INLINE void untagPtr(RegisterID tag, RegisterID target)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes