Title: [270991] trunk/Source/_javascript_Core
Revision
270991
Author
[email protected]
Date
2020-12-18 15:14:55 -0800 (Fri, 18 Dec 2020)

Log Message

CachedRefPtr should adoptRef before calling ref to appease RefCounted's debug assertions
https://bugs.webkit.org/show_bug.cgi?id=219953
<rdar://problem/72391255>

Reviewed by Tadeu Zagallo.

* runtime/CachedTypes.cpp:
(JSC::CachedRefPtr::decode const):

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (270990 => 270991)


--- trunk/Source/_javascript_Core/ChangeLog	2020-12-18 22:27:31 UTC (rev 270990)
+++ trunk/Source/_javascript_Core/ChangeLog	2020-12-18 23:14:55 UTC (rev 270991)
@@ -1,3 +1,14 @@
+2020-12-18  Saam Barati  <[email protected]>
+
+        CachedRefPtr should adoptRef before calling ref to appease RefCounted's debug assertions
+        https://bugs.webkit.org/show_bug.cgi?id=219953
+        <rdar://problem/72391255>
+
+        Reviewed by Tadeu Zagallo.
+
+        * runtime/CachedTypes.cpp:
+        (JSC::CachedRefPtr::decode const):
+
 2020-12-18  Mark Lam  <[email protected]>
 
         Fix MacroAssemblerARM64E::validateUntaggedPtr() to account for TBI.

Modified: trunk/Source/_javascript_Core/runtime/CachedTypes.cpp (270990 => 270991)


--- trunk/Source/_javascript_Core/runtime/CachedTypes.cpp	2020-12-18 22:27:31 UTC (rev 270990)
+++ trunk/Source/_javascript_Core/runtime/CachedTypes.cpp	2020-12-18 23:14:55 UTC (rev 270991)
@@ -557,8 +557,9 @@
                 WTF::DefaultRefDerefTraits<Source>::derefIfNotNull(decodedPtr);
             });
         }
-        WTF::DefaultRefDerefTraits<Source>::refIfNotNull(decodedPtr);
-        return adoptRef(decodedPtr);
+        auto result = adoptRef<Source, PtrTraits>(decodedPtr);
+        result->ref();
+        return result;
     }
 
     void decode(Decoder& decoder, RefPtr<Source, PtrTraits>& src) const
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to