Title: [270995] trunk/Source/WebCore
- Revision
- 270995
- Author
- [email protected]
- Date
- 2020-12-18 16:11:41 -0800 (Fri, 18 Dec 2020)
Log Message
Login flows on sites with ITP quirks no longer work with ITP disabled
https://bugs.webkit.org/show_bug.cgi?id=220019
<rdar://problem/72472858>
Reviewed by Darin Adler.
We should add a check for ITP enabled before attempting to apply quirks,
otherwise the quirks will commandeer the login process, fail (because
no ITP), and thus result in an inability to login when ITP is disabled.
No new tests, this will fix login flows on sites with ITP quirks when
ITP is turned off. I confirmed these cases manually.
* page/Quirks.cpp:
(WebCore::Quirks::triggerOptionalStorageAccessQuirk const):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (270994 => 270995)
--- trunk/Source/WebCore/ChangeLog 2020-12-19 00:10:59 UTC (rev 270994)
+++ trunk/Source/WebCore/ChangeLog 2020-12-19 00:11:41 UTC (rev 270995)
@@ -1,3 +1,21 @@
+2020-12-18 Kate Cheney <[email protected]>
+
+ Login flows on sites with ITP quirks no longer work with ITP disabled
+ https://bugs.webkit.org/show_bug.cgi?id=220019
+ <rdar://problem/72472858>
+
+ Reviewed by Darin Adler.
+
+ We should add a check for ITP enabled before attempting to apply quirks,
+ otherwise the quirks will commandeer the login process, fail (because
+ no ITP), and thus result in an inability to login when ITP is disabled.
+
+ No new tests, this will fix login flows on sites with ITP quirks when
+ ITP is turned off. I confirmed these cases manually.
+
+ * page/Quirks.cpp:
+ (WebCore::Quirks::triggerOptionalStorageAccessQuirk const):
+
2020-12-18 Zalan Bujtas <[email protected]>
Line snapping fails when the content is taller than the page.
Modified: trunk/Source/WebCore/page/Quirks.cpp (270994 => 270995)
--- trunk/Source/WebCore/page/Quirks.cpp 2020-12-19 00:10:59 UTC (rev 270994)
+++ trunk/Source/WebCore/page/Quirks.cpp 2020-12-19 00:11:41 UTC (rev 270995)
@@ -29,6 +29,7 @@
#include "Attr.h"
#include "DOMTokenList.h"
#include "DOMWindow.h"
+#include "DeprecatedGlobalSettings.h"
#include "Document.h"
#include "DocumentLoader.h"
#include "DocumentStorageAccess.h"
@@ -1006,6 +1007,9 @@
Quirks::StorageAccessResult Quirks::triggerOptionalStorageAccessQuirk(Element& element, const PlatformMouseEvent& platformEvent, const AtomString& eventType, int detail, Element* relatedTarget) const
{
+ if (!DeprecatedGlobalSettings::resourceLoadStatisticsEnabled())
+ return Quirks::StorageAccessResult::ShouldNotCancelEvent;
+
#if ENABLE(RESOURCE_LOAD_STATISTICS)
if (!needsQuirks())
return Quirks::StorageAccessResult::ShouldNotCancelEvent;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes