Title: [271015] trunk
Revision
271015
Author
[email protected]
Date
2020-12-20 12:09:12 -0800 (Sun, 20 Dec 2020)

Log Message

[WinCairo][WebGL] webgl/1.0.3/conformance/misc/uninitialized-test.html is failing only for Debug builds
https://bugs.webkit.org/show_bug.cgi?id=220000

Reviewed by Kenneth Russell.

Source/WebCore:

Some WebGL tests were failing only in debug builds. Those test
cases expect black transparent for uninitialized buffers. ANGLE
enables debug layers as default only for debug builds. And it
fills uninitialized buffers with kDebugColorInitClearValue instead
of black transparent.

Create a PlatformDisplay with explicitly disabling debug layers by
using EGL_PLATFORM_ANGLE_DEBUG_LAYERS_ENABLED_ANGLE.

* PlatformWinCairo.cmake:
* platform/graphics/win/PlatformDisplayWin.cpp: Added.
(WebCore::PlatformDisplayWin::initializeEGLDisplay):
* platform/graphics/win/PlatformDisplayWin.h:

LayoutTests:

* platform/wincairo/TestExpectations:

Modified Paths

Added Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (271014 => 271015)


--- trunk/LayoutTests/ChangeLog	2020-12-20 18:56:15 UTC (rev 271014)
+++ trunk/LayoutTests/ChangeLog	2020-12-20 20:09:12 UTC (rev 271015)
@@ -1,3 +1,12 @@
+2020-12-20  Fujii Hironori  <[email protected]>
+
+        [WinCairo][WebGL] webgl/1.0.3/conformance/misc/uninitialized-test.html is failing only for Debug builds
+        https://bugs.webkit.org/show_bug.cgi?id=220000
+
+        Reviewed by Kenneth Russell.
+
+        * platform/wincairo/TestExpectations:
+
 2020-12-19  Zalan Bujtas  <[email protected]>
 
         width: max-content with box-sizing: border-box should leave space for padding (Twitter date hover overflow)

Modified: trunk/LayoutTests/platform/wincairo/TestExpectations (271014 => 271015)


--- trunk/LayoutTests/platform/wincairo/TestExpectations	2020-12-20 18:56:15 UTC (rev 271014)
+++ trunk/LayoutTests/platform/wincairo/TestExpectations	2020-12-20 20:09:12 UTC (rev 271015)
@@ -2137,20 +2137,16 @@
 webgl/1.0.3/conformance/extensions/oes-texture-half-float-with-video.html [ Skip ] # Timeout
 webgl/1.0.3/conformance/glsl/bugs/array-of-struct-with-int-first-position.html [ Skip ] # This test makes DumpRenderTree process unable to exit
 webgl/1.0.3/conformance/glsl/bugs/long-expressions-should-not-crash.html [ Skip ] # Timeout
-webgl/1.0.3/conformance/misc/uninitialized-test.html [ Failure ]
 webgl/1.0.3/conformance/more/functions/readPixelsBadArgs.html [ Failure ]
 webgl/1.0.3/conformance/more/functions/texImage2DHTML.html [ Failure ]
 webgl/1.0.3/conformance/more/functions/texSubImage2DHTML.html [ Failure ]
 webgl/1.0.3/conformance/programs/program-test.html [ Failure ]
 webgl/1.0.3/conformance/renderbuffers/framebuffer-object-attachment.html [ Failure ]
-webgl/1.0.3/conformance/renderbuffers/framebuffer-state-restoration.html [ Failure ]
-webgl/1.0.3/conformance/renderbuffers/renderbuffer-initialization.html [ Failure ]
 webgl/1.0.3/conformance/textures/default-texture.html [ Failure ]
 webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-video-rgb565.html [ Skip ] # Timeout
 webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-video-rgba4444.html [ Skip ] # Timeout
 webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-video-rgba5551.html [ Skip ] # Timeout
 webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-video.html [ Skip ] # Timeout
-webgl/1.0.3/conformance/textures/texture-attachment-formats.html [ Failure ]
-webgl/1.0.3/conformance/textures/texture-mips.html [ Failure ]
+webgl/1.0.3/conformance/textures/texture-mips.html [ Pass Failure ]
 webgl/1.0.3/conformance/textures/texture-upload-size.html [ Skip ] # Timeout
 webgl/webgl-vertex-array-object-defined.html [ Failure ]

Modified: trunk/Source/WebCore/ChangeLog (271014 => 271015)


--- trunk/Source/WebCore/ChangeLog	2020-12-20 18:56:15 UTC (rev 271014)
+++ trunk/Source/WebCore/ChangeLog	2020-12-20 20:09:12 UTC (rev 271015)
@@ -1,3 +1,24 @@
+2020-12-20  Fujii Hironori  <[email protected]>
+
+        [WinCairo][WebGL] webgl/1.0.3/conformance/misc/uninitialized-test.html is failing only for Debug builds
+        https://bugs.webkit.org/show_bug.cgi?id=220000
+
+        Reviewed by Kenneth Russell.
+
+        Some WebGL tests were failing only in debug builds. Those test
+        cases expect black transparent for uninitialized buffers. ANGLE
+        enables debug layers as default only for debug builds. And it
+        fills uninitialized buffers with kDebugColorInitClearValue instead
+        of black transparent.
+
+        Create a PlatformDisplay with explicitly disabling debug layers by
+        using EGL_PLATFORM_ANGLE_DEBUG_LAYERS_ENABLED_ANGLE.
+
+        * PlatformWinCairo.cmake:
+        * platform/graphics/win/PlatformDisplayWin.cpp: Added.
+        (WebCore::PlatformDisplayWin::initializeEGLDisplay):
+        * platform/graphics/win/PlatformDisplayWin.h:
+
 2020-12-20  Zalan Bujtas  <[email protected]>
 
         [LFC][IFC] Let's create the run and update the box geometry in one go for atomic inline level boxes

Modified: trunk/Source/WebCore/PlatformWinCairo.cmake (271014 => 271015)


--- trunk/Source/WebCore/PlatformWinCairo.cmake	2020-12-20 18:56:15 UTC (rev 271014)
+++ trunk/Source/WebCore/PlatformWinCairo.cmake	2020-12-20 20:09:12 UTC (rev 271015)
@@ -30,6 +30,7 @@
     platform/graphics/win/GraphicsContextCairoWin.cpp
     platform/graphics/win/ImageCairoWin.cpp
     platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp
+    platform/graphics/win/PlatformDisplayWin.cpp
     platform/graphics/win/SimpleFontDataCairoWin.cpp
 
     platform/network/win/CurlSSLHandleWin.cpp

Added: trunk/Source/WebCore/platform/graphics/win/PlatformDisplayWin.cpp (0 => 271015)


--- trunk/Source/WebCore/platform/graphics/win/PlatformDisplayWin.cpp	                        (rev 0)
+++ trunk/Source/WebCore/platform/graphics/win/PlatformDisplayWin.cpp	2020-12-20 20:09:12 UTC (rev 271015)
@@ -0,0 +1,49 @@
+/*
+ * Copyright (C) 2020 Sony Interactive Entertainment Inc.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *    notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *    notice, this list of conditions and the following disclaimer in the
+ *    documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL APPLE INC. OR
+ * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
+ * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
+ * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
+ * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
+ * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
+ */
+
+#include "config.h"
+#include "PlatformDisplayWin.h"
+
+#include <EGL/egl.h>
+#include <EGL/eglext.h>
+
+namespace WebCore {
+
+void PlatformDisplayWin::initializeEGLDisplay()
+{
+    EGLint attributs[] = {
+        // Disable debug layers that makes some tests fail because
+        // ANGLE fills uninitialized buffers with
+        // kDebugColorInitClearValue in debug builds.
+        EGL_PLATFORM_ANGLE_DEBUG_LAYERS_ENABLED_ANGLE,
+        EGL_FALSE,
+        EGL_NONE,
+    };
+    m_eglDisplay = eglGetPlatformDisplayEXT(EGL_PLATFORM_ANGLE_ANGLE, EGL_DEFAULT_DISPLAY, attributs);
+
+    PlatformDisplay::initializeEGLDisplay();
+}
+
+} // namespace WebCore

Modified: trunk/Source/WebCore/platform/graphics/win/PlatformDisplayWin.h (271014 => 271015)


--- trunk/Source/WebCore/platform/graphics/win/PlatformDisplayWin.h	2020-12-20 18:56:15 UTC (rev 271014)
+++ trunk/Source/WebCore/platform/graphics/win/PlatformDisplayWin.h	2020-12-20 20:09:12 UTC (rev 271015)
@@ -48,6 +48,8 @@
     }
 
     Type type() const override { return PlatformDisplay::Type::Windows; }
+
+    void initializeEGLDisplay() final;
 };
 
 } // namespace WebCore
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to