Title: [271017] trunk/Source

Diff

Modified: trunk/Source/WTF/ChangeLog (271016 => 271017)


--- trunk/Source/WTF/ChangeLog	2020-12-20 20:16:07 UTC (rev 271016)
+++ trunk/Source/WTF/ChangeLog	2020-12-20 23:15:50 UTC (rev 271017)
@@ -1,3 +1,15 @@
+2020-12-20  Chris Dumez  <[email protected]>
+
+        Unreviewed, reverting r270969.
+
+        Regressed MotionMark with GPUProcess enabled
+
+        Reverted changeset:
+
+        "[iOS] Stop leaking an XPC boost message to XPC services"
+        https://bugs.webkit.org/show_bug.cgi?id=219453
+        https://trac.webkit.org/changeset/270969
+
 2020-12-18  Megan Gardner  <[email protected]>
 
         Gate all of the code associated with app highlights

Modified: trunk/Source/WTF/wtf/PlatformHave.h (271016 => 271017)


--- trunk/Source/WTF/wtf/PlatformHave.h	2020-12-20 20:16:07 UTC (rev 271016)
+++ trunk/Source/WTF/wtf/PlatformHave.h	2020-12-20 23:15:50 UTC (rev 271017)
@@ -725,12 +725,6 @@
 #define HAVE_CTFONTDESCRIPTOR_CREATE_WITH_TEXT_STYLE_AND_ATTRIBUTES 1
 #endif
 
-#if ((PLATFORM(IOS) || PLATFORM(MACCATALYST)) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 150000) \
-    || (PLATFORM(WATCHOS) && __WATCH_OS_VERSION_MIN_REQUIRED >= 80000) \
-    || (PLATFORM(APPLETV) && __TV_OS_VERSION_MIN_REQUIRED >= 150000)
-#define HAVE_RUNNINGBOARD_WEBKIT_PRIORITY_SUPPORT 1
-#endif
-
 #if PLATFORM(MACCATALYST) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 140000
 #define HAVE_CATALYST_USER_INTERFACE_IDIOM_AND_SCALE_FACTOR 1
 #endif

Modified: trunk/Source/WebKit/ChangeLog (271016 => 271017)


--- trunk/Source/WebKit/ChangeLog	2020-12-20 20:16:07 UTC (rev 271016)
+++ trunk/Source/WebKit/ChangeLog	2020-12-20 23:15:50 UTC (rev 271017)
@@ -1,3 +1,15 @@
+2020-12-20  Chris Dumez  <[email protected]>
+
+        Unreviewed, reverting r270969.
+
+        Regressed MotionMark with GPUProcess enabled
+
+        Reverted changeset:
+
+        "[iOS] Stop leaking an XPC boost message to XPC services"
+        https://bugs.webkit.org/show_bug.cgi?id=219453
+        https://trac.webkit.org/changeset/270969
+
 2020-12-20  Rob Buis  <[email protected]>
 
         Convert remaining FrameLoaderType enums to enum classes

Modified: trunk/Source/WebKit/FeatureFlags/WebKit.plist (271016 => 271017)


--- trunk/Source/WebKit/FeatureFlags/WebKit.plist	2020-12-20 20:16:07 UTC (rev 271016)
+++ trunk/Source/WebKit/FeatureFlags/WebKit.plist	2020-12-20 23:15:50 UTC (rev 271017)
@@ -87,10 +87,5 @@
         <key>Enabled</key>
         <true/>
     </dict>
-    <key>RB_full_manage_WK_jetsam</key>
-    <dict>
-        <key>Enabled</key>
-        <true/>
-    </dict>
 </dict>
 </plist>

Modified: trunk/Source/WebKit/GPUProcess/EntryPoint/Cocoa/XPCService/GPUService/Info-iOS.plist (271016 => 271017)


--- trunk/Source/WebKit/GPUProcess/EntryPoint/Cocoa/XPCService/GPUService/Info-iOS.plist	2020-12-20 20:16:07 UTC (rev 271016)
+++ trunk/Source/WebKit/GPUProcess/EntryPoint/Cocoa/XPCService/GPUService/Info-iOS.plist	2020-12-20 23:15:50 UTC (rev 271017)
@@ -34,8 +34,6 @@
 		<string>Application</string>
 		<key>RunLoopType</key>
 		<string>NSRunLoop</string>
-                <key>_ProcessType</key>
-                <string>App</string>
 		<key>_MultipleInstances</key>
 		<true/>
 	</dict>

Modified: trunk/Source/WebKit/NetworkProcess/EntryPoint/Cocoa/XPCService/NetworkService/Info-iOS.plist (271016 => 271017)


--- trunk/Source/WebKit/NetworkProcess/EntryPoint/Cocoa/XPCService/NetworkService/Info-iOS.plist	2020-12-20 20:16:07 UTC (rev 271016)
+++ trunk/Source/WebKit/NetworkProcess/EntryPoint/Cocoa/XPCService/NetworkService/Info-iOS.plist	2020-12-20 23:15:50 UTC (rev 271017)
@@ -34,8 +34,6 @@
 		<string>Application</string>
 		<key>RunLoopType</key>
 		<string>NSRunLoop</string>
-                <key>_ProcessType</key>
-                <string>App</string>
 		<key>_MultipleInstances</key>
 		<true/>
 	</dict>

Modified: trunk/Source/WebKit/UIProcess/Launcher/mac/ProcessLauncherMac.mm (271016 => 271017)


--- trunk/Source/WebKit/UIProcess/Launcher/mac/ProcessLauncherMac.mm	2020-12-20 20:16:07 UTC (rev 271016)
+++ trunk/Source/WebKit/UIProcess/Launcher/mac/ProcessLauncherMac.mm	2020-12-20 23:15:50 UTC (rev 271017)
@@ -26,7 +26,6 @@
 #import "config.h"
 #import "ProcessLauncher.h"
 
-#import "WebPreferencesDefaultValues.h"
 #import <crt_externs.h>
 #import <mach-o/dyld.h>
 #import <mach/mach_error.h>
@@ -75,15 +74,9 @@
 static bool shouldLeakBoost(const ProcessLauncher::LaunchOptions& launchOptions)
 {
 #if PLATFORM(IOS_FAMILY)
+    // On iOS, leak a boost onto all child processes
     UNUSED_PARAM(launchOptions);
-#if HAVE(RUNNINGBOARD_WEBKIT_PRIORITY_SUPPORT)
-    // On iOS, we don't need to leak a boost message when RunningBoard process assertions give us the
-    // right priorities.
-    static const bool runningBoardHandlesPriorities = isFeatureFlagEnabled("RB_full_manage_WK_jetsam"_s);
-    return !runningBoardHandlesPriorities;
-#else
     return true;
-#endif // HAVE(RUNNINGBOARD_WEBKIT_PRIORITY_SUPPORT)
 #else
     // On Mac, leak a boost onto the NetworkProcess, GPUProcess, and WebAuthnProcess.
 #if ENABLE(GPU_PROCESS)

Modified: trunk/Source/WebKit/WebAuthnProcess/EntryPoint/Cocoa/XPCService/WebAuthnService/Info-iOS.plist (271016 => 271017)


--- trunk/Source/WebKit/WebAuthnProcess/EntryPoint/Cocoa/XPCService/WebAuthnService/Info-iOS.plist	2020-12-20 20:16:07 UTC (rev 271016)
+++ trunk/Source/WebKit/WebAuthnProcess/EntryPoint/Cocoa/XPCService/WebAuthnService/Info-iOS.plist	2020-12-20 23:15:50 UTC (rev 271017)
@@ -34,8 +34,6 @@
 		<string>Application</string>
 		<key>RunLoopType</key>
 		<string>NSRunLoop</string>
-                <key>_ProcessType</key>
-                <string>App</string>
 		<key>_MultipleInstances</key>
 		<true/>
 	</dict>

Modified: trunk/Source/WebKit/WebProcess/EntryPoint/Cocoa/XPCService/WebContentService/Info-iOS.plist (271016 => 271017)


--- trunk/Source/WebKit/WebProcess/EntryPoint/Cocoa/XPCService/WebContentService/Info-iOS.plist	2020-12-20 20:16:07 UTC (rev 271016)
+++ trunk/Source/WebKit/WebProcess/EntryPoint/Cocoa/XPCService/WebContentService/Info-iOS.plist	2020-12-20 23:15:50 UTC (rev 271017)
@@ -34,8 +34,6 @@
 		<string>Application</string>
 		<key>RunLoopType</key>
 		<string>NSRunLoop</string>
-                <key>_ProcessType</key>
-                <string>App</string>
 		<key>_MultipleInstances</key>
 		<true/>
 		<key>_HighBitsASLR</key>
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to