Title: [271020] trunk/LayoutTests
Revision
271020
Author
[email protected]
Date
2020-12-21 04:15:20 -0800 (Mon, 21 Dec 2020)

Log Message

media-source-webm.html: Handle frame size in HAVE_METADATA
https://bugs.webkit.org/show_bug.cgi?id=220046

Reviewed by Eric Carlson.

The current version of media-source-webm.html assumes that a `resize`
event happens after the first media segment is appended.

This is not necessarily true. In fact, an initialization segment
should cause a transition to HAVE_METADATA, and that per spec implies
the size of the video is known.

In practice, some implementations don't report this until a media
segment has arrived.

Because of the way the current code is written, an implementation
emitting `resize` on HAVE_METADATA would timeout the test. This patch
fixes that, accomodating both cases.

* media/media-source/media-source-webm.html:
* media/media-source/media-source-webm-expected.txt:
* platform/glib/TestExpectations:
* platform/wpe/TestExpectations:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (271019 => 271020)


--- trunk/LayoutTests/ChangeLog	2020-12-21 04:07:31 UTC (rev 271019)
+++ trunk/LayoutTests/ChangeLog	2020-12-21 12:15:20 UTC (rev 271020)
@@ -1,3 +1,29 @@
+2020-12-21  Alicia Boya GarcĂ­a  <[email protected]>
+
+        media-source-webm.html: Handle frame size in HAVE_METADATA
+        https://bugs.webkit.org/show_bug.cgi?id=220046
+
+        Reviewed by Eric Carlson.
+
+        The current version of media-source-webm.html assumes that a `resize`
+        event happens after the first media segment is appended.
+
+        This is not necessarily true. In fact, an initialization segment
+        should cause a transition to HAVE_METADATA, and that per spec implies
+        the size of the video is known.
+
+        In practice, some implementations don't report this until a media
+        segment has arrived.
+
+        Because of the way the current code is written, an implementation
+        emitting `resize` on HAVE_METADATA would timeout the test. This patch
+        fixes that, accomodating both cases.
+
+        * media/media-source/media-source-webm.html:
+        * media/media-source/media-source-webm-expected.txt:
+        * platform/glib/TestExpectations:
+        * platform/wpe/TestExpectations:
+
 2020-12-20  Fujii Hironori  <[email protected]>
 
         [WinCairo][WebGL] webgl/1.0.3/conformance/misc/uninitialized-test.html is failing only for Debug builds

Modified: trunk/LayoutTests/media/media-source/media-source-webm-expected.txt (271019 => 271020)


--- trunk/LayoutTests/media/media-source/media-source-webm-expected.txt	2020-12-21 04:07:31 UTC (rev 271019)
+++ trunk/LayoutTests/media/media-source/media-source-webm-expected.txt	2020-12-21 12:15:20 UTC (rev 271020)
@@ -5,11 +5,11 @@
 RUN(source.duration = loader.duration())
 RUN(sourceBuffer = source.addSourceBuffer(loader.type()))
 RUN(sourceBuffer.appendBuffer(loader.initSegment()))
+EVENT(resize)
+EXPECTED (video.videoWidth == '320') OK
+EXPECTED (video.videoHeight == '240') OK
 EVENT(update)
 Append a media segment.
 RUN(sourceBuffer.appendBuffer(loader.mediaSegment(0)))
-EVENT(resize)
-EXPECTED (video.videoWidth == '320') OK
-EXPECTED (video.videoHeight == '240') OK
 END OF TEST
 

Modified: trunk/LayoutTests/media/media-source/media-source-webm.html (271019 => 271020)


--- trunk/LayoutTests/media/media-source/media-source-webm.html	2020-12-21 04:07:31 UTC (rev 271019)
+++ trunk/LayoutTests/media/media-source/media-source-webm.html	2020-12-21 12:15:20 UTC (rev 271020)
@@ -43,6 +43,7 @@
 
             run('source.duration = loader.duration()');
             run('sourceBuffer = source.addSourceBuffer(loader.type())');
+            const resized = resizePromise(video, 320, 240);
             run('sourceBuffer.appendBuffer(loader.initSegment())');
 
             await waitFor(sourceBuffer, 'update');
@@ -50,7 +51,7 @@
             consoleWrite('Append a media segment.')
             run('sourceBuffer.appendBuffer(loader.mediaSegment(0))');
 
-            await resizePromise(video, 320, 240);
+            await resized;
             endTest();
         } catch (e) {
             failTest(`Caught exception: "${e}"`);

Modified: trunk/LayoutTests/platform/glib/TestExpectations (271019 => 271020)


--- trunk/LayoutTests/platform/glib/TestExpectations	2020-12-21 04:07:31 UTC (rev 271019)
+++ trunk/LayoutTests/platform/glib/TestExpectations	2020-12-21 12:15:20 UTC (rev 271020)
@@ -434,7 +434,6 @@
 
 webkit.org/b/203078 media/media-source/media-source-remove-unload-crash.html [ Crash Timeout Pass ]
 webkit.org/b/210528 media/media-source/media-source-seek-back.html [ Crash Pass ]
-webkit.org/b/214636 media/media-source/media-source-webm.html [ Timeout Crash ]
 webkit.org/b/218317 media/media-source/media-source-trackid-change.html [ Failure ]
 
 webkit.org/b/210528 media/video-src-blob-replay.html [ Crash Pass ]

Modified: trunk/LayoutTests/platform/wpe/TestExpectations (271019 => 271020)


--- trunk/LayoutTests/platform/wpe/TestExpectations	2020-12-21 04:07:31 UTC (rev 271019)
+++ trunk/LayoutTests/platform/wpe/TestExpectations	2020-12-21 12:15:20 UTC (rev 271020)
@@ -1173,7 +1173,6 @@
 transitions/svg-text-shadow-transition.html [ DumpJSConsoleLogInStdErr ]
 
 webkit.org/b/168373 media/media-source/only-bcp47-language-tags-accepted-as-valid.html [ Timeout ]
-webkit.org/b/214636 media/media-source/media-source-webm.html [ Timeout Crash ]
 
 webkit.org/b/177871 http/wpt/resource-timing/rt-shared-resource-in-workers.html [ Failure ]
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to