Title: [271032] trunk/Source/WebKit
- Revision
- 271032
- Author
- [email protected]
- Date
- 2020-12-21 11:38:52 -0800 (Mon, 21 Dec 2020)
Log Message
Missing textInteractionEnabled key in WKPreferences initWithCoder looks like a false value.
https://bugs.webkit.org/show_bug.cgi?id=220061
<rdar://problem/72487342>
Reviewed by Wenson Hsieh.
We should check for the existence of the textInteractionEnabled key
in the NSCoder before updating the default value in WKPreferences,
otherwise a missing key will register as a false value when the default
of textInteractionEnabled should be true.
* UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences initWithCoder:]):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (271031 => 271032)
--- trunk/Source/WebKit/ChangeLog 2020-12-21 19:35:24 UTC (rev 271031)
+++ trunk/Source/WebKit/ChangeLog 2020-12-21 19:38:52 UTC (rev 271032)
@@ -1,3 +1,19 @@
+2020-12-21 Kate Cheney <[email protected]>
+
+ Missing textInteractionEnabled key in WKPreferences initWithCoder looks like a false value.
+ https://bugs.webkit.org/show_bug.cgi?id=220061
+ <rdar://problem/72487342>
+
+ Reviewed by Wenson Hsieh.
+
+ We should check for the existence of the textInteractionEnabled key
+ in the NSCoder before updating the default value in WKPreferences,
+ otherwise a missing key will register as a false value when the default
+ of textInteractionEnabled should be true.
+
+ * UIProcess/API/Cocoa/WKPreferences.mm:
+ (-[WKPreferences initWithCoder:]):
+
2020-12-21 Sihui Liu <[email protected]>
Check availability of speech recognition service before requesting permissions
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm (271031 => 271032)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm 2020-12-21 19:35:24 UTC (rev 271031)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm 2020-12-21 19:38:52 UTC (rev 271032)
@@ -100,7 +100,8 @@
ALLOW_DEPRECATED_DECLARATIONS_END
self.tabFocusesLinks = [coder decodeBoolForKey:@"tabFocusesLinks"];
#endif
- self.textInteractionEnabled = [coder decodeBoolForKey:@"textInteractionEnabled"];
+ if ([coder containsValueForKey:@"textInteractionEnabled"])
+ self.textInteractionEnabled = [coder decodeBoolForKey:@"textInteractionEnabled"];
return self;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes