Title: [271047] trunk/Tools
- Revision
- 271047
- Author
- [email protected]
- Date
- 2020-12-21 19:23:54 -0800 (Mon, 21 Dec 2020)
Log Message
[macOS MiniBrowser] Add menu items to reset all experimental and internal debug features to defaults
https://bugs.webkit.org/show_bug.cgi?id=220060
Reviewed by Wenson Hsieh.
Add menu items at the bottom of the "Experimental" and "Internal Debug" feature submenus
to reset all the features to their default values.
* MiniBrowser/mac/SettingsController.m:
(-[SettingsController _populateMenu]):
(-[SettingsController resetAllExperimentalFeatures:]):
(-[SettingsController resetAllInternalDebugFeatures:]):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (271046 => 271047)
--- trunk/Tools/ChangeLog 2020-12-22 01:04:39 UTC (rev 271046)
+++ trunk/Tools/ChangeLog 2020-12-22 03:23:54 UTC (rev 271047)
@@ -1,3 +1,18 @@
+2020-12-21 Simon Fraser <[email protected]>
+
+ [macOS MiniBrowser] Add menu items to reset all experimental and internal debug features to defaults
+ https://bugs.webkit.org/show_bug.cgi?id=220060
+
+ Reviewed by Wenson Hsieh.
+
+ Add menu items at the bottom of the "Experimental" and "Internal Debug" feature submenus
+ to reset all the features to their default values.
+
+ * MiniBrowser/mac/SettingsController.m:
+ (-[SettingsController _populateMenu]):
+ (-[SettingsController resetAllExperimentalFeatures:]):
+ (-[SettingsController resetAllInternalDebugFeatures:]):
+
2020-12-21 Ryan Hostetler <[email protected]>
$(findstring iphone,$(SDKROOT)) fails when SDKROOT is not lowercase
Modified: trunk/Tools/MiniBrowser/mac/SettingsController.m (271046 => 271047)
--- trunk/Tools/MiniBrowser/mac/SettingsController.m 2020-12-22 01:04:39 UTC (rev 271046)
+++ trunk/Tools/MiniBrowser/mac/SettingsController.m 2020-12-22 03:23:54 UTC (rev 271047)
@@ -218,6 +218,12 @@
[experimentalFeaturesMenu addItem:[item autorelease]];
}
+ [experimentalFeaturesMenu addItem:[NSMenuItem separatorItem]];
+ NSMenuItem *resetExperimentalFeaturesToDefaultsItem = [[NSMenuItem alloc] initWithTitle:@"Reset All to Defaults" action:@selector(resetAllExperimentalFeatures:) keyEquivalent:@""];
+ [resetExperimentalFeaturesToDefaultsItem setTarget:self];
+ [experimentalFeaturesMenu addItem:resetExperimentalFeaturesToDefaultsItem];
+ [resetExperimentalFeaturesToDefaultsItem release];
+
[_menu addItem:experimentalFeaturesSubmenuItem];
[experimentalFeaturesSubmenuItem release];
[experimentalFeaturesMenu release];
@@ -238,6 +244,12 @@
[internalDebugFeaturesMenu addItem:[item autorelease]];
}
+ [internalDebugFeaturesMenu addItem:[NSMenuItem separatorItem]];
+ NSMenuItem *resetInternalFeaturesToDefaultsItem = [[NSMenuItem alloc] initWithTitle:@"Reset All to Defaults" action:@selector(resetAllInternalDebugFeatures:) keyEquivalent:@""];
+ [resetInternalFeaturesToDefaultsItem setTarget:self];
+ [internalDebugFeaturesMenu addItem:resetInternalFeaturesToDefaultsItem];
+ [resetInternalFeaturesToDefaultsItem release];
+
[_menu addItem:internalDebugFeaturesSubmenuItem];
[internalDebugFeaturesSubmenuItem release];
[internalDebugFeaturesMenu release];
@@ -754,6 +766,28 @@
[[NSUserDefaults standardUserDefaults] setBool:!currentlyEnabled forKey:feature.key];
}
+- (void)resetAllExperimentalFeatures:(id)sender
+{
+ WKPreferences *preferences = [[NSApplication sharedApplication] browserAppDelegate].defaultPreferences;
+ NSArray<_WKExperimentalFeature *> *experimentalFeatures = [WKPreferences _experimentalFeatures];
+
+ for (_WKExperimentalFeature *feature in experimentalFeatures) {
+ [preferences _setEnabled:feature.defaultValue forExperimentalFeature:feature];
+ [[NSUserDefaults standardUserDefaults] setBool:feature.defaultValue forKey:feature.key];
+ }
+}
+
+- (void)resetAllInternalDebugFeatures:(id)sender
+{
+ WKPreferences *preferences = [[NSApplication sharedApplication] browserAppDelegate].defaultPreferences;
+ NSArray<_WKInternalDebugFeature *> *internalDebugFeatures = [WKPreferences _internalDebugFeatures];
+
+ for (_WKInternalDebugFeature *feature in internalDebugFeatures) {
+ [preferences _setEnabled:feature.defaultValue forInternalDebugFeature:feature];
+ [[NSUserDefaults standardUserDefaults] setBool:feature.defaultValue forKey:feature.key];
+ }
+}
+
- (BOOL)debugOverlayVisible:(NSMenuItem *)menuItem
{
NSString *preferenceKey = [self preferenceKeyForRegionOverlayTag:[menuItem tag]];
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes