Title: [271056] trunk
Revision
271056
Author
[email protected]
Date
2020-12-22 10:28:05 -0800 (Tue, 22 Dec 2020)

Log Message

REGRESSION(r270612) [GStreamer][MSE] Some play/seek related failures
https://bugs.webkit.org/show_bug.cgi?id=219822

Patch by Philippe Normand <[email protected]> on 2020-12-22
Reviewed by Xabier Rodriguez-Calvar.

Source/WebCore:

Call appendComplete which internally synchronizes the TrackBuffer buffered ranges and calls
m_client->sourceBufferPrivateAppendComplete().

* platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp:
(WebCore::SourceBufferPrivateGStreamer::didReceiveAllPendingSamples):
(WebCore::SourceBufferPrivateGStreamer::appendParsingFailed):

LayoutTests:

Unflag tests now-passing and flag tests that were mis-gardened before this regression happened.

* platform/glib/TestExpectations:
* platform/gtk/TestExpectations:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (271055 => 271056)


--- trunk/LayoutTests/ChangeLog	2020-12-22 18:11:42 UTC (rev 271055)
+++ trunk/LayoutTests/ChangeLog	2020-12-22 18:28:05 UTC (rev 271056)
@@ -1,3 +1,15 @@
+2020-12-22  Philippe Normand  <[email protected]>
+
+        REGRESSION(r270612) [GStreamer][MSE] Some play/seek related failures
+        https://bugs.webkit.org/show_bug.cgi?id=219822
+
+        Reviewed by Xabier Rodriguez-Calvar.
+
+        Unflag tests now-passing and flag tests that were mis-gardened before this regression happened.
+        
+        * platform/glib/TestExpectations:
+        * platform/gtk/TestExpectations:
+
 2020-12-22  Simon Fraser  <[email protected]>
 
         Sibling element wheel event regions can be wrong

Modified: trunk/LayoutTests/platform/glib/TestExpectations (271055 => 271056)


--- trunk/LayoutTests/platform/glib/TestExpectations	2020-12-22 18:11:42 UTC (rev 271055)
+++ trunk/LayoutTests/platform/glib/TestExpectations	2020-12-22 18:28:05 UTC (rev 271056)
@@ -459,24 +459,6 @@
 webkit.org/b/219245 webrtc/peer-connection-remote-audio-mute.html [ Crash ]
 webkit.org/b/219245 webrtc/peer-connection-remote-audio-mute2.html [ Crash ]
 
-# Seek failures likely related to r270612
-webkit.org/b/219822 imported/w3c/web-platform-tests/media-source/mediasource-buffered-seek.html [ Failure ]
-webkit.org/b/219822 imported/w3c/web-platform-tests/media-source/mediasource-changetype-play-negative.html [ Failure ]
-webkit.org/b/219822 imported/w3c/web-platform-tests/media-source/mediasource-config-change-webm-av-video-bitrate.html [ Pass Failure ]
-webkit.org/b/219822 imported/w3c/web-platform-tests/media-source/mediasource-liveseekable.html [ Failure ]
-webkit.org/b/219822 imported/w3c/web-platform-tests/media-source/mediasource-play-then-seek-back.html [ Failure ]
-webkit.org/b/219822 imported/w3c/web-platform-tests/media-source/mediasource-redundant-seek.html [ Failure ]
-webkit.org/b/219822 imported/w3c/web-platform-tests/media-source/mediasource-seek-during-pending-seek.html [ Failure ]
-webkit.org/b/219822 imported/w3c/web-platform-tests/media-source/mediasource-seekable.html [ Failure ]
-webkit.org/b/219822 imported/w3c/web-platform-tests/media-source/mediasource-sequencemode-append-buffer.html [ Failure ]
-webkit.org/b/219822 media/media-source/media-source-canplaythrough-event.html [ Failure ]
-webkit.org/b/219822 media/media-source/media-source-stalled-holds-sleep-assertion.html [ Failure ]
-webkit.org/b/219822 media/encrypted-media/clearKey/clearKey-cenc-audio-playback-mse.html [ Timeout ]
-webkit.org/b/219822 media/encrypted-media/clearKey/clearKey-cenc-video-playback-mse.html [ Timeout ]
-webkit.org/b/219822 media/media-source/media-source-paint-to-canvas.html [ Timeout ]
-webkit.org/b/219822 media/media-source/media-source-seek-redundant-append.html [ Timeout ]
-webkit.org/b/219822 media/media-source/media-source-seek-twice.html [ Timeout ]
-
 #////////////////////////////////////////////////////////////////////////////////////////
 # End of GStreamer-related bugs
 #////////////////////////////////////////////////////////////////////////////////////////
@@ -1935,6 +1917,13 @@
 webkit.org/b/211940 fast/text/multiple-codeunit-vertical-upright-2.html [ ImageOnlyFailure ]
 webkit.org/b/211940 fast/text/multiple-codeunit-vertical-upright.html [ ImageOnlyFailure ]
 
+webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-sequencemode-append-buffer.html [ Failure ]
+webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-seekable.html [ Failure ]
+webkit.org/b/197711 imported/w3c/web-platform-tests/media-source/mediasource-correct-frames.html [ Pass Timeout Failure ]
+webkit.org/b/203078 imported/w3c/web-platform-tests/media-source/mediasource-seek-beyond-duration.html [ Crash Failure ]
+webkit.org/b/214349 [ Debug ] imported/w3c/web-platform-tests/media-source/mediasource-changetype-play-negative.html [ Failure Crash ]
+webkit.org/b/220083 [ Debug ] media/media-source/media-source-unnecessary-seek-seeked.html [ Pass Crash ]
+
 # End: Common failures between GTK and WPE.
 
 #////////////////////////////////////////////////////////////////////////////////////////

Modified: trunk/LayoutTests/platform/gtk/TestExpectations (271055 => 271056)


--- trunk/LayoutTests/platform/gtk/TestExpectations	2020-12-22 18:11:42 UTC (rev 271055)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2020-12-22 18:28:05 UTC (rev 271056)
@@ -412,7 +412,6 @@
 webkit.org/b/210486 imported/w3c/web-platform-tests/media-source/mediasource-correct-frames-after-reappend.html [ Failure Crash Pass ]
 
 # Known issues that were fixed by the WebKitMediaSrc rework that is now reverted.
-webkit.org/b/203078 imported/w3c/web-platform-tests/media-source/mediasource-seek-beyond-duration.html [ Failure ]
 webkit.org/b/203078 imported/w3c/web-platform-tests/media-source/mediasource-replay.html [ Failure Crash ]
 webkit.org/b/203078 imported/w3c/web-platform-tests/media-source/mediasource-config-change-mp4-v-framesize.html [ Pass Failure ]
 

Modified: trunk/Source/WebCore/ChangeLog (271055 => 271056)


--- trunk/Source/WebCore/ChangeLog	2020-12-22 18:11:42 UTC (rev 271055)
+++ trunk/Source/WebCore/ChangeLog	2020-12-22 18:28:05 UTC (rev 271056)
@@ -1,3 +1,17 @@
+2020-12-22  Philippe Normand  <[email protected]>
+
+        REGRESSION(r270612) [GStreamer][MSE] Some play/seek related failures
+        https://bugs.webkit.org/show_bug.cgi?id=219822
+
+        Reviewed by Xabier Rodriguez-Calvar.
+
+        Call appendComplete which internally synchronizes the TrackBuffer buffered ranges and calls
+        m_client->sourceBufferPrivateAppendComplete().
+
+        * platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp:
+        (WebCore::SourceBufferPrivateGStreamer::didReceiveAllPendingSamples):
+        (WebCore::SourceBufferPrivateGStreamer::appendParsingFailed):
+
 2020-12-22  Antti Koivisto  <[email protected]>
 
         [LFC][Integration] Invalidate line layout path for children of inlines

Modified: trunk/Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp (271055 => 271056)


--- trunk/Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp	2020-12-22 18:11:42 UTC (rev 271055)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp	2020-12-22 18:28:05 UTC (rev 271056)
@@ -193,12 +193,12 @@
 
 void SourceBufferPrivateGStreamer::didReceiveAllPendingSamples()
 {
-    m_client->sourceBufferPrivateAppendComplete(SourceBufferPrivateClient::AppendResult::AppendSucceeded);
+    SourceBufferPrivate::appendCompleted(true, m_mediaSource ? m_mediaSource->isEnded() : true);
 }
 
 void SourceBufferPrivateGStreamer::appendParsingFailed()
 {
-    m_client->sourceBufferPrivateAppendComplete(SourceBufferPrivateClient::AppendResult::ParsingFailed);
+    SourceBufferPrivate::appendCompleted(false, m_mediaSource ? m_mediaSource->isEnded() : true);
 }
 
 bool SourceBufferPrivateGStreamer::isSeeking() const
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to